8000 build(minimal-client): drop the unused camino dependency by bryan-minimal · Pull Request #2872 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

build(minimal-client): drop the unused camino dependency - #2872

Merged
bryan-minimal merged 2 commits into
mainfrom
fix/machete-camino
Nov 5, 2026
Merged

bryan-minimal merged 2 commits into
mainfrom
fix/machete-camino

Conversation

@bryan-minimal
@bryan-minimal bryan-minimal commented Nov 3, 2026 •
Copy link
Copy Markdown
Member

cargo machete has failed the nightly hygiene job on main every night since 2026-10-20 on one finding: minimal-client declares camino and uses nothing from it (zero references under crates/minimal-client/src). This removes the line; Cargo.lock loses the edge. No code change.

The PR lane does not run machete, which is why it never blocked a merge; the nightly and the lab's CI mirror do.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • No user-facing changes are included in this update. The change is limited to internal project configuration and does not alter the app’s visible features or behavior. No new capabilities, fixes, or documentation updates are reflected in these release notes.

cargo-machete has failed the nightly hygiene job on main since 2026-10-20 on this one line:
minimal-client declares camino and uses nothing from it. Nothing else changes.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 3, 2026 20:29
@coderabbitai
coderabbitai Bot commented Nov 3, 2026 •
Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f0d8d4fa-5c2b-4264-9765-8b129647b70c
Commits

Reviewing files that changed from the base of the PR and between bc062fe and 8379570.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The minimal client manifest no longer declares camino as a workspace dependency.

Changes: Minimal client dependency

Layer / File(s) Summary
Remove dependency declaration
crates/minimal-client/Cargo.toml
Removed camino.workspace = true from the dependencies.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: norrietaylor

Merge Risk: Minimal · previous review bc062

No actionable merge risk is identified; the dependency cleanup is mergeable after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description provides a clear summary and rationale, but it omits the required ## Testing and ## Checklist sections. It also does not provide test commands or output. Add the ## Testing section with the commands run and relevant output. Add the ## Checklist section and complete each applicable item.
Passed Passed checks: 4 passed

Check name Status Explanation
Title check Passed The title clearly and concisely describes the removal of the unused camino dependency. It follows the required Conventional Commit format.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the manifest at dawn
One dependency line is gone
The meadow keeps its tidy rows
While clover in the cool breeze grows
Hop by hop, the client moves on

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f2ab8a4e-f869-439b-9e49-762ac04dfb8d
Commits

Reviewing files that changed from the base of the PR and between 4137359 and bc062fe.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 1

  • crates/minimal-client/Cargo.toml
Files with no reviewable changes: 1

  • crates/minimal-client/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 1 remain after this review.

@minimal-foundry
minimal-foundry Bot commented Nov 3, 2026 •
Copy link
Copy Markdown
Contributor

Approved: no findings at 8379570a71d3.

Nothing to do.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit 31cc2f9 Nov 5, 2026
35 checks passed
@bryan-minimal
bryan-minimal deleted the fix/machete-camino branch November 5, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0