Repository navigation
"Known limitations" is out of date after this run (#37) - #64
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Review findings for head
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Both Minor items are fixed and pushed, and main is merged in (no conflicts).
The SPEC records both under Review feedback. I also updated the Generated by Claude Code |
|
Automated review (CodeRabbit CLI, run against this branch) found two minor documentation issues:
|
…#37) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Both findings are fixed and pushed.
The SPEC records the feedback under Review feedback. Generated by Claude Code |
Web push makes its own VAPID keys and sends only once a browser has subscribed, so it does not belong with the key-gated subsystems. Give it its own Known limitations entry and correct the egress sentence. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Review of head
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Both findings are fixed and pushed.
Generated by Claude Code |
…ads (#37) Signed-off-by: Claude <noreply@anthropic.com>
Requested by Simon · project thread
What was wrong
INSTALL.md "Known limitations" said nobody had run Deck on Windows, everything was measured only as root, and the Deck-to-agent delivery direction was unproven. The 2026-09-27 WSL run (non-root, Ubuntu 24.04) changed those, and a later merged PR changed a fourth entry. Entries also did not say who measured what, or when. It also said every optional subsystem needs a key, which is not true of web push.
What changed
Only the Known limitations section of INSTALL.md (the README has no copy). Each entry now says what was measured, by whom (rig or by hand) and when. Corrected: the root entry, the Windows entry, the delivery entry, and the paragraph on Deck's terminal send. Added three entries: first boot needs a person, starting Deck on boot is unchecked, and web push is switched on by a browser subscription (no operator key). The egress sentence now says Deck itself needs no egress beyond the optional integrations, and that the agents' model CLIs still need their provider. SPEC at
.specs/37-known-limitations-audit/SPEC.md, with the review feedback recorded.Audit
packages/deck/app/routes; note addedinboxparser on a quoted header in a code fence: split into two senders; a plain## headingdoes not splitpackages/base/conformance/corpus.json: five deviations, all ondeck. No edit needed (entry already says to read the file)inbox reply quillasmewroteme/inbox/quill.md;quill'sinbox unreadsaid "no unread"rig/README.md:116says the stub-agent stage is not builttmux.server.tssendKeysToWindowandtmux-submit.ts: composer gate (unsafe-composer) and re-capture after Enter; added in #43; tests inpackages/deck/test/tmux-send-verification.test.ts.github/workflows/ci.ymlboot-agents.shsession fixed toagentspackages/base/bin/boot-agents.sh:57packages/deck/app/root.tsx:42-51; #32 (merged) fixed loading, not the dependency. Other egress: Gemini, Deepgram, web push once subscribed, and the agents' model CLIspackages/deck/server/voice-proxy.mjs:185-188; Gemini code exists. Not exercised by the rig; not re-run heregetVapidKeysinpackages/deck/app/lib/push.server.tsgenerates and storesvapid-keys.jsonon the first/api/push-subscriberequest;packages/deck/server/push-watcher.mjssends to each stored subscription endpoint only once a browser has subscribed. Not runrig/container-image-note.mdsection 3. By-hand non-root run on WSL, 2026-09-27, from the issuesh-manualblocks are not run by the rigMC_USERdefaults toalexmcUserinpackages/deck/app/lib/instance.server.ts:32-34; note addedpackages/base/bin/boot-agents.sh:642BOOT_READY_SECS(default 45), exit3pending; tier 3 text from #46 and #55How verified
The two behavioural claims were reproduced here (CLI send target, quoted header). The rest is code reading, cited above. Also run:
pnpm typecheck,pnpm test(2227 passed),pnpm check:boundaries,pnpm check:leaks,pnpm check:licence,pnpm check:lib-version,pnpm -C packages/deck check:dashes,node rig/self-test.mjs.What could not be verified
check:leaks:messagesandcheck:leaks:historyare red on older commits on main.Not changed, noted for follow-up
xxdand locale test failures that Investigate and fix packages/base tests that fail on some hosts (xxd and locale dependencies) #57 removed.gh auth loginparagraph can go now the repo is public.Fixes #37
🤖 Generated with Claude Code
https://claude.ai/code/session_01ByrScobyMJ5eQ8EQZzEcWB