Repository navigation
fix(base): honest launch status (#24) - #46
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018uNaFhmK6yxSR7XfzJDY3Z Signed-off-by: Simon <simon@inkie.ink>
Review, Sonnet, 2026-10-02PR 46 (deck issue 24, honest launch status). SHA reviewed: 1b40abf Verdict: NEEDS CHANGES (2 Major) Ran CriticalNone. Major
Minor
Nit
Not checked
|
…review fixes) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Simon <simon@inkie.ink>
|
Review fixes pushed at c95d661: readiness wait restored to 45s (BOOT_READY_SECS), and already-up busy panes no longer fail a re-run. Review legs on c95d661:
Minor notes left open: existing panes report ready for any live node process; a dead launch waits the full 45s; worst-case boot can exceed a 90s unit timeout. |
Keep main's pinned first-boot session ids and provider launch envelope alongside this branch's honest launch status and failure propagation. The Codex send-failure fixture now uses a sandboxed provider home. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018uNaFhmK6yxSR7XfzJDY3Z Signed-off-by: Simon <simon@inkie.ink>
Closes #24.
Reviewed at 1b40abf, two independent legs (CodeRabbit is off):
Both reviews checked that the tests fail without the change.
🤖 Generated with Claude Code
https://claude.ai/code/session_018uNaFhmK6yxSR7XfzJDY3Z