8000 Investigate and fix packages/base tests that fail on some hosts (xxd and locale dependencies) · Issue #57 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

Navigation Menu

Investigate and fix packages/base tests that fail on some hosts (xxd and locale dependencies) #57

Closed

Description

@simon-inkie

What we saw

While reviewing PRs 49, 50 and 51, the reviewer ran the packages/base tests on a clean checkout of main and got four failures that are unrelated to those PRs. The reviewer attributed them to host dependencies: the xxd binary and the system locale. CI on main is green, so the tests pass on the CI image but fail on at least one other Linux environment (a WSL host).

Why it matters

A contributor who clones the repo and runs the tests should not see failures that have nothing to do with their change. It also hides real regressions: reviewers learn to ignore red.

To do

  1. Reproduce on a plain Linux or WSL host, list the four failing tests by name and the exact error for each.
  2. For each, decide: make the test hermetic (set the locale explicitly in the test, avoid shelling out to xxd, or provide a fallback), or skip it with a clear reason when the tool is genuinely absent.
  3. If a tool is a real runtime requirement of the code under test, say so in INSTALL.md and make the failure message explain how to fix it.
  4. Confirm the same four pass on the CI image and on a fresh host after the change.

Acceptance

pnpm test passes on a clean checkout on both the CI image and a stock WSL install, with no skipped test lacking a stated reason.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0