Repository navigation
Investigate and fix packages/base tests that fail on some hosts (xxd and locale dependencies) (#57) - #62
Merged
Conversation
Drop xxd for od, use UTF-8 byte escapes in fixtures, match spinner glyphs byte-wise in pane-idle, and keep node's bin dir off the no-runtime PATH. Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
Owner
Author
|
Review: merge after fixes
The xxd to od change, the explicit byte escapes and the PATH isolation in the tests are good: they remove host dependencies without weakening any assertion. No private material. |
Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
Owner
Author
Signed-off-by: Claude <noreply@anthropic.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Simon · project thread
Fixes #57
What was wrong
Four host dependencies made
packages/basetests fail on hosts that differ from CI:inbox.test.shcalledxxd, which is not installed everywhere.inbox-push.test.shbuilt fixtures with$'\uXXXX'. Outside a UTF-8 locale bash emits?, so ten gate cases saw garbage panes.bin/pane-idlematched spinner glyphs with a multibyte bracket class. UnderLC_ALL=Cthat matches single bytes and misses the spinner. This is a runtime fault, not only a test one: a cron or supervisor run could type into a busy pane.create-agent.test.tsput node's install directory on PATH for the "no runtime" case. Where a globalclaudesits beside node, the test found it.What changed
xxd -pbecomesod -An -v -tx1(POSIX).\uXXXXescapes become UTF-8 byte escapes.pane-idlespinner class becomes a literal alternation.packages/base/README.mdno longer listsxxdas a prerequisite. No tool is newly required, so INSTALL.md is unchanged..specs/57-host-independent-base-tests/SPEC.md.No test was weakened, skipped or deleted.
How verified
cd packages/base && env -i HOME=$HOME PATH=$PATH LC_ALL=C npx vitest run, on a host with noxxdand aclaudebeside node:The four before: create-agent no-runtime, shell-suites
inbox.test.sh,inbox-push.test.sh(10 inner cases),pane-idle.test.sh(1 inner case). Also run on the committed tree:pnpm typecheck,pnpm test(110 files, 2227 passed, 11 skipped),check:boundaries,check:leaks,check:licence,check:lib-version,check:dashes.Not verified
check:leaks:messagesreports findings, which come from existing history; this commit carries no session link.rig/still installs and checksxxd; harmless, left as a follow-up.🤖 Generated with Claude Code
https://claude.ai/code/session_017yJZi4v5U7ruTtPSDy5ki3
Generated by Claude Code