8000 First-boot polish: day-one first message, focus-events, --model (#35, #36) by simon-inkie · Pull Request #61 · simon-inkie/inkie-deck · GitHub
[go: up one dir, main page]

Skip to content

First-boot polish: day-one first message, focus-events, --model (#35, #36) - #61

Merged
simon-inkie merged 4 commits into
mainfrom
35-36-first-boot-polish
Oct 12, 2026
Merged

simon-inkie merged 4 commits into
mainfrom
35-36-first-boot-polish

Conversation

@simon-inkie
@simon-inkie simon-inkie commented Oct 11, 2026 •
Copy link
Copy Markdown
Owner

Requested by Simon · project thread

Fixes #35
Fixes #36

What was wrong

What changed

  • A brand new claude session is launched with a first message: "This is your first session. Do your day-one steps from your persona files (IDENTITY.md and SOUL.md), then say hello." It is sent only on the new-session branch from New agents never start on first boot: --resume <name> opens a picker, and the session is never named #23, only while .first-boot-done is absent, and only while IDENTITY.md is still the scaffold or missing, so a pruned transcript on an established agent does not re-run day one. The marker is written at launch; a launch that dies before the message is recorded needs the marker deleted to resend. Used by boot-agents.sh and workspace.sh. A busy pane after a first boot counts as ready, and a first-boot agent is not sent the arm prompt mid first turn.
  • boot-agents.sh and workspace.sh run tmux set -g focus-events on before any pane starts. tmux has no per-session form of this option, so it applies to the tmux server (the scripts already set mouse globally).
  • create-agent.sh --model <id> writes .model; both launchers validate it before use (plain ids only, ends trimmed, interior spaces refused). The verify probe uses it too.
  • INSTALL.md: model choice and cost, the first message, focus-events, arming after a first boot. SPEC in .specs/35-36-first-boot-polish/, with review rounds recorded.

How verified

boot-agents.test.sh (112 pass): first message only on a never-launched agent, never on resume or a written persona; full first boot sends it once with --session-id, --model from .model, focus-events before the first send and no arm prompt; a second boot resumes, sends nothing and arms. create-agent.test.ts: .model written only when asked, unsafe ids refused. typecheck, boundaries, leaks, history leaks, licence, lib-version and dashes pass. Opus reviewed twice with no blockers.

Not verified

  • Not run against a real Claude Code or tmux, so that the initial prompt submits and the hint disappears is untested.
  • pnpm test in packages/base has 4 failures (CANNOT VERIFY no-runtime, inbox, inbox-push, pane-idle) in the build sandbox that fail identically on untouched main; CI is green.
  • Codex agents get no first message, and optional name/pronouns/time zone collection is not done (SPEC follow-ups).

🤖 Generated with Claude Code

A new claude agent is launched with a standard first message so day-one
persona setup does not depend on the user's first words. boot-agents.sh and
workspace.sh turn on tmux focus-events before any pane starts, and
create-agent.sh --model writes the per-agent .model file.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@simon-inkie simon-inkie self-assigned this Oct 11, 2026
…e .model (#35, #36)

Review round 1: send the first message only while .first-boot-done is absent
and IDENTITY.md is still the scaffold; do not type the arm prompt into a pane
busy with its first turn; validate .model in both launchers; add a second-boot
fixture; restore the opt-out expectation.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@simon-inkie
Copy link
Copy Markdown
Owner Author

Review: merge after fixes

  • Major packages/base/bin/claude-session.sh, agent_model_flag (around line 184): tr -d '[:space:]' removes ALL whitespace, not just leading and trailing. A hand-edited .model containing claude sonnet becomes claudesonnet, passes the id check, and is passed to --model. Trim the ends only (and take the first line), so an id with an interior space is rejected with the existing warning. Add a test for the interior-space case; the current tests cover shell metacharacters but not whitespace.

Otherwise in scope. No private material, no tests weakened.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@simon-inkie
simon-inkie force-pushed the 35-36-first-boot-polish branch from 3fea76a to 5b2bd29 Compare October 11, 2026 16:22
@simon-inkie
Copy link
Copy Markdown
Owner Author

Re-review of 5b2bd29: fixed, good to merge. agent_model_flag now takes the first line and trims the ends only, so an interior space is refused; both the trim and the interior-space cases are tested. Checks green.

@simon-inkie
simon-inkie merged commit 81a7169 into main Oct 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

First-boot polish: tmux focus-events hint and default model New agents only do their day-one setup if the first message asks

2 participants

0