Repository navigation
Warn when the resolved claude is a Windows binary under /mnt/ (#31) - #60
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Simon · project thread
Fixes #31
What was wrong: on WSL, PATH often includes Windows directories, so
command -v claudecan resolve to a Windows binary under/mnt/c/.... Agents then fail to start with no clear reason.What changed:
packages/base/bin/claude-binary-check.shwithwarn_if_foreign_claude. A path under/mnt/or ending.exeor.cmdprints a warning naming the path, the problem and the fix (install the Linux build, or put its directory earlier in PATH).boot-agents.sh,workspace.shandcreate-agent.sh.INSTALL.mdnote under Known limitations; SPEC at.specs/31-warn-windows-claude/SPEC.md.Verified: new
claude-binary-check.test.sh(fake/mnt/cpath,.exe/.cmd, normal paths, absent claude) passes and is registered inshell-suites.test.ts.pnpm typecheck,check:boundaries,check:leaks,check:licence,check:lib-versionandcheck:dashespass.Not verified: no real WSL machine.
pnpm testshows 4 failures (inbox.test.sh,inbox-push.test.sh,pane-idle.test.sh, one create-agent "no runtime on PATH" case) that fail identically on clean main in this container.🤖 Generated with Claude Code
Generated by Claude Code