Repository navigation
go/ir: avoid canonicalizing function signatures - #1764
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This was referenced Oct 2, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic method signatures and generic function signatures can be identical according to Go's signature identity even though method signatures have a receiver. Canonicalizing a generic function's instantiated signature can therefore return a previously interned method signature, giving the function an unexpected receiver and panicking while building its instantiation wrapper. Keep instantiated generic function signatures distinct.
Regression coverage runs the buildir analyzer on the Go 1.27 reproducer from #1749. Validation: go test ./go/ir ./internal/passes/buildir passed on Go 1.26.3 (358 tests); both packages passed on Go 1.27.0; rebuilt staticcheck on Go 1.27.0 returned cleanly on the reproducer.