Repository navigation
Compare AST function and channel types - #1794
Open
dajiaohuang wants to merge 3 commits into
Open
dajiaohuang wants to merge 3 commits into
dajiaohuang wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QF1002 calls astutil.Equal while comparing supported, side-effect-free switch conditions. Equal currently panics when the compared struct literal type contains a pointer to a function, and treats channel types with different elements as identical.
For example, repeated comparisons of
struct{F *func()}{}panic with unreachable: *ast.FuncType. Comparisons ofstruct{C chan int}{} == aandstruct{C chan string}{} == bproduce a tagged-switch suggestion whose second case cannot compile. Compare function type fields and channel element types, including optional typed-nil AST children.Validation: exercised the actual QF1002 analyzer on these valid Go programs. The pre-fix analyzer panics on the function case; applying its channel suggestion fails compilation with mismatched struct types. PR head a14b9a0 handles the function case and emits no incorrect channel suggestion. Earlier focused astutil tests passed. This is focused analyzer validation, not full-suite or upstream CI acceptance.
The unrelated generic-instantiation change was removed; #1764 tracks it separately.