Repository navigation
Validate XML chardata field types - #1789
Closed
dajiaohuang wants to merge 3 commits into
Closed
dajiaohuang wants to merge 3 commits into
dajiaohuang wants to merge 3 commits into
Conversation
Author
|
Withdrawing because the proposed diagnostics do not match encoding/xml. In Go 1.27.0, marshalStruct handles chardata/cdata in its own kind switch and then continues; channel/function fields fall through without returning UnsupportedTypeError. A direct xml.Marshal check with a non-nil channel chardata field and a non-nil function cdata field returns and , respectively, with nil errors. Removing this continue would introduce false-positive SA1026 diagnostics rather than repair the claimed runtime failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fake XML marshaler stops processing ,chardata and ,cdata fields after checking TextMarshaler, so unsupported channel/function fields are missed. Let fields without a marshaler continue through the normal XML type validation and add SA1026 fixtures.
Review update: the unrelated generic-instantiation change and its fixture were removed through a normal follow-up commit; #1764 tracks that fix separately. Current-head validation: go test ./staticcheck/sa1026 passed (three tests); git diff --check passed. Prior validation text above is historical unless repeated here.