Repository navigation
Avoid returning shallow AST type copies - #1793
Closed
dajiaohuang wants to merge 3 commits into
Closed
dajiaohuang wants to merge 3 commits into
dajiaohuang wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
astutil.CopyExpr promises deep copies but returned shallow copies for struct and interface types, leaving nested field lists and expressions shared with the original. Return no copy for these unsupported expression forms until recursive copying is implemented, and document the failure contract.
Scope review and current validation
Removed the unrelated generic-instantiation change and its buildir fixture from this PR through a follow-up commit. That fix remains separately tracked in #1764; this PR now contains only its stated change and relevant tests.
go test ./go/ast/astutilpassed the copy regression (1 test).git diff --checkpassed. Earlier validation above is historical; the checks in this section describe the narrowed head. No live-service or all-CI-passing claim.