Repository navigation
Validate ELF note sizes against section bounds - #1774
Closed
dajiaohuang wants to merge 3 commits into
Closed
dajiaohuang wants to merge 3 commits into
dajiaohuang wants to merge 3 commits into
Conversation
Author
|
Withdrawing this proposal after checking the actual entry points. It changes ReadELFNote/readAligned4, which have no tracked consumers, and no supported external use or documented consumer contract has been established for this copied helper. The actual build-ID consumers call ReadFile and reach the separate readELF path addressed by #1797. The added helper-only malformed-note tests do not establish a current supported-use failure for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate ELF note headers and padded field lengths against the containing section. Reject negative sizes and avoid int32 overflow while aligning fields. Add focused tests for alignment and truncated data. Validation: go test ./go/buildid; git diff --check.
Review update: the unrelated generic-instantiation change and its fixture were removed through a normal follow-up commit; #1764 tracks that fix separately. Current-head validation: go test ./go/buildid (two tests) passed; git diff --check passed. Prior validation text above is historical unless repeated here.