[go: up one dir, main page]

Page MenuHomePhabricator

nalexander (Nick Alexander)
User

User Details

User Since
Oct 3 2017, 8:45 PM (471 w, 2 d)
Availability
Available
Review Queue
10

Recent Activity

Yesterday

nalexander closed D331718: Bug 2079419 - Replace `Settings.shouldShowMicrosurveyPrompt` with `AppState`. r?twhite.
Thu, Oct 15, 11:59 PM · testing-approved
nalexander closed D331719: Bug 2079419 - Post: Remove unused `Settings` from `MessagingMiddleware`. r?twhite.
Thu, Oct 15, 11:59 PM · testing-approved
nalexander closed D331716: Bug 2079419 - Pre: Inline `updateMicrosurveyPromptForConfigurationChange`. r?twhite.
Thu, Oct 15, 11:59 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
nalexander closed D331717: Bug 2079419 - Pre: Lift some extension methods to apply only to `BaseBrowserFragment`. r?twhite.
Thu, Oct 15, 11:59 PM · testing-approved
nalexander committed rFIREFOXAUTOLANDf3c79a044eda: Bug 2079419 - Post: Remove unused `Settings` from `MessagingMiddleware`. (authored by nalexander).
Bug 2079419 - Post: Remove unused `Settings` from `MessagingMiddleware`.
Thu, Oct 15, 11:59 PM
nalexander committed rFIREFOXAUTOLANDef8767124875: Bug 2079419 - Replace `Settings.shouldShowMicrosurveyPrompt` with `AppState`. (authored by nalexander).
Bug 2079419 - Replace `Settings.shouldShowMicrosurveyPrompt` with `AppState`.
Thu, Oct 15, 11:58 PM
nalexander committed rFIREFOXAUTOLAND15c3e3fab7f5: Bug 2079419 - Pre: Inline `updateMicrosurveyPromptForConfigurationChange`. (authored by nalexander).
Bug 2079419 - Pre: Inline `updateMicrosurveyPromptForConfigurationChange`.
Thu, Oct 15, 11:58 PM
nalexander committed rFIREFOXAUTOLAND4ac94eacd609: Bug 2079419 - Pre: Lift some extension methods to apply only to… (authored by nalexander).
Bug 2079419 - Pre: Lift some extension methods to apply only to…
Thu, Oct 15, 11:58 PM
nalexander added inline comments to D331718: Bug 2079419 - Replace `Settings.shouldShowMicrosurveyPrompt` with `AppState`. r?twhite.
Thu, Oct 15, 7:03 PM · testing-approved
nalexander accepted D331520: Bug 2072855 - Don't leak `CC` and `CFLAGS` into the environment of the process reading gyp files r?#build.

Now that @ahochheiden has addressed @sergesanspaille's comment, this looks sensible to me.

Thu, Oct 15, 5:39 PM · testing-approved

Tue, Oct 13

nalexander accepted D333058: Bug 2081010 - Pass '/'-separated package paths to sdkmanager on Windows. r?#android-reviewers.

Is it possible that we should avoid the workaround and just use / everywhere?

Tue, Oct 13, 4:06 PM · testing-exception-other (Please leave a comment explaining why)

Fri, Oct 9

nalexander accepted D332074: Bug 2041477 - Move classes and middlewares from components.ipprotection to org.mozilla.fenix.ipprotection package.

Nothing worrying me here, and o.m.f.components.* was definitely not the right home for this feature-related code.

Fri, Oct 9, 7:06 PM · testing-approved
nalexander accepted D331843: Bug 1928469 - Part 2 - Link the Windows Rust test binaries with `-FORCE:UNRESOLVED` r?nalexander,#build.

Fine.

Fri, Oct 9, 5:27 PM · testing-approved
nalexander requested changes to D331842: Bug 1928469 - Part 1 - Support running individual crates with `./mach rusttests` r?nalexander,#build.

This commit message is actively unhelpful: all detail with no motivation. Rewrite it to explain _why_ all of these AI slop choices are being made. Why not make everybody enumerate RUST_TESTS for crates that should be part of rusttests?

Fri, Oct 9, 5:25 PM · testing-approved
nalexander accepted D331841: Bug 1928469 - Part 1 - Generate a `rusttests` target for every directory with a Rust library or program r?nalexander,#build.

OK.

Fri, Oct 9, 5:17 PM · testing-approved

Thu, Oct 8

nalexander committed rFIREFOXBETAe59a3e609040: Bug 2076826 - Part 3: Move `VerifyGleanVersion` to the Gradle `conventions`… (authored by nalexander).
Bug 2076826 - Part 3: Move `VerifyGleanVersion` to the Gradle `conventions`…
Thu, Oct 8, 3:04 PM
nalexander committed rFIREFOXBETAb4f08ab3eb96: Bug 2076826 - Part 2: Move `glean-native` `project(:geckoview)` resolution into… (authored by nalexander).
Bug 2076826 - Part 2: Move `glean-native` `project(:geckoview)` resolution into…
Thu, Oct 8, 3:04 PM
nalexander committed rFIREFOXBETAc974b6384519: Bug 2076826 - Part 1: Remove duplicated `glean-native` version verification. (authored by nalexander).
Bug 2076826 - Part 1: Remove duplicated `glean-native` version verification.
Thu, Oct 8, 3:04 PM
nalexander committed rFIREFOXBETAbf06403ee457: Bug 2075667 - Vendor application-services `a191beab` to limit `glean-sym`… (authored by ahochheiden).
Bug 2075667 - Vendor application-services `a191beab` to limit `glean-sym`…
Thu, Oct 8, 2:47 PM
nalexander committed rFIREFOXBETAc097d043ccfd: Bug 2035575 - Add a temporary duplicate set of CI tasks that build app-services… (authored by ahochheiden).
Bug 2035575 - Add a temporary duplicate set of CI tasks that build app-services…
Thu, Oct 8, 2:47 PM
nalexander committed rFIREFOXBETAcefb09247c10: Bug 2035575 - Link the Android megazord against `mozglue` again r=firefox-build… (authored by ahochheiden).
Bug 2035575 - Link the Android megazord against `mozglue` again r=firefox-build…
Thu, Oct 8, 2:47 PM
nalexander committed rFIREFOXBETA024b3e53a118: Bug 2075667 - Vendor `uniffi` version `0.32.2` (or higher) to fix Kotlin unused… (authored by nalexander).
Bug 2075667 - Vendor `uniffi` version `0.32.2` (or higher) to fix Kotlin unused…
Thu, Oct 8, 2:47 PM
nalexander committed rFIREFOXBETA02e3938768cf: Bug 2069438 - Add a cargo-vet policy for the git-fetched nss-rs. r=supply-chain… (authored by joschmidt).
Bug 2069438 - Add a cargo-vet policy for the git-fetched nss-rs. r=supply-chain…
Thu, Oct 8, 2:46 PM
nalexander committed rFIREFOXBETAc3eb4ff1379e: Bug 2027882 - Remove `nimbus-fml` and `embedded-uniffi-bindgen` deps from… (authored by nalexander).
Bug 2027882 - Remove `nimbus-fml` and `embedded-uniffi-bindgen` deps from…
Thu, Oct 8, 2:46 PM
nalexander committed rFIREFOXBETAc5073ec41830: Bug 2075709 - Post: Remove :nalexander as peer from some modules. r=ahochheiden (authored by nalexander).
Bug 2075709 - Post: Remove :nalexander as peer from some modules. r=ahochheiden
Thu, Oct 8, 2:46 PM
nalexander committed rFIREFOXBETA6c35880999e9: Bug 2075709 - Make :ahochheiden module owner of `Core: Build Config - Fenix`… (authored by nalexander).
Bug 2075709 - Make :ahochheiden module owner of `Core: Build Config - Fenix`…
Thu, Oct 8, 2:46 PM

Wed, Oct 7

nalexander committed rFIREFOXRELEASE50cf6fca8f6b: Bug 1794663 - Post: Fix HTTPS-Only back button. r=petru,parker,android… (authored by nalexander).
Bug 1794663 - Post: Fix HTTPS-Only back button. r=petru,parker,android…
Wed, Oct 7, 11:27 PM
nalexander committed rFIREFOXRELEASEe251bb1ebbf6: Bug 1794663 - Make `concept-engine` not depend on `browser-errorpages`. (authored by nalexander).
Bug 1794663 - Make `concept-engine` not depend on `browser-errorpages`.
Wed, Oct 7, 11:27 PM
nalexander added a comment to D331719: Bug 2079419 - Post: Remove unused `Settings` from `MessagingMiddleware`. r?twhite.

This patch cleans up the unused settings violation from earlier in the stack. I quite like having it be a Post: clean-up, but if needed it can be folded earlier.

Wed, Oct 7, 9:07 PM · testing-approved
nalexander added a comment to D331719: Bug 2079419 - Post: Remove unused `Settings` from `MessagingMiddleware`. r?twhite.

https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=101676

Wed, Oct 7, 9:06 PM · testing-approved
nalexander updated the diff for D331719: Bug 2079419 - Post: Remove unused `Settings` from `MessagingMiddleware`. r?twhite.
Wed, Oct 7, 9:00 PM · testing-approved
nalexander updated the diff for D331718: Bug 2079419 - Replace `Settings.shouldShowMicrosurveyPrompt` with `AppState`. r?twhite.
Wed, Oct 7, 9:00 PM · testing-approved
nalexander updated the diff for D331717: Bug 2079419 - Pre: Lift some extension methods to apply only to `BaseBrowserFragment`. r?twhite.
Wed, Oct 7, 9:00 PM · testing-approved
nalexander updated the diff for D331716: Bug 2079419 - Pre: Inline `updateMicrosurveyPromptForConfigurationChange`. r?twhite.
Wed, Oct 7, 9:00 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
nalexander created D331719: Bug 2079419 - Post: Remove unused `Settings` from `MessagingMiddleware`. r?twhite.
Wed, Oct 7, 6:38 PM · testing-approved
nalexander created D331718: Bug 2079419 - Replace `Settings.shouldShowMicrosurveyPrompt` with `AppState`. r?twhite.
Wed, Oct 7, 6:38 PM · testing-approved
nalexander created D331717: Bug 2079419 - Pre: Lift some extension methods to apply only to `BaseBrowserFragment`. r?twhite.
Wed, Oct 7, 6:38 PM · testing-approved
nalexander created D331716: Bug 2079419 - Pre: Inline `updateMicrosurveyPromptForConfigurationChange`. r?twhite.
Wed, Oct 7, 6:38 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)

Tue, Oct 6

nalexander added a comment to D323768: Bug 2065488 - Part 3: Record telemetry for the lifecycle of the privacy notification worker.

Re: testing -- this is what the Glean Debug Ping Viewer is for. See https://mozilla.github.io/glean/book/reference/debug/index.html. You can also have Glean do the logging for you without having to set breakpoints, etc. (But your automated tests are better still, and don't require nudging the clock around.)

Tue, Oct 6, 8:51 PM · testing-approved, Restricted Project
nalexander accepted D323768: Bug 2065488 - Part 3: Record telemetry for the lifecycle of the privacy notification worker.

This looks like I expect -- thanks for reworking it, @gmalekpour, and sorry for the delayed review. (I appreciate the nudge, it's easy to drop things by accident.)

Tue, Oct 6, 8:49 PM · testing-approved, Restricted Project

Mon, Oct 5

nalexander accepted D330512: Bug 2077804 - Remove the `@depends` functions whose value nothing reads r?#build.

Fine for the gradle.configure bits.

Mon, Oct 5, 6:26 PM · testing-approved
nalexander accepted D330834: Bug 2068239 - Use 4 shards for gv-junit tests. r?#geckoview-reviewers.
Mon, Oct 5, 6:22 PM · testing-approved

Sun, Oct 4

nalexander closed D329996: Bug 2076826 - Part 3: Move `VerifyGleanVersion` to the Gradle `conventions` plugin. r?ahochheiden.
Sun, Oct 4, 3:44 AM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander committed rFIREFOXAUTOLANDe59a3e609040: Bug 2076826 - Part 3: Move `VerifyGleanVersion` to the Gradle `conventions`… (authored by nalexander).
Bug 2076826 - Part 3: Move `VerifyGleanVersion` to the Gradle `conventions`…
Sun, Oct 4, 3:44 AM
nalexander closed D329995: Bug 2076826 - Part 2: Move `glean-native` `project(:geckoview)` resolution into Gradle conventions plugin. r?ahochheiden.
Sun, Oct 4, 3:44 AM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander closed D329994: Bug 2076826 - Part 1: Remove duplicated `glean-native` version verification. r?ahochheiden.
Sun, Oct 4, 3:44 AM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander committed rFIREFOXAUTOLANDc974b6384519: Bug 2076826 - Part 1: Remove duplicated `glean-native` version verification. (authored by nalexander).
Bug 2076826 - Part 1: Remove duplicated `glean-native` version verification.
Sun, Oct 4, 3:44 AM
nalexander committed rFIREFOXAUTOLANDb4f08ab3eb96: Bug 2076826 - Part 2: Move `glean-native` `project(:geckoview)` resolution into… (authored by nalexander).
Bug 2076826 - Part 2: Move `glean-native` `project(:geckoview)` resolution into…
Sun, Oct 4, 3:44 AM
nalexander removed a reviewer for D329996: Bug 2076826 - Part 3: Move `VerifyGleanVersion` to the Gradle `conventions` plugin. r?ahochheiden: geckoview-reviewers.

This doesn't require geckoview-reviewers.

Sun, Oct 4, 3:40 AM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander accepted D330483: Bug 2035575 - Target app-services tasks only when their counterpart runs r?nalexander.

I'm fine with this if it unblocks things.

Sun, Oct 4, 3:34 AM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander accepted D330482: Bug 2035575 - Package tests in the `android-aarch64-appservices/opt` and `android-x86_64-appservices/debug` builds r?nalexander.
Sun, Oct 4, 3:32 AM · testing-exception-unchanged (Doesn't change behavior for users)

Thu, Oct 1

nalexander accepted D329614: Bug 2076202 - Remove source-test-android-lint task from CI as mozlint-android replaces it..

Yes! Very happy to see these top-level Gradle project lints become the source of truth for all of the Android linting.

Thu, Oct 1, 6:38 PM · testing-exception-unchanged (Doesn't change behavior for users)

Wed, Sep 30

nalexander accepted D329966: Bug 2035575 - Hide duplicated tasks from `mach try fuzzy` unless `--include-duplicates` is passed r?nalexander,ahal.

Great!

Wed, Sep 30, 6:55 PM · testing-approved
nalexander added a comment to D329996: Bug 2076826 - Part 3: Move `VerifyGleanVersion` to the Gradle `conventions` plugin. r?ahochheiden.

This is looking healthy: https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=285367a27940edb8a0501dae54d6637be20d7fc6

Wed, Sep 30, 5:14 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander accepted D329868: Bug 2035575 - Fetch the Android Rust toolchain in the `android-x86_64-appservices/debug` build r?nalexander.

How on earth did this ever work?

Wed, Sep 30, 5:13 PM · testing-approved
nalexander created D329996: Bug 2076826 - Part 3: Move `VerifyGleanVersion` to the Gradle `conventions` plugin. r?ahochheiden.
Wed, Sep 30, 5:11 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander created D329995: Bug 2076826 - Part 2: Move `glean-native` `project(:geckoview)` resolution into Gradle conventions plugin. r?ahochheiden.
Wed, Sep 30, 5:11 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander created D329994: Bug 2076826 - Part 1: Remove duplicated `glean-native` version verification. r?ahochheiden.
Wed, Sep 30, 5:11 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander accepted D329869: Bug 2035575 - Fix appservices-in-tree consumer versions r?nalexander.

This is horrific, but it does address the problem today. It's horrific because we want the plugin to be the source of truth, and this adds accommodations for some random Gradle file to be the source of truth. But fixing this can be follow-up, getting green -as builds is worth a lot.

Wed, Sep 30, 3:24 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander accepted D329949: Bug 1876516 - Change ConsoleLogLevel and maxLogLevel strings from PascalCase to camelCase r?#firefox-desktop-core-reviewers,#dom-core,#devtools-reviewers.

r+ for mobile/.

Wed, Sep 30, 3:07 PM · testing-exception-unchanged (Doesn't change behavior for users)

Sat, Sep 26

nalexander closed D329346: Bug 2075667 - Vendor application-services `a191beab` to limit `glean-sym` metrics to Android r?nalexander.
Sat, Sep 26, 5:30 AM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander closed D329267: Bug 2075667 - Vendor `uniffi` version `0.32.2` (or higher) to fix Kotlin unused symbols error with `--enable-appservices-in-tree`. r?ahochheiden.
Sat, Sep 26, 5:30 AM · testing-approved
nalexander closed D320192: Bug 2035575 - Add a temporary duplicate set of CI tasks that build app-services in tree r?nalexander,ahal.
Sat, Sep 26, 5:30 AM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander committed rFIREFOXAUTOLANDbf06403ee457: Bug 2075667 - Vendor application-services `a191beab` to limit `glean-sym`… (authored by ahochheiden).
Bug 2075667 - Vendor application-services `a191beab` to limit `glean-sym`…
Sat, Sep 26, 5:30 AM
nalexander closed D322556: Bug 2035575 - Link the Android megazord against `mozglue` again r?#build,nalexander.
Sat, Sep 26, 5:30 AM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander committed rFIREFOXAUTOLANDcefb09247c10: Bug 2035575 - Link the Android megazord against `mozglue` again r=firefox-build… (authored by ahochheiden).
Bug 2035575 - Link the Android megazord against `mozglue` again r=firefox-build…
Sat, Sep 26, 5:30 AM
nalexander committed rFIREFOXAUTOLANDc097d043ccfd: Bug 2035575 - Add a temporary duplicate set of CI tasks that build app-services… (authored by ahochheiden).
Bug 2035575 - Add a temporary duplicate set of CI tasks that build app-services…
Sat, Sep 26, 5:30 AM
nalexander committed rFIREFOXAUTOLAND024b3e53a118: Bug 2075667 - Vendor `uniffi` version `0.32.2` (or higher) to fix Kotlin unused… (authored by nalexander).
Bug 2075667 - Vendor `uniffi` version `0.32.2` (or higher) to fix Kotlin unused…
Sat, Sep 26, 5:30 AM
nalexander removed a reviewer for D329346: Bug 2075667 - Vendor application-services `a191beab` to limit `glean-sym` metrics to Android r?nalexander: places-reviewers.
Sat, Sep 26, 3:13 AM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander abandoned D329362: Bug 2075667 - Post: Update generated Kotlin with `mach uniffi generate`. r?ahochheiden.

Done in https://phabricator.services.mozilla.com/D329267.

Sat, Sep 26, 3:12 AM · testing-approved
nalexander created D329362: Bug 2075667 - Post: Update generated Kotlin with `mach uniffi generate`. r?ahochheiden.
Sat, Sep 26, 3:06 AM · testing-approved
nalexander updated the diff for D329267: Bug 2075667 - Vendor `uniffi` version `0.32.2` (or higher) to fix Kotlin unused symbols error with `--enable-appservices-in-tree`. r?ahochheiden.
Sat, Sep 26, 3:06 AM · testing-approved
nalexander accepted D329346: Bug 2075667 - Vendor application-services `a191beab` to limit `glean-sym` metrics to Android r?nalexander.
Sat, Sep 26, 2:51 AM · testing-exception-unchanged (Doesn't change behavior for users)

Fri, Sep 25

nalexander closed D329204: Bug 2069438 - Add a cargo-vet policy for the git-fetched nss-rs. r?#supply-chain-reviewers.
Fri, Sep 25, 11:33 PM · testing-approved
nalexander committed rFIREFOXAUTOLAND02e3938768cf: Bug 2069438 - Add a cargo-vet policy for the git-fetched nss-rs. r=supply-chain… (authored by joschmidt).
Bug 2069438 - Add a cargo-vet policy for the git-fetched nss-rs. r=supply-chain…
Fri, Sep 25, 11:33 PM
nalexander closed D329284: Bug 2027882 - Remove `nimbus-fml` and `embedded-uniffi-bindgen` deps from `onnx` toolchains. r?ahochheiden.
Fri, Sep 25, 11:31 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander committed rFIREFOXAUTOLANDc3eb4ff1379e: Bug 2027882 - Remove `nimbus-fml` and `embedded-uniffi-bindgen` deps from… (authored by nalexander).
Bug 2027882 - Remove `nimbus-fml` and `embedded-uniffi-bindgen` deps from…
Fri, Sep 25, 11:31 PM
nalexander closed D329298: Bug 2075709 - Post: Remove :nalexander as peer from some modules. r?ahochheiden.
Fri, Sep 25, 10:01 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander committed rFIREFOXAUTOLANDc5073ec41830: Bug 2075709 - Post: Remove :nalexander as peer from some modules. r=ahochheiden (authored by nalexander).
Bug 2075709 - Post: Remove :nalexander as peer from some modules. r=ahochheiden
Fri, Sep 25, 10:01 PM
nalexander closed D329297: Bug 2075709 - Make :ahochheiden module owner of `Core: Build Config - Fenix`; add :tcampbell as peer. r?ahochheiden.
Fri, Sep 25, 10:01 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander committed rFIREFOXAUTOLAND6c35880999e9: Bug 2075709 - Make :ahochheiden module owner of `Core: Build Config - Fenix`… (authored by nalexander).
Bug 2075709 - Make :ahochheiden module owner of `Core: Build Config - Fenix`…
Fri, Sep 25, 10:01 PM
nalexander accepted D329204: Bug 2069438 - Add a cargo-vet policy for the git-fetched nss-rs. r?#supply-chain-reviewers.

I want this and am going to land it to unblock https://phabricator.services.mozilla.com/D329267.

Fri, Sep 25, 8:08 PM · testing-approved
nalexander abandoned D329266: Bug 2075667 - Pre: Accommodate newly published placeholder https://crates.io/crates/nss-rs. r?ahochheiden.

Superceded by https://phabricator.services.mozilla.com/D329204.

Fri, Sep 25, 8:07 PM
nalexander added a comment to D329284: Bug 2027882 - Remove `nimbus-fml` and `embedded-uniffi-bindgen` deps from `onnx` toolchains. r?ahochheiden.

https://treeherder.mozilla.org/jobs?repo=try&revision=399dbe5f045f3df47b26fb78fa3ac21fc871632f

Fri, Sep 25, 7:56 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander created D329298: Bug 2075709 - Post: Remove :nalexander as peer from some modules. r?ahochheiden.

Please ensure that mots clean is run before this patch lands. See https://mots.readthedocs.io/en/latest/#cleaning-mots-yaml for more information.

Fri, Sep 25, 7:27 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander created D329297: Bug 2075709 - Make :ahochheiden module owner of `Core: Build Config - Fenix`; add :tcampbell as peer. r?ahochheiden.

Please ensure that mots clean is run before this patch lands. See https://mots.readthedocs.io/en/latest/#cleaning-mots-yaml for more information.

Fri, Sep 25, 7:27 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander added a comment to D329284: Bug 2027882 - Remove `nimbus-fml` and `embedded-uniffi-bindgen` deps from `onnx` toolchains. r?ahochheiden.

https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=97592

Fri, Sep 25, 7:06 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander created D329284: Bug 2027882 - Remove `nimbus-fml` and `embedded-uniffi-bindgen` deps from `onnx` toolchains. r?ahochheiden.
Fri, Sep 25, 7:05 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander accepted D320080: Bug 2054532 - Improve nimbus-fml build times. r?nalexander,beth.

Sorry for the long delay. I'm fine with this; it looks better than what we had before. But it feels to me like the end game here is that the nimbus-fml binaries are provided in Maven artifacts so that all of the version resolution, etc, happens once and is done by Gradle. That's not all that easy to arrange _and_ we're rapidly moving to an application-services-in-tree world so please don't spend time making that happen; but at a high level, that's how this probably should be structured. (There are lots of instances of this; I think that aapt2 gets delivered this way in the Android ecosystem, for example.)

Fri, Sep 25, 5:50 PM · testing-exception-unchanged (Doesn't change behavior for users)
nalexander abandoned D223066: Bug 1920375 - [DEMO] Exploration with screen showing set to default when no profile refresh prompt.
Fri, Sep 25, 5:41 PM
nalexander commandeered D223066: Bug 1920375 - [DEMO] Exploration with screen showing set to default when no profile refresh prompt.
Fri, Sep 25, 5:41 PM
nalexander abandoned D157373: Bug 1790692 - Post: Remove setting icon as image, Windows now supports icons for alerts. r=nalexander.
Fri, Sep 25, 5:41 PM
nalexander commandeered D157373: Bug 1790692 - Post: Remove setting icon as image, Windows now supports icons for alerts. r=nalexander.
Fri, Sep 25, 5:41 PM
nalexander added a comment to D329267: Bug 2075667 - Vendor `uniffi` version `0.32.2` (or higher) to fix Kotlin unused symbols error with `--enable-appservices-in-tree`. r?ahochheiden.

https://treeherder.mozilla.org/jobs?repo=try&revision=a489007e2fe790a466520c5443d2934841a32760

Fri, Sep 25, 5:40 PM · testing-approved
nalexander created D329267: Bug 2075667 - Vendor `uniffi` version `0.32.2` (or higher) to fix Kotlin unused symbols error with `--enable-appservices-in-tree`. r?ahochheiden.
Fri, Sep 25, 5:38 PM · testing-approved
nalexander created D329266: Bug 2075667 - Pre: Accommodate newly published placeholder https://crates.io/crates/nss-rs. r?ahochheiden.
Fri, Sep 25, 5:38 PM
nalexander accepted D328118: Bug 2074026 - Always handle CSP before MixedContentBlocker. r?emilio.

Fine by me.

Fri, Sep 25, 3:58 PM · testing-approved

Thu, Sep 24

nalexander committed rFIREFOXBETA50cf6fca8f6b: Bug 1794663 - Post: Fix HTTPS-Only back button. r=petru,parker,android… (authored by nalexander).
Bug 1794663 - Post: Fix HTTPS-Only back button. r=petru,parker,android…
Thu, Sep 24, 3:57 PM
nalexander committed rFIREFOXBETAe251bb1ebbf6: Bug 1794663 - Make `concept-engine` not depend on `browser-errorpages`. (authored by nalexander).
Bug 1794663 - Make `concept-engine` not depend on `browser-errorpages`.
Thu, Sep 24, 3:57 PM

Wed, Sep 23

nalexander accepted D328622: Bug 2074823 - Don't set contentDescription to space. r?#accessibility-platform-reviewers.
Wed, Sep 23, 10:02 PM · testing-approved