[go: up one dir, main page]
Page MenuHomePhabricator
Differential D332074

Bug 2041477 - Move classes and middlewares from components.ipprotection to org.mozilla.fenix.ipprotection package
ClosedPublic
Actions

Authored by sfamisa on Thu, Oct 8, 4:01 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Oct 15, 5:26 AM
Unknown Object (File)
Thu, Oct 15, 4:28 AM
Unknown Object (File)
Thu, Oct 15, 1:20 AM
Unknown Object (File)
Wed, Oct 14, 8:22 PM
Unknown Object (File)
Wed, Oct 14, 7:42 PM
Unknown Object (File)
Wed, Oct 14, 7:38 PM
Unknown Object (File)
Wed, Oct 14, 7:09 PM
Unknown Object (File)
Tue, Oct 13, 1:39 AM
View All 17 Files
Subscribers
cbect
nalexander

Details

Reviewers
nalexander
Group Reviewers
android-reviewers
Commits
rFIREFOXAUTOLAND6411c7c91741: Bug 2041477 - Move classes and middlewares from components.ipprotection to org.
Bugzilla Bug ID
2041477

Diff Detail

Event Timeline

sfamisa created this revision.Thu, Oct 8, 4:01 PM
Herald added a project: secure-revision. · View Herald TranscriptThu, Oct 8, 4:01 PM
phab-bot published this revision for review.Thu, Oct 8, 4:02 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: android-reviewers. · View Herald TranscriptThu, Oct 8, 4:02 PM
sfamisa added a comment.EditedThu, Oct 8, 4:03 PM

try: https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=102146

sfamisa updated this revision to Diff 1400276.Thu, Oct 8, 4:08 PM
Harbormaster failed remote builds in B1060390: Diff 1400255!Thu, Oct 8, 4:18 PM
Harbormaster completed remote builds in B1060412: Diff 1400276.Thu, Oct 8, 4:43 PM
sfamisa added a comment.Thu, Oct 8, 4:58 PM

Ugh. Android Studio move does not update tests! I was wondering why there was no test imports changed even after moving the files.

sfamisa updated this revision to Diff 1401454.Fri, Oct 9, 9:54 AM
reviewbot added a project: testing-approved.Fri, Oct 9, 10:20 AM
Harbormaster completed remote builds in B1061226: Diff 1401454.Fri, Oct 9, 10:21 AM
cbect added a subscriber: cbect.Fri, Oct 9, 1:57 PM

Is there a plan to also move the corresponding test files from components.ipprotection to org.mozilla.fenix.ipprotection package for consistency?

  • FenixIPProtectionEligibilityStorageTest
  • IPProtectionInfoPrompterTest
  • IPProtectionRepositoryMiddlewareTest
  • IPProtectionSnackbarMiddlewareTest
  • IPProtectionTelemetryMiddlewareTest
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/ipprotection/IPProtection.kt
5

question: Should IPProtection.kt be also moved to org.mozilla.fenix.ipprotection package?

cbect added inline comments.Fri, Oct 9, 2:01 PM
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/ipprotection/IPProtection.kt
5

My bad, it's belong here. I somehow didn't realize this was a component at first

sfamisa marked 2 inline comments as done.Fri, Oct 9, 4:09 PM
sfamisa added inline comments.
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/ipprotection/IPProtection.kt
5

Great question! And you are right!

This is the "dependency component", so we want to leave it in this package.

nalexander accepted this revision.Fri, Oct 9, 7:06 PM
nalexander added a subscriber: nalexander.

Nothing worrying me here, and o.m.f.components.* was definitely not the right home for this feature-related code.

This revision is now accepted and ready to land.Fri, Oct 9, 7:06 PM
sfamisa updated this revision to Diff 1402251.Fri, Oct 9, 8:44 PM
sfamisa retitled this revision from Bug 2041477 - Move components.ipprotection to org.mozilla.fenix.ipprotection package to Bug 2041477 - Move classes and middlewares from components.ipprotection to org.mozilla.fenix.ipprotection package.
sfamisa added a comment.Fri, Oct 9, 8:45 PM
In D332074#11551287, @cbect wrote:

Is there a plan to also move the corresponding test files from components.ipprotection to org.mozilla.fenix.ipprotection package for consistency?

  • FenixIPProtectionEligibilityStorageTest
  • IPProtectionInfoPrompterTest
  • IPProtectionRepositoryMiddlewareTest
  • IPProtectionSnackbarMiddlewareTest
  • IPProtectionTelemetryMiddlewareTest

Good point @cbect - I moved them and ran another try here - https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=102918

Thanks @nalexander for the r+

Once the try completes, I'll land the changes

Harbormaster completed remote builds in B1061781: Diff 1402251.Fri, Oct 9, 9:08 PM
Closed by commit rFIREFOXAUTOLAND6411c7c91741: Bug 2041477 - Move classes and middlewares from components.ipprotection to org. (authored by sfamisa). · Explain WhySat, Oct 10, 5:48 AM
This revision was automatically updated to reflect the committed changes.
sfamisa added a commit: rFIREFOXAUTOLAND6411c7c91741: Bug 2041477 - Move classes and middlewares from components.ipprotection to org..

Revision Contents
Changeset List

Diff 1402548

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/ipprotection/FenixIPProtectionEligibilityStorage.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/ipprotection/IPProtection.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/ipprotection/IPProtectionInfoPrompter.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/ipprotection/IPProtectionPreferencesMiddleware.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/ipprotection/IPProtectionSnackbarMiddleware.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/ipprotection/IPProtectionTelemetryMiddleware.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/ipprotection/store/FenixIPProtectionEligibilityStorage.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/ipprotection/store/IPProtectionInfoPrompter.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/ipprotection/store/IPProtectionPreferencesMiddleware.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/ipprotection/store/IPProtectionSnackbarMiddleware.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/ipprotection/store/IPProtectionTelemetryMiddleware.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/ipprotection/FenixIPProtectionEligibilityStorageTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/ipprotection/IPProtectionInfoPrompterTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/ipprotection/IPProtectionRepositoryMiddlewareTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/ipprotection/IPProtectionSnackbarMiddlewareTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/ipprotection/IPProtectionTelemetryMiddlewareTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/ipprotection/store/FenixIPProtectionEligibilityStorageTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/ipprotection/store/IPProtectionInfoPrompterTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/ipprotection/store/IPProtectionRepositoryMiddlewareTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/ipprotection/store/IPProtectionSnackbarMiddlewareTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/ipprotection/store/IPProtectionTelemetryMiddlewareTest.kt

Loading...
Privacy · Cookies · Legal