[go: up one dir, main page]
Page MenuHomePhabricator
Differential D330370

Bug 2046071 - Preserve users initial intent through onboarding and process it on completion.
AcceptedPublic
Actions

Authored by twhite on Fri, Oct 2, 2:37 PM.
Tags
Referenced Files
F84513809: D330370.1792401571.diff
Sun, Oct 18, 9:19 AM
F84507235: D330370.1792394094.diff
Sun, Oct 18, 7:14 AM
F84473988: D330370.1792355554.diff
Sat, Oct 17, 8:32 PM
F84466710: D330370.1792347812.diff
Sat, Oct 17, 6:23 PM
Unknown Object (File)
Thu, Oct 15, 10:28 AM
Unknown Object (File)
Thu, Oct 15, 6:09 AM
Unknown Object (File)
Thu, Oct 15, 12:13 AM
Unknown Object (File)
Mon, Oct 12, 11:46 PM
View All 22 Files
Subscribers
cbect

Details

Reviewers
cbect
Group Reviewers
android-reviewers
Bugzilla Bug ID
2046071
Merge Conflict Status
Landing may fail: this does not merge cleanly into the target branch
Conflicts when merged against target branch tip 2b1a7760c38c, starting from 4b5e436b8bc9.
Last checked Thu, Oct 15, 2:15 PM
Diff 1398387, based on 4b5e436b8bc9
Summary

For example, when a user opens Firefox for the first time via an external link, they must complete onboarding before continuing. Previously, they were then taken to the homepage and the original link was lost.

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

twhite created this revision.Fri, Oct 2, 2:37 PM
Herald added a project: secure-revision. · View Herald TranscriptFri, Oct 2, 2:37 PM
phab-bot published this revision for review.Fri, Oct 2, 2:37 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: android-reviewers. · View Herald TranscriptFri, Oct 2, 2:37 PM
twhite updated this revision to Diff 1393910.Fri, Oct 2, 2:53 PM
Harbormaster failed remote builds in B1055815: Diff 1393901!Fri, Oct 2, 2:58 PM
reviewbot added a project: testing-approved.Fri, Oct 2, 3:18 PM
Harbormaster completed remote builds in B1055821: Diff 1393910.Fri, Oct 2, 3:18 PM
twhite updated this revision to Diff 1393940.Fri, Oct 2, 3:24 PM
twhite added a comment.Fri, Oct 2, 3:28 PM

https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=99587

twhite updated this revision to Diff 1393944.Fri, Oct 2, 3:35 PM
twhite retitled this revision from Bug 2046071 - Preserve external URL through onboarding and open it on completion. to Bug 2046071 - Preserve users initial intent through onboarding and process it on completion..
twhite edited the summary of this revision. (Show Details)
Harbormaster failed remote builds in B1055846: Diff 1393940!Fri, Oct 2, 3:40 PM
Harbormaster completed remote builds in B1055847: Diff 1393944.Fri, Oct 2, 3:59 PM
cbect accepted this revision.Mon, Oct 5, 4:09 PM
cbect added a subscriber: cbect.

LGTM! Well done

This revision is now accepted and ready to land.Mon, Oct 5, 4:09 PM
twhite updated this revision to Diff 1398387.Wed, Oct 7, 3:10 PM
twhite added a child revision: D331635: WIP: Bug 2077533 - Preserve external intents received on a warm start during onboarding and process them on completion..
Harbormaster completed remote builds in B1058968: Diff 1398387.Wed, Oct 7, 3:34 PM
twhite added a comment.Wed, Oct 14, 3:44 PM

note: Will be revising the aproach here, still WIP

Revision Contents
Changeset List

PathSize
mobile/
android/
fenix/
app/
src/
androidTest/
java/
org/
mozilla/
fenix/
helpers/
28 lines
ui/
73 lines
robots/
7 lines
main/
java/
org/
mozilla/
fenix/
9 lines
onboarding/
2 lines
test/
java/
org/
mozilla/
fenix/
14 lines

Diff 1398387

View Options

mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/helpers/AppAndSystemHelper.kt

Loading...
View Options

mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/OnboardingTest.kt

Loading...
View Options

mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/onboarding/OnboardingFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/HomeActivityTest.kt

Loading...
Privacy · Cookies · Legal