[go: up one dir, main page]
Page MenuHomePhabricator
Differential D332929

WIP: Bug 2080895 - part 3 - Remove AppState.mode in favor of BrowsingMode
Changes PlannedPublicDraft
Actions

Authored by petru on Mon, Oct 12, 3:38 PM.
Tags
None
Referenced Files
F84403832: D332929.1792265261.diff
Fri, Oct 16, 7:27 PM
Unknown Object (File)
Tue, Oct 13, 5:49 PM
Unknown Object (File)
Tue, Oct 13, 4:28 PM
Unknown Object (File)
Tue, Oct 13, 11:43 AM
Subscribers
None

Details

Reviewers
None
Bugzilla Bug ID
2080895
Merge Conflict Status
Landing may fail: this does not merge cleanly into the target branch
Conflicts when merged against target branch tip 7cc7780f0729, starting from 79a90a9e0a86, with 2 parent revision(s) applied first.
Last checked Fri, Oct 16, 6:58 PM
Diff 1403323, based on 79a90a9e0a86
Summary

The BrowsingModeManager is now a singleton which allows observing updates from
anywhere inside the application
So there is no need to have the same data served from AppState.mode also.

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

petru planned changes to this revision.Mon, Oct 12, 3:38 PM
petru created this revision.
Herald added a project: secure-revision. · View Herald TranscriptMon, Oct 12, 3:39 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Mon, Oct 12, 3:39 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Revision Contents
Changeset List

PathSize
mobile/
android/
fenix/
app/
src/
main/
java/
org/
mozilla/
fenix/
4 lines
3 lines
addons/
2 lines
8 lines
4 lines
bookmarks/
10 lines
6 lines
browser/
27 lines
1 line
5 lines
tabstrip/
9 lines
components/
1 line
5 lines
6 lines
2 lines
appstate/
5 lines
3 lines
2 lines
lens/
5 lines
menu/
3 lines
1 line
6 lines
toolbar/
gestures/
5 lines
usecases/
10 lines
home/
24 lines
blocklist/
1 line
sessioncontrol/
8 lines
toolbar/
8 lines
2 lines
topsites/
1 line
controller/
6 lines
library/
history/
7 lines
historymetadata/
1 line
controller/
6 lines
recentlyclosed/
10 lines
10 lines
pbmlock/
23 lines
2 lines
search/
13 lines
2 lines
awesomebar/
2 lines
settings/
2 lines
2 lines
2 lines
2 lines
trustpanel/
2 lines
middleware/
8 lines
tabstray/
ui/
2 lines
webcompat/
8 lines
test/
java/
org/
mozilla/
fenix/
addons/
2 lines
browser/
10 lines
components/
10 lines
home/
2 lines
blocklist/
18 lines
library/
historymetadata/
controller/
6 lines
pbmlock/
30 lines
settings/
trustpanel/
4 lines

Diff 1403323

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/ExtensionsMenuItemProvider.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/InstalledAddonDetailsFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/BookmarkFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/bookmarks/EditBookmarkFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/TabPreview.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/tabstrip/TabStrip.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Components.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/HomepageThumbnailIntegration.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/LensFeature.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/UseCases.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/appstate/AppAction.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/appstate/AppState.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/appstate/AppStoreReducer.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/lens/LensImageSearch.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/MenuDialogFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/MenuFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/MenuItemProvidersFactory.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/gestures/ToolbarVerticalGesturesHandler.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/usecases/FenixBrowserUseCases.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/blocklist/BlocklistMiddleware.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/toolbar/BrowserSimpleToolbar.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/toolbar/HomeToolbarComposable.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/topsites/ShortcutsFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/topsites/controller/TopSiteController.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/historymetadata/HistoryMetadataGroupFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/historymetadata/controller/HistoryMetadataGroupController.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/recentlyclosed/RecentlyClosedController.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/recentlyclosed/RecentlyClosedFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/pbmlock/PrivateBrowsingLockFeature.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/pbmlock/UnlockPrivateTabsFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/BrowserStoreToFenixSearchMapperMiddleware.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/SearchFragmentStore.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarComposable.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/ToolbarSimpleNoShortcutPreference.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/ToolbarSimpleShortcutPreference.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/ToolbarTabStripNoShortcutPreference.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/ToolbarTabStripShortcutPreference.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/trustpanel/TrustPanelFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/trustpanel/middleware/TrustPanelNavigationMiddleware.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/ui/TabManagementFragment.kt

Loading...
View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/webcompat/ReportBrokenSiteMenuItemProvider.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/addons/InstalledAddonDetailsFragmentTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/browser/BaseBrowserFragmentTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/AppStoreTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/home/blocklist/BlocklistMiddlewareTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/library/historymetadata/controller/HistoryMetadataGroupControllerTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/pbmlock/PrivateBrowsingLockFeatureTest.kt

Loading...
View Options

mobile/android/fenix/app/src/test/java/org/mozilla/fenix/settings/trustpanel/TrustPanelNavigationMiddlewareTest.kt

Loading...
Privacy · Cookies · Legal