Differential D331716

Bug 2079419 - Pre: Inline `updateMicrosurveyPromptForConfigurationChange`. r?twhite
ClosedPublic
Actions

Authored by nalexander on Wed, Oct 7, 6:35 PM.

Details

Reviewers

twhite

Group Reviewers

android-reviewers

Commits

rFIREFOXAUTOLAND15c3e3fab7f5: Bug 2079419 - Pre: Inline `updateMicrosurveyPromptForConfigurationChange`.

Bugzilla Bug ID

2079419

Summary

No other fragment needs this, and there's no advantage to abstracting
over the "reinitialize microsurvey prompt" behaviour. Just do the
work when it's needed.

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

nalexander created this revision.Wed, Oct 7, 6:35 PM

Herald added a project: secure-revision. · View Herald TranscriptWed, Oct 7, 6:35 PM

nalexander added a child revision: D331717: Bug 2079419 - Pre: Lift some extension methods to apply only to `BaseBrowserFragment`. r?twhite.Wed, Oct 7, 6:35 PM

phab-bot published this revision for review.Wed, Oct 7, 6:40 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: android-reviewers. · View Herald TranscriptWed, Oct 7, 6:40 PM

Code analysis found 5 defects in diff 1398749:

5 defects found by android-fenix (Mozlint)

IMPORTANT: Found 5 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1398749.

Harbormaster failed remote builds in B1059265: Diff 1398749!Wed, Oct 7, 7:47 PM

nalexander updated this revision to Diff 1399137.Wed, Oct 7, 9:00 PM

Harbormaster completed remote builds in B1059570: Diff 1399137.Wed, Oct 7, 9:28 PM

lgtm 👌

This revision is now accepted and ready to land.Wed, Oct 14, 3:52 PM

Closed by commit rFIREFOXAUTOLAND15c3e3fab7f5: Bug 2079419 - Pre: Inline `updateMicrosurveyPromptForConfigurationChange`. (authored by nalexander). · Explain WhyThu, Oct 15, 11:58 PM

This revision was automatically updated to reflect the committed changes.

nalexander added a commit: rFIREFOXAUTOLAND15c3e3fab7f5: Bug 2079419 - Pre: Inline `updateMicrosurveyPromptForConfigurationChange`..

Revision Contents
Changeset List

Path

Size

mobile/

android/

fenix/

app/

src/

main/

java/

org/

mozilla/

fenix/

browser/

BaseBrowserFragment.kt

18 lines

ext/

Fragment.kt

28 lines

Diff 1408513

View Options

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt