[go: up one dir, main page]

Page MenuHomePhabricator

joschmidt (Johannes)
User

User Details

User Since
Mar 4 2023, 8:42 AM (188 w, 6 d)
Availability
Available
Review Queue
0

Recent Activity

Today

joschmidt accepted D334502: Bug 2082829 - Credit card Rust migration reports false divergences for cards whose number mask has no digits or whose expiry is stored as 0. r?joschmidt.
Fri, Oct 16, 12:03 PM · testing-approved

Yesterday

joschmidt updated the uplift request field for D334202: Bug 2080080 - Disable test_LoginStorageMigrator_nimbus.js for Thunderbird builds..
Thu, Oct 15, 4:03 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt created D334202: Bug 2080080 - Disable test_LoginStorageMigrator_nimbus.js for Thunderbird builds..
Thu, Oct 15, 4:03 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt created D334201: Bug 2079671 - Make `signon.storage.rust.enabled` controllable through Nimbus..
Thu, Oct 15, 4:03 PM · testing-approved
joschmidt updated the uplift request field for D334193: Bug 2079671 - Make `signon.storage.rust.enabled` controllable through Nimbus..
Thu, Oct 15, 3:44 PM · testing-approved
joschmidt created D334193: Bug 2079671 - Make `signon.storage.rust.enabled` controllable through Nimbus..
Thu, Oct 15, 3:44 PM · testing-approved
joschmidt accepted D332397: Bug 2080169 - Sync credit cards through the Rust store's bridged engine on Desktop r?joschmidt.

Skipping when PrP is locked feels right to me.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Thu, Oct 15, 11:24 AM · testing-approved
joschmidt accepted D329949: Bug 1876516 - Change ConsoleLogLevel and maxLogLevel strings from PascalCase to camelCase r?#firefox-desktop-core-reviewers,#dom-core,#devtools-reviewers.
Thu, Oct 15, 9:05 AM · testing-exception-unchanged (Doesn't change behavior for users)

Wed, Oct 14

joschmidt accepted D333699: Bug 2081788 - Treat a missing guid as no such record in the Rust autofill adapter. r?joschmidt.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Wed, Oct 14, 2:52 PM · testing-approved
joschmidt accepted D333596: Bug 2081667 - Stop running the address migration dry run in Nightly r=joschmidt,#credential-management-reviewers.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Wed, Oct 14, 2:34 PM · needs-testing-tag
joschmidt accepted D333618: Bug 2081661 - Run the credit card migration dry run in Nightly r?joschmidt.
Wed, Oct 14, 1:57 PM · Restricted Project, testing-approved
joschmidt accepted D333604: Bug 2080179 - P3. Only support credit card security codes while the Rust store is serving r?joschmidt.
Wed, Oct 14, 1:47 PM · testing-approved
joschmidt accepted D332402: Bug 2080179 - P1. Vendor application-services bf6e952d for credit card CVV storage r?joschmidt,Standard8,#firefox-source-docs-reviewers.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Wed, Oct 14, 12:56 PM · testing-approved
joschmidt accepted D332403: Bug 2080179 - P2. Store the credit card security code in the Rust store on Desktop r=joschmidt.
Wed, Oct 14, 8:28 AM · testing-approved

Tue, Oct 13

joschmidt closed D332847: Bug 2080808 - Vendor application-services f22774fb to move create_static_key_manager and create_managed_encdec to db-crypto. r?#credential-management-reviewers.
Tue, Oct 13, 9:04 PM · testing-approved
joschmidt committed rFIREFOXAUTOLANDedf96b1ed8ac: Bug 2080808 - Vendor application-services f22774fb to move… (authored by joschmidt).
Bug 2080808 - Vendor application-services f22774fb to move…
Tue, Oct 13, 9:03 PM
joschmidt added inline comments to D332403: Bug 2080179 - P2. Store the credit card security code in the Rust store on Desktop r=joschmidt.
Tue, Oct 13, 6:56 PM · testing-approved

Mon, Oct 12

joschmidt accepted D326175: Bug 2072029 - P3. Support the credit card migration dry run r?joschmidt.
Mon, Oct 12, 4:00 PM · data-classification-unnecessary, testing-approved
joschmidt accepted D329697: Bug 2072029 - P2. Announce when the OS key store is unlocked r=joschmidt.
Mon, Oct 12, 3:55 PM · testing-approved
joschmidt accepted D329928: Bug 2072029 - P1. Run the address and credit card migrations through one function r?joschmidt.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Mon, Oct 12, 3:54 PM · needs-testing-tag
joschmidt accepted D326174: Bug 2071908 - Add test coverage for the creditCards.storage.rust.enabled pref r?joschmidt.
Mon, Oct 12, 3:51 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt added a comment to D332314: Bug 2080080 - Disable test_LoginStorageMigrator_nimbus.js for Thunderbird builds. r=joschmidt,dimi.

Thank you!

Mon, Oct 12, 1:06 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt accepted D325418: Bug 2080074 - Prompt for the primary password when the store's key needs it r?joschmidt.
Mon, Oct 12, 12:56 PM · testing-approved
joschmidt updated the diff for D332847: Bug 2080808 - Vendor application-services f22774fb to move create_static_key_manager and create_managed_encdec to db-crypto. r?#credential-management-reviewers.
Mon, Oct 12, 12:41 PM · testing-approved
joschmidt updated the test plan for D332847: Bug 2080808 - Vendor application-services f22774fb to move create_static_key_manager and create_managed_encdec to db-crypto. r?#credential-management-reviewers.
Mon, Oct 12, 11:41 AM · testing-approved
joschmidt created D332847: Bug 2080808 - Vendor application-services f22774fb to move create_static_key_manager and create_managed_encdec to db-crypto. r?#credential-management-reviewers.
Mon, Oct 12, 11:39 AM · testing-approved

Thu, Oct 8

joschmidt committed rFIREFOXBETA0f51239e5f43: Bug 2069438 - Count Rust storage logins without decrypting them. r=dimi (authored by joschmidt).
Bug 2069438 - Count Rust storage logins without decrypting them. r=dimi
Thu, Oct 8, 2:57 PM
joschmidt committed rFIREFOXBETA0bb20adddaaf: Bug 2069438 - Pre-filter Rust storage searches by origin. r=dimi (authored by joschmidt).
Bug 2069438 - Pre-filter Rust storage searches by origin. r=dimi
Thu, Oct 8, 2:57 PM
joschmidt committed rFIREFOXBETAc1b673ddee61: Bug 2069438 - Vendor application-services 7585e03e for LoginStore… (authored by joschmidt).
Bug 2069438 - Vendor application-services 7585e03e for LoginStore…
Thu, Oct 8, 2:57 PM
joschmidt committed rFIREFOXBETAde639f400909: Bug 2069438 - Look up logins by guid directly in the Rust storage search. (authored by joschmidt).
Bug 2069438 - Look up logins by guid directly in the Rust storage search.
Thu, Oct 8, 2:57 PM
joschmidt closed D331959: Bug 2079671 - Make `signon.storage.rust.enabled` controllable through Nimbus. r=dimi.
Thu, Oct 8, 2:03 PM · testing-approved
joschmidt committed rFIREFOXAUTOLANDe5da1d6427ae: Bug 2079671 - Make `signon.storage.rust.enabled` controllable through Nimbus. (authored by joschmidt).
Bug 2079671 - Make `signon.storage.rust.enabled` controllable through Nimbus.
Thu, Oct 8, 2:03 PM
joschmidt updated the test plan for D331959: Bug 2079671 - Make `signon.storage.rust.enabled` controllable through Nimbus. r=dimi.
Thu, Oct 8, 12:50 PM · testing-approved
joschmidt created D331959: Bug 2079671 - Make `signon.storage.rust.enabled` controllable through Nimbus. r=dimi.
Thu, Oct 8, 10:45 AM · testing-approved

Wed, Oct 7

joschmidt committed rFIREFOXRELEASEa3d5e5e30096: Bug 2072278 - Count the logins the restore would have to delete. r=credential… (authored by joschmidt).
Bug 2072278 - Count the logins the restore would have to delete. r=credential…
Wed, Oct 7, 11:25 PM
joschmidt committed rFIREFOXRELEASEbbbca388884d: Bug 2070874 - Ignore the Rust store's locked primary password error in the… (authored by joschmidt).
Bug 2070874 - Ignore the Rust store's locked primary password error in the…
Wed, Oct 7, 8:49 PM
joschmidt committed rFIREFOXRELEASE06cce60e0bb0: Bug 2070129 - Reject instead of hanging when the Rust login store fails to… (authored by joschmidt).
Bug 2070129 - Reject instead of hanging when the Rust login store fails to…
Wed, Oct 7, 8:25 PM
joschmidt committed rFIREFOXRELEASE76334a3ebd90: Bug 2070108 - Do not record a re-authentication event that does not exist… (authored by joschmidt).
Bug 2070108 - Do not record a re-authentication event that does not exist…
Wed, Oct 7, 8:11 PM
joschmidt committed rFIREFOXRELEASEb8c8ba90e9c3: Bug 2070108 - Record every Primary Password prompt with its result r=credential… (authored by joschmidt).
Bug 2070108 - Record every Primary Password prompt with its result r=credential…
Wed, Oct 7, 8:11 PM
joschmidt requested changes to D325418: Bug 2080074 - Prompt for the primary password when the store's key needs it r?joschmidt.

Let's be cautious with the scrubbing of undecryptable cc's. For Logins we do not do something like this.

Wed, Oct 7, 2:59 PM · testing-approved
joschmidt accepted D331484: Bug 2071247 - P1. Vendor the autofill EncryptorDecryptor from application-services r=joschmidt.
Wed, Oct 7, 7:44 AM · testing-approved

Tue, Oct 6

joschmidt accepted D325373: Bug 2071247 - P3. Read credit card numbers through the store that holds them r?joschmidt.
Tue, Oct 6, 11:57 AM · testing-approved
joschmidt added inline comments to D325373: Bug 2071247 - P3. Read credit card numbers through the store that holds them r?joschmidt.
Tue, Oct 6, 11:06 AM · testing-approved

Mon, Oct 5

joschmidt added inline comments to D328802: Bug 2074881 - Handle A-S autofill moving credit card encryption from app level to A-S level. r=#android-reviewers.
Mon, Oct 5, 9:23 AM · testing-approved
joschmidt accepted D325372: Bug 2071247 - P2. Hand credit card numbers to the store that encrypts them r?joschmidt.
Mon, Oct 5, 8:32 AM · testing-approved

Wed, Sep 30

joschmidt closed D328792: Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers.
Wed, Sep 30, 7:31 PM · testing-approved
joschmidt closed D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Wed, Sep 30, 7:31 PM · testing-approved
joschmidt closed D328791: Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers.
Wed, Sep 30, 7:31 PM · testing-approved
joschmidt committed rFIREFOXAUTOLAND0f51239e5f43: Bug 2069438 - Count Rust storage logins without decrypting them. r=dimi (authored by joschmidt).
Bug 2069438 - Count Rust storage logins without decrypting them. r=dimi
Wed, Sep 30, 7:31 PM
joschmidt closed D328785: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers.
Wed, Sep 30, 7:31 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt committed rFIREFOXAUTOLAND0bb20adddaaf: Bug 2069438 - Pre-filter Rust storage searches by origin. r=dimi (authored by joschmidt).
Bug 2069438 - Pre-filter Rust storage searches by origin. r=dimi
Wed, Sep 30, 7:31 PM
joschmidt committed rFIREFOXAUTOLANDc1b673ddee61: Bug 2069438 - Vendor application-services 7585e03e for LoginStore… (authored by joschmidt).
Bug 2069438 - Vendor application-services 7585e03e for LoginStore…
Wed, Sep 30, 7:31 PM
joschmidt committed rFIREFOXAUTOLANDde639f400909: Bug 2069438 - Look up logins by guid directly in the Rust storage search. (authored by joschmidt).
Bug 2069438 - Look up logins by guid directly in the Rust storage search.
Wed, Sep 30, 7:31 PM
joschmidt updated the diff for D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Wed, Sep 30, 5:36 PM · testing-approved
joschmidt updated the diff for D328792: Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers.
Wed, Sep 30, 5:36 PM · testing-approved
joschmidt updated the diff for D328785: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers.
Wed, Sep 30, 5:36 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt updated the diff for D328791: Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers.
Wed, Sep 30, 5:36 PM · testing-approved
joschmidt accepted D327480: Bug 2073674 - Use moz-src for browser/components/migration.
Wed, Sep 30, 3:32 AM · testing-approved

Fri, Sep 25

joschmidt requested review of D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Fri, Sep 25, 2:30 PM · testing-approved
joschmidt retitled D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers from WIP: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers to Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Fri, Sep 25, 2:30 PM · testing-approved
joschmidt requested review of D328792: Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers.
Fri, Sep 25, 2:30 PM · testing-approved
joschmidt retitled D328792: Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers from WIP: Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers to Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers.
Fri, Sep 25, 2:30 PM · testing-approved
joschmidt requested review of D328791: Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers.
Fri, Sep 25, 2:29 PM · testing-approved
joschmidt retitled D328791: Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers from WIP: Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers to Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers.
Fri, Sep 25, 2:29 PM · testing-approved
joschmidt added a reviewer for D328785: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers: dimi.
Fri, Sep 25, 2:27 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt retitled D328785: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers from WIP: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers to Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers.
Fri, Sep 25, 2:27 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt requested review of D328785: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers.
Fri, Sep 25, 2:27 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt planned changes to D328785: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers.
Fri, Sep 25, 2:21 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt updated the diff for D328785: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers.
Fri, Sep 25, 2:21 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt updated the diff for D328791: Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers.
Fri, Sep 25, 2:21 PM · testing-approved
joschmidt updated the diff for D328792: Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers.
Fri, Sep 25, 2:21 PM · testing-approved
joschmidt planned changes to D328792: Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers.
Fri, Sep 25, 2:21 PM · testing-approved
joschmidt planned changes to D328791: Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers.
Fri, Sep 25, 2:21 PM · testing-approved
joschmidt updated the diff for D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Fri, Sep 25, 2:21 PM · testing-approved
joschmidt planned changes to D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Fri, Sep 25, 2:21 PM · testing-approved
joschmidt updated the test plan for D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Fri, Sep 25, 2:17 PM · testing-approved
joschmidt requested review of D329204: Bug 2069438 - Add a cargo-vet policy for the git-fetched nss-rs. r?#supply-chain-reviewers.
Fri, Sep 25, 2:08 PM · testing-approved
joschmidt updated the diff for D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Fri, Sep 25, 1:57 PM · testing-approved
joschmidt planned changes to D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Fri, Sep 25, 1:57 PM · testing-approved
joschmidt planned changes to D328792: Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers.
Fri, Sep 25, 1:57 PM · testing-approved
joschmidt updated the diff for D328792: Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers.
Fri, Sep 25, 1:57 PM · testing-approved
joschmidt planned changes to D328791: Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers.
Fri, Sep 25, 1:57 PM · testing-approved
joschmidt updated the diff for D328791: Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers.
Fri, Sep 25, 1:57 PM · testing-approved
joschmidt planned changes to D328785: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers.
Fri, Sep 25, 1:57 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt updated the diff for D328785: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers.
Fri, Sep 25, 1:57 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt planned changes to D329204: Bug 2069438 - Add a cargo-vet policy for the git-fetched nss-rs. r?#supply-chain-reviewers.
Fri, Sep 25, 1:57 PM · testing-approved
joschmidt planned changes to D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Fri, Sep 25, 1:31 PM · testing-approved
joschmidt updated the diff for D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Fri, Sep 25, 1:31 PM · testing-approved
joschmidt planned changes to D328792: Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers.
Fri, Sep 25, 1:31 PM · testing-approved
joschmidt updated the diff for D328792: Bug 2069438 - Pre-filter Rust storage searches by origin. r?#credential-management-reviewers.
Fri, Sep 25, 1:31 PM · testing-approved
joschmidt planned changes to D328791: Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers.
Fri, Sep 25, 1:31 PM · testing-approved
joschmidt updated the diff for D328791: Bug 2069438 - Vendor application-services 7585e03e for LoginStore::list_candidates_by_origin(). r?#credential-management-reviewers.
Fri, Sep 25, 1:31 PM · testing-approved
joschmidt planned changes to D328785: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers.
Fri, Sep 25, 1:31 PM · testing-exception-unchanged (Doesn't change behavior for users)
joschmidt updated the diff for D328785: Bug 2069438 - Look up logins by guid directly in the Rust storage search. r?#credential-management-reviewers.
Fri, Sep 25, 1:31 PM · testing-exception-unchanged (Doesn't change behavior for users)

Thu, Sep 24

joschmidt committed rFIREFOXBETAa3d5e5e30096: Bug 2072278 - Count the logins the restore would have to delete. r=credential… (authored by joschmidt).
Bug 2072278 - Count the logins the restore would have to delete. r=credential…
Thu, Sep 24, 3:53 PM
joschmidt committed rFIREFOXBETAbbbca388884d: Bug 2070874 - Ignore the Rust store's locked primary password error in the… (authored by joschmidt).
Bug 2070874 - Ignore the Rust store's locked primary password error in the…
Thu, Sep 24, 3:17 PM
joschmidt committed rFIREFOXBETA06cce60e0bb0: Bug 2070129 - Reject instead of hanging when the Rust login store fails to… (authored by joschmidt).
Bug 2070129 - Reject instead of hanging when the Rust login store fails to…
Thu, Sep 24, 3:02 PM
joschmidt committed rFIREFOXBETAb8c8ba90e9c3: Bug 2070108 - Record every Primary Password prompt with its result r=credential… (authored by joschmidt).
Bug 2070108 - Record every Primary Password prompt with its result r=credential…
Thu, Sep 24, 2:41 PM
joschmidt committed rFIREFOXBETA76334a3ebd90: Bug 2070108 - Do not record a re-authentication event that does not exist… (authored by joschmidt).
Bug 2070108 - Do not record a re-authentication event that does not exist…
Thu, Sep 24, 2:41 PM
joschmidt updated the test plan for D328794: Bug 2069438 - Count Rust storage logins without decrypting them. r?#credential-management-reviewers.
Thu, Sep 24, 9:45 AM · testing-approved