[go: up one dir, main page]

Page MenuHomePhabricator

Bug 2081661 - Run the credit card migration dry run in Nightly r?joschmidt
ClosedPublic

Authored by dimi on Wed, Oct 14, 12:08 PM.

Details

Summary

Copy the profile's credit cards into the Rust store, verify them, report the
result through migrate_to_rust, and wipe the copy again. Nothing reads from
Rust: creditCards.storage.rust.enabled stays off. Once per profile per
generation, recorded on migrationTestVersion.

The copy is skipped when a primary password is set, and deferred while the OS
key store is locked or busy, so that it never asks the user anything. Record
migrate_to_rust_blocked with the reason each time, so that a profile held back
can be told apart from one with nothing to migrate.

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: MattN. · View Herald Transcript

This revision changes how Firefox collects data, so it needs a #data-classification tag.

If you (the patch author) are adding new or modifying existing data collection, you and your reviewer(s) should judge how sensitive this data is, using the data collection categories Mozilla uses. If the data you are collecting fits in either the Category 1 “technical data” or Category 2 “interaction data” described there, please add the #data-classification-low tag. If it’s any other category, or you and your reviewer(s) disagree, please add the #data-classification-high tag, and go through the sensitive data collection review process. If you think that the data in question fits in “technical” or “interaction” data but would benefit from additional review, you can also explicitly choose to use the #data-classification-high tag and thereby opt in to the sensitive data collection review process.

When using Glean for the data collection, the data classification of the new or expanded data collections should match the data_sensitivity property in the metric definitions.

If you are removing data collection, or are making mechanical changes to these files that do not add or modify what data is collected, change when or how it is collected, please add the data-classification-unnecessary tag.

If you are unsure or feel uncomfortable making this assessment yourself, please ask the data-stewards group for help.

Whichever tag is used, please leave a comment explaining this choice. Note that Lando will not be able to land this revision until the revision has one of these tags and you remove the #needs-data-classification tag.

Finally, you as a patch author are encouraged to add the right tags yourself, but your reviewers are responsible for making sure the right tag is used.

This revision is now accepted and ready to land.Wed, Oct 14, 1:57 PM
dimi edited projects, added Restricted Project; removed Restricted Project.Wed, Oct 14, 2:32 PM