[go: up one dir, main page]
Page MenuHomePhabricator
Differential D332402

Bug 2080179 - P1. Vendor application-services bf6e952d for credit card CVV storage r?joschmidt,Standard8,#firefox-source-docs-reviewers
ClosedPublic
Actions

Authored by dimi on Fri, Oct 9, 1:01 PM.
Tags
Referenced Files
F84494568: D332402/new/.1792380082.diff
Sun, Oct 18, 3:21 AM
F84482407: D332402.1792366134.diff
Sat, Oct 17, 11:28 PM
F84460612: D332402/new/.1792340442.diff
Sat, Oct 17, 4:20 PM
Unknown Object (File)
Sat, Oct 17, 1:49 AM
Unknown Object (File)
Fri, Oct 16, 7:27 PM
Unknown Object (File)
Thu, Oct 15, 3:59 PM
Subscribers
andreio
reviewbot

Details

Reviewers
joschmidt
• Standard8
Commits
rFIREFOXAUTOLAND897e3c368783: Bug 2080179 - P1. Vendor application-services bf6e952d for credit card CVV…
rFIREFOXAUTOLAND2c4c70cd841c: Bug 2080179 - P1. Vendor application-services bf6e952d for credit card CVV…
Bugzilla Bug ID
2080179
Summary

Vendor application-services bf6e952d3, which merges pull requests #7631 and
#7648. #7631 (bug 2076154) keeps an optional CVV in the credit card store,
encrypted like the number: UpdatableCreditCardFields.cc_cvv in, CreditCard.cc_cvv
out, and a schema upgrade adding the column. #7648 (bug 2074008) exposes
Store.credit_cards_bridged_engine(), which nothing uses yet;
CreditCardsBridgedEngine is declared AsyncWrapped beside AddressesBridgedEngine.

The revision also carries the upstream changes since f22774fb: search-config-v3
work on the search engine selector (bugs 2063260, 2063272, 2061724 and 2050097),
and the Glean error ping on iOS (bug 2011695), after which error-support builds
Glean bindings with glean-build from glean v70.2.0, so its git source moves to
that tag.

The new search-config-v3 enums in RustSearch.sys.mjs reuse variant names of the
existing ones, which collides in the source docs build (bug 2082313). Until that
is fixed, jsdoc skips RustSearch.sys.mjs and the search API page's missing
objects are allowed, so the page renders empty.

This also includes the file changes from ./mach uniffi generate.

Diff Detail

Event Timeline

dimi planned changes to this revision.Fri, Oct 9, 1:01 PM
dimi created this revision.
Herald added a project: secure-revision. · View Herald TranscriptFri, Oct 9, 1:01 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Fri, Oct 9, 1:01 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
dimi added a child revision: D332403: Bug 2080179 - P2. Store the credit card security code in the Rust store on Desktop r=joschmidt.Fri, Oct 9, 1:01 PM
Harbormaster failed remote builds in B1061364: Diff 1401644!Fri, Oct 9, 1:02 PM
dimi requested review of this revision.Wed, Oct 14, 12:39 PM
dimi updated this revision to Diff 1405889.
dimi retitled this revision from WIP: Bug 2080179 - P1. Vendor credit card CVV storage from application-services DO NOT MERGE to Bug 2080179 - P1. Vendor application-services bf6e952d for credit card CVV storage r?joschmidt.
dimi edited the summary of this revision. (Show Details)
dimi added a reviewer: joschmidt.
Herald added a subscriber: andreio. · View Herald TranscriptWed, Oct 14, 12:39 PM
joschmidt accepted this revision.Wed, Oct 14, 12:56 PM
This revision is now accepted and ready to land.Wed, Oct 14, 12:56 PM
Herald added a project: needs-testing-tag. · View Herald TranscriptWed, Oct 14, 12:56 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

reviewbot edited projects, added testing-approved; removed needs-testing-tag.Wed, Oct 14, 1:01 PM
reviewbot added a subscriber: reviewbot.

Code analysis found 1 defect in diff 1405889:

  • 1 defect found by cargo-audit (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

The analysis task source-test-doc-upload failed, but we could not detect any defect.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1405889.

Harbormaster failed remote builds in B1064247: Diff 1405889!Wed, Oct 14, 1:02 PM
This revision was landed with ongoing or failed builds.Wed, Oct 14, 1:56 PM
Closed by commit rFIREFOXAUTOLAND2c4c70cd841c: Bug 2080179 - P1. Vendor application-services bf6e952d for credit card CVV… (authored by dimi). · Explain Why
This revision was automatically updated to reflect the committed changes.
dimi added a commit: rFIREFOXAUTOLAND2c4c70cd841c: Bug 2080179 - P1. Vendor application-services bf6e952d for credit card CVV….
smolnar reopened this revision.Wed, Oct 14, 2:18 PM
This revision is now accepted and ready to land.Wed, Oct 14, 2:18 PM
smolnar added a reverting change: rFIREFOXAUTOLAND91e559a5ac31: Revert "Bug 2080179 - P3. Only support credit card security codes while the….Wed, Oct 14, 2:18 PM
dimi updated this revision to Diff 1407237.Thu, Oct 15, 8:26 AM
dimi retitled this revision from Bug 2080179 - P1. Vendor application-services bf6e952d for credit card CVV storage r?joschmidt to Bug 2080179 - P1. Vendor application-services bf6e952d for credit card CVV storage r?joschmidt,Standard8,#firefox-source-docs-reviewers.
dimi edited the summary of this revision. (Show Details)
dimi added reviewers: • Standard8, Restricted Project.Thu, Oct 15, 8:27 AM
• Standard8 accepted this revision.Thu, Oct 15, 8:49 AM

These changes do make the documentation tests pass. As mentioned on Slack, I have a patch in progress to fix these (D333898), but I would also like to land the merge sooner as that helps with unblocking my other work. So let's go ahead and land this & then I'll rebase that patch on this and undo the exclusions.

reviewbot added a comment.Thu, Oct 15, 8:51 AM

Code analysis found 1 defect in diff 1407237:

  • 1 defect found by cargo-audit (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing
NOTE: 2 documentation files were modified in diff 1407237

They can be previewed for one week:

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1407237.

Harbormaster completed remote builds in B1065179: Diff 1407237.Thu, Oct 15, 8:51 AM
dimi removed a reviewer: Restricted Project.Thu, Oct 15, 8:52 AM
• Standard8 mentioned this in D333722: Bug 2081806 - Vendor application-services ec31dc5b. r?bdk!.Thu, Oct 15, 8:55 AM
Closed by commit rFIREFOXAUTOLAND897e3c368783: Bug 2080179 - P1. Vendor application-services bf6e952d for credit card CVV… (authored by dimi). · Explain WhyThu, Oct 15, 8:58 AM
This revision was automatically updated to reflect the committed changes.
dimi added a commit: rFIREFOXAUTOLAND897e3c368783: Bug 2080179 - P1. Vendor application-services bf6e952d for credit card CVV….
• Standard8 added a child revision: D333898: Bug 2082341 - Fix uniffi enumeration output to specify the symbol the members belong to. r?bdk!.Thu, Oct 15, 1:13 PM

Revision Contents
Changeset List

PathSize
.cargo/
4 lines
docs/
4 lines
3 lines
rust-components/
api/
js/
5 lines
35 lines
third_party/
application-services/
components/
autofill/
sql/
3 lines
src/
52 lines
db/
22 lines
models/
28 lines
17 lines
72 lines
2 lines
sync/
160 lines
credit_card/
1 line
19 lines
2 lines
places/
2 lines
search/
src/
187 lines
1087 lines
4 lines
870 lines
1387 lines
34 lines
599 lines
260 lines
support/
error/
9 lines
18 lines
src/
21 lines
5 lines
examples/
autofill-utils/
src/
2 lines
megazords/
ios-rust/
2 lines
4 lines
testing/
sync-test/
src/
5 lines
toolkit/
components/
uniffi-bindgen-gecko-js/
android/
components/
autofill/
android/
src/
main/
java/
mozilla/
appservices/
autofill/
524 lines
search/
android/
src/
main/
java/
mozilla/
appservices/
search/
842 lines
components/
generated/
592 lines
16 lines
12 lines
44 lines
8 lines
44 lines
108 lines
24 lines
34 lines
1599 lines
58 lines
64 lines
6 lines
52 lines
1 line
tests/
generated/
196 lines
2 lines
8 lines
uniffi-js/
3012 lines

Diff 1407269

View Options

.cargo/config.toml.in

Loading...
View Options

Cargo.lock

Loading...
View Options

docs/config.yml

Loading...
View Options

docs/jsdoc.json

Loading...
View Options

docs/rust-components/api/js/autofill.md

Loading...
View Options

docs/rust-components/api/js/search.md

Loading...
View Options

third_party/application-services/components/autofill/sql/create_shared_schema.sql

Loading...
View Options

third_party/application-services/components/autofill/src/autofill.udl

Loading...
View Options

third_party/application-services/components/autofill/src/db/credit_cards.rs

Loading...
View Options

third_party/application-services/components/autofill/src/db/models/credit_card.rs

Loading...
View Options

third_party/application-services/components/autofill/src/db/schema.rs

Loading...
View Options

third_party/application-services/components/autofill/src/db/store.rs

Loading...
View Options

third_party/application-services/components/autofill/src/lib.rs

Loading...
View Options

third_party/application-services/components/autofill/src/sync/bridge.rs

Loading...
View Options

third_party/application-services/components/autofill/src/sync/credit_card/incoming.rs

Loading...
View Options

third_party/application-services/components/autofill/src/sync/credit_card/mod.rs

Loading...
View Options

third_party/application-services/components/autofill/src/sync/mod.rs

Loading...
View Options

third_party/application-services/components/places/Cargo.toml

Loading...
View Options

third_party/application-services/components/search/src/configuration_types.rs

Loading...
View Options

third_party/application-services/components/search/src/environment_matching.rs

Loading...
View Options

third_party/application-services/components/search/src/error.rs

Loading...
View Options

third_party/application-services/components/search/src/filter.rs

Loading...
View Options

third_party/application-services/components/search/src/selector.rs

Loading...
View Options

third_party/application-services/components/search/src/sort_helpers.rs

Loading...
View Options

third_party/application-services/components/search/src/test_helpers.rs

Loading...
View Options

third_party/application-services/components/search/src/types.rs

Loading...
View Options

third_party/application-services/components/support/error/Cargo.toml

Loading...
View Options

third_party/application-services/components/support/error/build.rs

Loading...
View Options

third_party/application-services/components/support/error/src/error_tracing.rs

Loading...
View Options

third_party/application-services/components/support/error/src/lib.rs

Loading...
View Options

third_party/application-services/examples/autofill-utils/src/autofill-utils.rs

Loading...
View Options

third_party/application-services/megazords/ios-rust/Cargo.toml

Loading...
View Options

third_party/application-services/moz.yaml

Loading...
View Options

third_party/application-services/testing/sync-test/src/autofill.rs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/android/components/autofill/android/src/main/java/mozilla/appservices/autofill/autofill.kt

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/android/components/search/android/src/main/java/mozilla/appservices/search/search.kt

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustAutofill.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustBreachAlerts.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustContextId.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustDbCrypto.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustFilterAdult.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustFxcontainers.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustLogins.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustRelevancy.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustRemoteSettings.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustSearch.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustSuggest.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustTabs.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustViaduct.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/components/generated/RustWebextstorage.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/config.toml

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/tests/generated/RustUniffiBindingsTests.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/tests/generated/RustUniffiBindingsTestsCollision.sys.mjs

Loading...
View Options

toolkit/components/uniffi-bindgen-gecko-js/tests/generated/RustUniffiBindingsTestsExternalTypes.sys.mjs

Loading...
View Options

toolkit/components/uniffi-js/GeneratedScaffolding.cpp

Loading...
Privacy · Cookies · Legal