[go: up one dir, main page]

Page MenuHomePhabricator

Bug 2077172 - Remove the media transport IPC and the socket process bridge. r=#webrtc-reviewers,#necko-reviewers
AcceptedPublic

Authored by leggert on Tue, Oct 13, 2:24 PM.

Details

Reviewers
bwc
valentin
Group Reviewers
webrtc-reviewers
necko-reviewers
ipc-reviewers
Bugzilla Bug ID
2077172
Merge Conflict Status
Landing merges cleanly into the target branch
Merges cleanly when merged against target branch tip 72fa9c388cbb, starting from e08a96ae6182, with 23 parent revision(s) applied first.
Last checked Fri, Oct 16, 7:44 PM
Diff 1408971, based on e08a96ae6182

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
reviewbot added a subscriber: reviewbot.
NOTE: A documentation file was modified in diff 1404447

It can be previewed for one week:


If you see a problem in this automated review, please report it here.

bwc requested changes to this revision.Tue, Oct 13, 5:57 PM
bwc added a subscriber: bwc.
bwc added inline comments.
dom/media/webrtc/MediaTransportTypes.h
5 ↗(On Diff #1404447)

Can we put this in dom/media/webrtc/transport?

dom/media/webrtc/jsapi/RTCRtpSender.cpp
61

What's this for?

This revision now requires changes to proceed.Tue, Oct 13, 5:57 PM
leggert added inline comments.
dom/media/webrtc/MediaTransportTypes.h
5 ↗(On Diff #1404447)

ACK

dom/media/webrtc/jsapi/RTCRtpSender.cpp
61

aFmtp.Split() returns nsTSubstringSplitter, which is defined in nsCharSeparatedTokenizer.h; it used to arrive indirectly via PMediaTransportChild.h, and non-unified builds fail without it.

leggert updated this revision to Diff 1405784.
leggert marked 2 inline comments as done.
NOTE: A documentation file was modified in diff 1405784

It can be previewed for one week:


If you see a problem in this automated review, please report it here.

valentin added a subscriber: valentin.

r+ for netwerk/

This revision is now accepted and ready to land.Wed, Oct 14, 5:54 PM
NOTE: A documentation file was modified in diff 1407200

It can be previewed for one week:


If you see a problem in this automated review, please report it here.

NOTE: A documentation file was modified in diff 1408971

It can be previewed for one week:


If you see a problem in this automated review, please report it here.