[go: up one dir, main page]
Page MenuHomePhabricator
Differential D333262

Bug 2077172 - Remove the socketprocess test variant and the socketprocess_e10s manifest token. r=#taskgraph-reviewers
AcceptedPublic
Actions

Authored by leggert on Tue, Oct 13, 2:24 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Oct 14, 9:35 AM
Unknown Object (File)
Wed, Oct 14, 9:33 AM
Unknown Object (File)
Wed, Oct 14, 9:19 AM
Unknown Object (File)
Wed, Oct 14, 8:53 AM
Unknown Object (File)
Wed, Oct 14, 8:44 AM
Unknown Object (File)
Wed, Oct 14, 3:49 AM
Subscribers
ahal
bwc
reviewbot

Details

Reviewers
ahal
Group Reviewers
taskgraph-reviewers
Bugzilla Bug ID
2077172
Merge Conflict Status
Landing merges cleanly into the target branch
Merges cleanly when merged against target branch tip 82e458a378ee, starting from e08a96ae6182, with 24 parent revision(s) applied first.
Last checked Sat, Oct 17, 6:11 PM
Diff 1408972, based on e08a96ae6182

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

leggert created this revision.Tue, Oct 13, 2:24 PM
Herald added a project: secure-revision. · View Herald TranscriptTue, Oct 13, 2:24 PM
leggert added a child revision: D333263: Bug 2077172 - Stop launching the socket process and remove its code. r=#necko-reviewers,keeler,#sandbox-reviewers,#toolkit-telemetry-reviewers-rotation.Tue, Oct 13, 2:24 PM
phab-bot published this revision for review.Tue, Oct 13, 2:28 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added 1 blocking reviewer(s): taskgraph-reviewers. · View Herald TranscriptTue, Oct 13, 2:28 PM
leggert updated this revision to Diff 1404443.Tue, Oct 13, 2:47 PM
Harbormaster failed remote builds in B1063229: Diff 1404400!Tue, Oct 13, 2:53 PM
reviewbot added a project: testing-approved.Tue, Oct 13, 3:14 PM
reviewbot added a subscriber: reviewbot.
NOTE: A documentation file was modified in diff 1404443

It can be previewed for one week:

NOTE: Tasks were added or removed in diff 1404443.

The following parameter sets have differences:

If you see a problem in this automated review, please report it here.

Harbormaster completed remote builds in B1063268: Diff 1404443.Tue, Oct 13, 3:14 PM
bwc added a subscriber: bwc.Tue, Oct 13, 5:29 PM
bwc added inline comments.
taskcluster/gecko_taskgraph/test/test_transforms_job.py
84–93

So we're replacing the spi variants with some unrelated variant? Is that the intent here? Or is this related somehow?

bwc mentioned this in D333260: Bug 2077172 - Always run WebRTC media transport in the content process. r=#webrtc-reviewers,#sandbox-reviewers.Tue, Oct 13, 6:00 PM
leggert marked an inline comment as done.Wed, Oct 14, 7:04 AM
leggert added inline comments.
taskcluster/gecko_taskgraph/test/test_transforms_job.py
84–93

test_group_name checks that group_name_variant turns a variant suffix into a group description, and it needs a variant that exists in variants.yml. With socketprocess gone, xorigin (suffix xorig, "{description} with cross-origin") seemed best to me? Happy to change it to something else.

leggert updated this revision to Diff 1405782.Wed, Oct 14, 10:35 AM
leggert marked an inline comment as done.
reviewbot added a comment.Wed, Oct 14, 11:09 AM
NOTE: Tasks were added or removed in diff 1405782.

The following parameter sets have differences:

NOTE: A documentation file was modified in diff 1405782

It can be previewed for one week:

If you see a problem in this automated review, please report it here.

Harbormaster completed remote builds in B1064180: Diff 1405782.Wed, Oct 14, 11:09 AM
leggert updated this revision to Diff 1407199.Thu, Oct 15, 7:34 AM
reviewbot added a comment.Thu, Oct 15, 8:23 AM
NOTE: A documentation file was modified in diff 1407199

It can be previewed for one week:

NOTE: Tasks were added or removed in diff 1407199.

The following parameter sets have differences:

If you see a problem in this automated review, please report it here.

Harbormaster completed remote builds in B1065149: Diff 1407199.Thu, Oct 15, 8:23 AM
ahal accepted this revision.Thu, Oct 15, 9:24 PM
ahal added a subscriber: ahal.

Thanks!

This revision is now accepted and ready to land.Thu, Oct 15, 9:24 PM
ahal requested changes to this revision.Thu, Oct 15, 9:28 PM
ahal added inline comments.
testing/mozbase/manifestparser/manifestparser/token.py
219

Actually there's one instance of this in test manifests:
https://searchfox.org/firefox-main/source/dom/media/webrtc/tests/mochitests/mochitest_peerconnection.toml#451

Is that being removed in a different commit? If it isn't removed I believe it'll cause a failure in the test task

This revision now requires changes to proceed.Thu, Oct 15, 9:28 PM
leggert marked an inline comment as done.Fri, Oct 16, 6:45 AM
leggert added inline comments.
testing/mozbase/manifestparser/manifestparser/token.py
219

Yes, D333260 removes it.

leggert marked an inline comment as done.Fri, Oct 16, 6:45 AM
leggert requested review of this revision.Fri, Oct 16, 7:57 AM
leggert updated this revision to Diff 1408972.
reviewbot added a comment.Fri, Oct 16, 8:33 AM
NOTE: Tasks were added or removed in diff 1408972.

The following parameter sets have differences:

NOTE: A documentation file was modified in diff 1408972

It can be previewed for one week:

If you see a problem in this automated review, please report it here.

Harbormaster completed remote builds in B1066361: Diff 1408972.Fri, Oct 16, 8:34 AM
ahal accepted this revision.Fri, Oct 16, 6:58 PM
This revision is now accepted and ready to land.Fri, Oct 16, 6:58 PM

Revision Contents
Changeset List

PathSize
docs/
code-quality/
lint/
linters/
1 line
taskcluster/
gecko_taskgraph/
test/
12 lines
kinds/
mochitest/
31 lines
test_configs/
1 line
14 lines
testing/
manifest/
test/
2 lines
mochitest/
6 lines
mozbase/
manifestparser/
manifestparser/
3 lines
mozharness/
mozharness/
mozilla/
testing/
4 lines

Diff 1408972

View Options

docs/code-quality/lint/linters/test-manifest-toml.md

Loading...
View Options

taskcluster/gecko_taskgraph/test/test_transforms_job.py

Loading...
View Options

taskcluster/kinds/mochitest/kind.yml

Loading...
View Options

taskcluster/test_configs/os-integration.yml

Loading...
View Options

taskcluster/test_configs/variants.yml

Loading...
View Options

testing/manifest/test/test_skipfails.py

Loading...
View Options

testing/mochitest/runtests.py

Loading...
View Options

testing/mozbase/manifestparser/manifestparser/token.py

Loading...
View Options

testing/mozharness/mozharness/mozilla/testing/per_test_base.py

Loading...
Privacy · Cookies · Legal