Details

leggert retitled this revision from WIP: Bug 2077172 - Initialize the TLS I/O layer helpers only in the parent process. r=keeler,#necko-reviewers to Bug 2077172 - Initialize the TLS I/O layer helpers only in the parent process. r=keeler,#necko-reviewers.

leggert added reviewers: keeler, necko-reviewers.

Herald added 1 blocking reviewer(s): necko-reviewers. · View Herald TranscriptTue, Oct 6, 2:34 PM

Code analysis found 1 defect in diff 1396905:

1 defect found by pnpm-audit (Mozlint)

IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1396905.

Harbormaster failed remote builds in B1057909: Diff 1396905!Tue, Oct 6, 3:09 PM

keeler added inline comments.Tue, Oct 6, 4:52 PM

security/manager/ssl/nsNSSComponent.cpp
174–180	Should this go too? Is there going to be a socket process after this?

Address review comments; rebased onto 79a90a9e0a86.

leggert marked an inline comment as done.Fri, Oct 9, 5:59 AM

leggert added a subscriber: bwc.

leggert added inline comments.

security/manager/ssl/nsNSSComponent.cpp
174–180	This one has to stay for now. The socket process remains for WebRTC, and the DTLS for WebRTC media runs in it on NSS. (I'm talking to @bwc about removing WebRTC socket process bits as part of this stack.)

leggert marked an inline comment as done.Fri, Oct 9, 6:12 AM

Code analysis found 2 defects in diff 1401212:

2 build errors found by clang-tidy

IMPORTANT: Found 2 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1401212.

Harbormaster failed remote builds in B1061051: Diff 1401212!Fri, Oct 9, 6:33 AM

valentin accepted this revision as: necko-reviewers.Fri, Oct 9, 7:26 AM

keeler added inline comments.Fri, Oct 9, 4:31 PM

security/manager/ssl/nsNSSComponent.cpp
174–180	Does WebRTC not use `nsSSLIOLayerAddToSocket`?

leggert updated this revision to Diff 1404397.Tue, Oct 13, 2:24 PM

leggert marked an inline comment as done.Tue, Oct 13, 2:37 PM

leggert added inline comments.

security/manager/ssl/nsNSSComponent.cpp
174–180	I think WebRTC sets up DTLS directly with DTLS_ImportFD AFAICT?

leggert updated this revision to Diff 1404432.Tue, Oct 13, 2:47 PM

leggert marked an inline comment as done.

Harbormaster failed remote builds in B1063218: Diff 1404397!Tue, Oct 13, 2:50 PM

Harbormaster completed remote builds in B1063254: Diff 1404432.Tue, Oct 13, 3:12 PM

Thanks!

security/manager/ssl/nsNSSComponent.cpp
174–180	Oh, right, yeah.

This revision is now accepted and ready to land.Tue, Oct 13, 4:46 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!