This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Fri, Oct 16, 10:23 AM · needs-testing-tag

padenot accepted D334349: Bug 2082697 - Only reject the AppleVTDecoder decode promise if it still exists..

Fri, Oct 16, 10:23 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

padenot added a comment to D334378: Bug 1883247 - Don't iterate the graph from AudioCallbackDriver data callbacks after it stopped. r?#media-playback-reviewers.

Ah that's a serious cubeb bug, let's fix there.

Fri, Oct 16, 10:18 AM · testing-approved

Yesterday

padenot closed D323920: Bug 1972313 - Fix ADTS duration via exact scan, frozen estimate for streaming. r?#media-playback-reviewers.

Thu, Oct 15, 3:19 PM · testing-approved

padenot committed rFIREFOXAUTOLAND3a650c4952e8: Bug 1972313 - Fix ADTS duration via exact scan, frozen estimate for streaming. (authored by harry75369).

Bug 1972313 - Fix ADTS duration via exact scan, frozen estimate for streaming.

Thu, Oct 15, 3:19 PM

padenot removed reviewers for D326564: Bug 2072679 - Render the layers of a progressive AVIF as they arrive. r?tnikkel: media-playback-reviewers, padenot.

Our review isn't needed here, cool though.

Thu, Oct 15, 2:56 PM · testing-approved, Restricted Project

padenot accepted D323920: Bug 1972313 - Fix ADTS duration via exact scan, frozen estimate for streaming. r?#media-playback-reviewers.

Thu, Oct 15, 2:35 PM · testing-approved

padenot accepted D332395: Bug 2079602 - Replace mozilla::MakeUnique by std::make_unique r=nika!.

Thu, Oct 15, 1:59 PM · testing-exception-unchanged (Doesn't change behavior for users)

padenot accepted D333982: Bug 2069010 - Use bounded spans for preference callback lists. r?gstoll,#firefox-style-system-reviewers.

Thu, Oct 15, 1:59 PM · testing-approved

padenot accepted D326227: Bug 2071613 - Fix the stale tool names in the devtools MCP docs. r?#ai4dev-reviewers.

Thu, Oct 15, 1:58 PM · testing-exception-unchanged (Doesn't change behavior for users)

padenot accepted D332130: Bug 2079424 - Run the SystemClockDriver thread at real-time priority on macOS. r?#media-playback-reviewers.

Ok. The real fix will come in 2081932.

Thu, Oct 15, 1:58 PM · testing-approved

padenot accepted D333663: Bug 2081763 - Update stmo skill to match stmo-cli 0.13.0; r?#ai4dev-reviewers.

Thu, Oct 15, 1:53 PM · testing-exception-unchanged (Doesn't change behavior for users)

padenot accepted D327203: Bug 2072459 - Use fallible planar image extents.

Thu, Oct 15, 1:53 PM · testing-approved

Wed, Oct 14

padenot closed D332846: Bug 2074346 - Update parakeet.cpp to 623a968b r=#media-webspeech-reviewers!.

Wed, Oct 14, 4:15 PM · testing-exception-other (Please leave a comment explaining why)

padenot committed rFIREFOXAUTOLANDbe9336bab1d2: Bug 2074346 - Update parakeet.cpp to 623a968b r=media-webspeech-reviewers… (authored by padenot).

Bug 2074346 - Update parakeet.cpp to 623a968b r=media-webspeech-reviewers…

Wed, Oct 14, 4:15 PM

padenot updated the diff for D332846: Bug 2074346 - Update parakeet.cpp to 623a968b r=#media-webspeech-reviewers!.

Wed, Oct 14, 3:44 PM · testing-exception-other (Please leave a comment explaining why)

padenot closed D332846: Bug 2074346 - Update parakeet.cpp to 623a968b r=#media-webspeech-reviewers!.

Wed, Oct 14, 2:46 PM · testing-exception-other (Please leave a comment explaining why)

padenot committed rFIREFOXAUTOLAND9ddcf22f3999: Bug 2074346 - Update parakeet.cpp to 623a968b r=media-webspeech-reviewers… (authored by padenot).

Bug 2074346 - Update parakeet.cpp to 623a968b r=media-webspeech-reviewers…

Wed, Oct 14, 2:46 PM

padenot created D333692: Bug 2077921 - Fix --disable-webspeech..

Wed, Oct 14, 2:31 PM · testing-approved

padenot closed D325901: Bug 2071898 - Don't bold the body text of the speech recognition model download doorhanger. r?#desktop-theme-reviewers.

Wed, Oct 14, 1:15 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)

padenot committed rFIREFOXAUTOLAND811ae855aa12: Bug 2071898 - Don't bold the body text of the speech recognition model download… (authored by padenot).

Bug 2071898 - Don't bold the body text of the speech recognition model download…

Wed, Oct 14, 1:15 PM

padenot created D333634: Bug 2081132 - Remove Gecko-side Android communication-mode handling. r?#cubeb-reviewers!,#geckoview-reviewers.

Wed, Oct 14, 12:59 PM

padenot added a comment to D329963: Bug 2074122 - Confirm patch fallback for --apply-to here. r?sheehan.

Everything addressed, this should be ready to merge

Wed, Oct 14, 11:55 AM · testing-approved

padenot added inline comments to D329963: Bug 2074122 - Confirm patch fallback for --apply-to here. r?sheehan.

Wed, Oct 14, 11:55 AM · testing-approved

padenot requested review of D329963: Bug 2074122 - Confirm patch fallback for --apply-to here. r?sheehan.

Wed, Oct 14, 11:50 AM · testing-approved

padenot accepted D333594: Bug 2081663 - Add design token train-hop checks to the New Tab AGENTS.md r=#home-newtab-wattle-reviewers-rotation!.

Wed, Oct 14, 11:05 AM · testing-exception-unchanged (Doesn't change behavior for users)

padenot accepted D333328: Bug 2078921 - Update neqo to v0.33.0.

rubberstamping the AGENTS.md addition.

Wed, Oct 14, 11:00 AM · testing-approved

padenot accepted D333435: Bug 2081458 - Fall back to the sample index for oversized MP4 offsets. r?#media-playback-reviewers!.

s/oversized/overflowing/ maybe, in the commit message.

Wed, Oct 14, 10:06 AM · testing-approved

Tue, Oct 13

padenot accepted D333333: Bug 2081277 - Install the cargo agentic tools to ~/.mozbuild/bin r?glandium!,padenot.

No problem from me, as long as it works.

Tue, Oct 13, 5:17 PM · testing-approved

padenot accepted D333255: Bug 2081198 - Bump `webspec-index` skills in-tree to v0.14. r=#ai4dev-reviewers.

Tue, Oct 13, 4:43 PM · testing-exception-unchanged (Doesn't change behavior for users)

padenot requested changes to D332834: Bug 2080453 - Retry MP4 seek to find last keyframe before target time r=#media-playback-reviewers,alwu!.

Marking as "request change" per the discussion above.

Tue, Oct 13, 1:20 PM

padenot added a comment to D332846: Bug 2074346 - Update parakeet.cpp to 623a968b r=#media-webspeech-reviewers!.

Updated, it now revendors cleanly (this wasn't the case).

Tue, Oct 13, 12:58 PM · testing-exception-other (Please leave a comment explaining why)

padenot removed reviewers for D332834: Bug 2080453 - Retry MP4 seek to find last keyframe before target time r=#media-playback-reviewers,alwu!: alwu, media-playback-reviewers.

Tue, Oct 13, 12:46 PM

padenot accepted D332130: Bug 2079424 - Run the SystemClockDriver thread at real-time priority on macOS. r?#media-playback-reviewers.

Tue, Oct 13, 12:42 PM · testing-approved

padenot added inline comments to D332129: Bug 2079424 - Add ThreadParker to mozglue. r?#xpcom-reviewers,glandium.

Tue, Oct 13, 12:42 PM · testing-approved

padenot accepted D325216: Bug 2071132 - Name WebCodecs VideoFrames from their ImagePixelFormat.

Tue, Oct 13, 12:33 PM · testing-approved

padenot accepted D325215: Bug 2071132 - Add ImagePixelFormat to hold the image format from layers::Image.

Typo: ImageBitmap*t*Format in the message

Tue, Oct 13, 12:28 PM · testing-approved

padenot accepted D332753: Bug 2080631 - Use moz-src for dom/media/eme/mediadrm.

Sorry for the delay here.

Tue, Oct 13, 12:03 PM · testing-approved

padenot accepted D332634: Bug 2080387 - Fix #define guards that confuse clang-format.

Sorry for the delay.

Tue, Oct 13, 12:03 PM · Check-in Needed, testing-exception-unchanged (Doesn't change behavior for users)

padenot accepted D333125: Bug 2080940 - Add tests for more main thread GMP queries racing GMP service creation. r?#media-playback-reviewers!.

Tue, Oct 13, 11:27 AM · testing-exception-unchanged (Doesn't change behavior for users)

padenot accepted D333086: Bug 2079559 - Part 5: Record when the external engine refuses a stream that has a pending CDM. r?#media-playback-reviewers!.

Tue, Oct 13, 11:27 AM · testing-approved

padenot accepted D333085: Bug 2079559 - Part 4: Test that setMediaKeys() does not wait for the external engine to start. r?#media-playback-reviewers!.

Tue, Oct 13, 11:27 AM · testing-exception-unchanged (Doesn't change behavior for users)

padenot accepted D333084: Bug 2079559 - Part 3: Test that Media Foundation CDMs are not offered without hardware video decoding. r?#media-playback-reviewers!.

Tue, Oct 13, 11:27 AM · testing-exception-unchanged (Doesn't change behavior for users)

padenot accepted D333083: Bug 2079559 - Part 2: Resolve setMediaKeys() once the CDM is associated with the element. r?#media-playback-reviewers!.

Tue, Oct 13, 11:27 AM · testing-approved

padenot accepted D333082: Bug 2079559 - Part 1: Do not offer Media Foundation CDMs when hardware video decoding is unavailable. r?#media-playback-reviewers!.

Tue, Oct 13, 11:18 AM · testing-approved

padenot accepted D332411: Bug 2079602 - Remove redundant UniquePtr<...> ... = std::make_unique(...) r=nika.

Tue, Oct 13, 11:17 AM · testing-approved

padenot accepted D332586: Bug 2079820 - Skip disabling denormals when not on an audio worklet..

Thanks. I renamed the revisions so you can queue to lando directly, there was a stray WIP in the message.

Tue, Oct 13, 11:14 AM · testing-approved

padenot accepted D332585: Bug 2079820 - Use js/utils/Denormals.h impl in webaudio..

Tue, Oct 13, 11:12 AM · testing-approved

padenot retitled D332586: Bug 2079820 - Skip disabling denormals when not on an audio worklet. from WIP: Bug 2079820 - Skip disabling denormals when not on an audio worklet. to Bug 2079820 - Skip disabling denormals when not on an audio worklet..

Tue, Oct 13, 11:11 AM · testing-approved

padenot retitled D332585: Bug 2079820 - Use js/utils/Denormals.h impl in webaudio. from WIP: Bug 2079820 - Use js/utils/Denormals.h impl in webaudio. to Bug 2079820 - Use js/utils/Denormals.h impl in webaudio..

Tue, Oct 13, 11:11 AM · testing-approved

Mon, Oct 12

padenot added a comment to D331345: Bug 2072655 - Reopen the libopenh264 decoder on flush. r?#media-playback-reviewers.

Thanks a lot, from the look of it they are considering a backport.

Mon, Oct 12, 5:01 PM

padenot requested review of D332846: Bug 2074346 - Update parakeet.cpp to 623a968b r=#media-webspeech-reviewers!.

Mon, Oct 12, 4:42 PM · testing-exception-other (Please leave a comment explaining why)

padenot accepted D331812: Bug 2068021 [Linux] Remove direct dmabuf frames upload for HDR frames but use standard shm image path r?alwu,padenot.

Mon, Oct 12, 4:38 PM · testing-approved

padenot created D332949: Bug 2080908 - Let SpeechRecognition and associated interfaces ride the trains. r?#media-webspeech-reviewers!.

Mon, Oct 12, 4:27 PM · testing-exception-other (Please leave a comment explaining why)

padenot created D332938: Bug 2080876 - Avoid deadlocking EME requests against GMP service initialization. r?#media-playback-reviewers!.

Mon, Oct 12, 4:00 PM · testing-exception-unchanged (Doesn't change behavior for users)

padenot requested review of D332920: Bug 2080876 - Log GMP service initialization and MediaCapabilities decoder support queries. r?#media-playback-reviewers!.

Mon, Oct 12, 4:00 PM · testing-exception-unchanged (Doesn't change behavior for users)

padenot accepted D332909: Bug 2009308 - Update libcubeb to 2e87c633. r?#cubeb-reviewers.

Mon, Oct 12, 3:30 PM · testing-approved

padenot removed a reviewer for D332484: Bug 2009308 - Stop hardcoding cubeb's preferred sample rate and min latency for isolated content processes. r?#cubeb-reviewers: pehrsons.

Mon, Oct 12, 3:30 PM · testing-approved

padenot planned changes to D332921: WIP: Bug 2080876 - Avoid XPCOM service lookup in HaveGMPFor. r?#media-playback-reviewers!.

Mon, Oct 12, 3:11 PM

padenot planned changes to D332920: Bug 2080876 - Log GMP service initialization and MediaCapabilities decoder support queries. r?#media-playback-reviewers!.

Mon, Oct 12, 3:11 PM · testing-exception-unchanged (Doesn't change behavior for users)

padenot requested review of D329963: Bug 2074122 - Confirm patch fallback for --apply-to here. r?sheehan.

Mon, Oct 12, 1:32 PM · testing-approved

padenot accepted D332484: Bug 2009308 - Stop hardcoding cubeb's preferred sample rate and min latency for isolated content processes. r?#cubeb-reviewers.

The gecko side looks alright. We can get this in this repo just by doing ./mach vendor for cubeb. I've getting us data to check what audio backends we're using these days.

Mon, Oct 12, 1:14 PM · testing-approved

padenot edited reviewers for D332178: Bug 2079836 - Fix colors when drawing VideoFrames from RGBA and BGRA buffers. r?#media-playback-reviewers!,#layout-reviewers,#webgpu-reviewers, added: chunmin; removed: media-playback-reviewers.

@chunmin, can you have a look at this one?

Mon, Oct 12, 12:30 PM · testing-approved

padenot accepted D332791: Bug 2080565 - Remove unused .properties strings, r=#firefox-desktop-core-reviewers!.

Mon, Oct 12, 12:30 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)

padenot accepted D331975: Bug 2080173 - Don't parse MOZ_LOG in the WMF CDM origins list service. r?#media-playback-reviewers.

Mon, Oct 12, 12:24 PM · testing-approved

padenot accepted D332351: Bug 2080120 - Clear the promise holder before resolving in TestOfflineClockDriver.TimeAdvance. r?#media-playback-reviewers.

Mon, Oct 12, 12:22 PM · testing-exception-unchanged (Doesn't change behavior for users)

padenot closed D330744: Bug 2078207 - Remove explicit promise gripping attributes on SpeechRecogntion object for model dowload. r?#media-webspeech-reviewers.

Mon, Oct 12, 11:42 AM · needs-testing-tag