[go: up one dir, main page]
Page MenuHomePhabricator
Differential D330535

Bug 2077605 - Register SOURCE_HEADERS for dom/
ClosedPublic
Actions

Authored by sergesanspaille on Fri, Oct 2, 10:01 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Oct 15, 12:43 PM
Unknown Object (File)
Thu, Oct 15, 1:19 AM
Unknown Object (File)
Thu, Oct 15, 12:16 AM
Unknown Object (File)
Thu, Oct 15, 12:09 AM
Unknown Object (File)
Wed, Oct 14, 9:14 PM
Unknown Object (File)
Wed, Oct 14, 9:13 PM
Unknown Object (File)
Wed, Oct 14, 8:32 PM
Unknown Object (File)
Wed, Oct 14, 7:45 PM
View All 67 Files
Subscribers
asuth
bryce
edgar
gstoll
karlt
ng
padenot
View All 10 Subscribers

Details

Reviewers
saschanaz
ng
asuth
pehrsons
padenot
gstoll
Group Reviewers
media-playback-reviewers
webrtc-reviewers
dom-storage-reviewers
firefox-svg-reviewers
dom-worker-reviewers
device-api-reviewers
media-webspeech-reviewers
Commits
rFIREFOXAUTOLAND3e573caff5c8: Bug 2077605 - Register SOURCE_HEADERS for dom/ r=saschanaz,media-playback…
Bugzilla Bug ID
2077605
Summary

This requires a few changes:

As a side effect remove dom/media/webrtc/common/NullTransport.h that's
never referenced.

Diff Detail

Event Timeline

sergesanspaille created this revision.Fri, Oct 2, 10:01 PM
Herald added a project: secure-revision. · View Herald TranscriptFri, Oct 2, 10:01 PM
phab-bot published this revision for review.Fri, Oct 2, 10:04 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: saschanaz. · View Herald TranscriptFri, Oct 2, 10:04 PM
Herald added a reviewer: media-playback-reviewers. · View Herald Transcript
Herald added a reviewer: webrtc-reviewers. · View Herald Transcript
Herald added a reviewer: dom-storage-reviewers. · View Herald Transcript
Herald added a reviewer: firefox-svg-reviewers. · View Herald Transcript
Herald added a reviewer: dom-worker-reviewers. · View Herald Transcript
Herald added a reviewer: device-api-reviewers. · View Herald Transcript
Herald added a reviewer: media-webspeech-reviewers. · View Herald Transcript
Herald added subscribers: zrhoffman, bryce, edgar and 2 others. · View Herald Transcript
sergesanspaille updated this revision to Diff 1394290.Fri, Oct 2, 10:18 PM
Harbormaster failed remote builds in B1056084: Diff 1394281!Fri, Oct 2, 10:36 PM
ng accepted this revision.Fri, Oct 2, 10:48 PM
ng added a subscriber: ng.

Nice! r+ for /dom/media/webrtc

reviewbot added a project: testing-approved.Fri, Oct 2, 10:52 PM
reviewbot added a subscriber: reviewbot.

Code analysis found 1 defect in diff 1394290:

  • 1 build error found by clang-tidy
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1394290.

Harbormaster failed remote builds in B1056087: Diff 1394290!Fri, Oct 2, 10:52 PM
saschanaz accepted this revision.Fri, Oct 2, 11:07 PM
sergesanspaille updated this revision to Diff 1394362.Sat, Oct 3, 6:59 AM
Harbormaster completed remote builds in B1056141: Diff 1394362.Sat, Oct 3, 7:31 AM
sergesanspaille updated this revision to Diff 1394382.Sat, Oct 3, 10:10 AM
sergesanspaille updated this revision to Diff 1394414.Sat, Oct 3, 10:13 AM
Harbormaster failed remote builds in B1056154: Diff 1394382!Sat, Oct 3, 10:31 AM
reviewbot added a comment.Sat, Oct 3, 10:45 AM

Code analysis found 1 defect in diff 1394414:

  • 1 defect found by c-includes (Mozlint)
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1394414.

Harbormaster failed remote builds in B1056185: Diff 1394414!Sat, Oct 3, 10:45 AM
sergesanspaille updated this revision to Diff 1394479.Sat, Oct 3, 3:44 PM
Harbormaster completed remote builds in B1056238: Diff 1394479.Sat, Oct 3, 4:11 PM
asuth accepted this revision.Sun, Oct 4, 5:56 PM
asuth added a subscriber: asuth.

r=asuth for workers and storage. Thanks for improving out static analysis infra!

pehrsons accepted this revision.Mon, Oct 5, 9:24 AM
padenot accepted this revision.Mon, Oct 5, 1:01 PM
padenot added a subscriber: padenot.

r+ for media-playback-reviewers

padenot added a comment.Mon, Oct 5, 1:01 PM

And webspeech as well.

gstoll accepted this revision.Mon, Oct 5, 1:15 PM
gstoll added a subscriber: gstoll.

r+ for dom/midi and dom/webserial

This revision is now accepted and ready to land.Mon, Oct 5, 1:15 PM
sergesanspaille updated this revision to Diff 1395232.Mon, Oct 5, 2:01 PM
Harbormaster completed remote builds in B1056708: Diff 1395232.Mon, Oct 5, 2:34 PM
sergesanspaille updated this revision to Diff 1397204.Tue, Oct 6, 5:27 PM
sergesanspaille added a child revision: D331324: Bug 2078245 - Add mozbuild's SOURCE_HEADERS linter r=ahochheiden!.
sergesanspaille updated this revision to Diff 1397226.Tue, Oct 6, 5:30 PM
sergesanspaille updated this revision to Diff 1397271.Tue, Oct 6, 5:50 PM
Harbormaster failed remote builds in B1058136: Diff 1397226!Tue, Oct 6, 6:08 PM
Harbormaster failed remote builds in B1058120: Diff 1397204!
Harbormaster completed remote builds in B1058158: Diff 1397271.Tue, Oct 6, 6:26 PM
sergesanspaille updated this revision to Diff 1398850.Wed, Oct 7, 7:03 PM
Harbormaster completed remote builds in B1059334: Diff 1398850.Wed, Oct 7, 7:56 PM
longsonr accepted this revision as: firefox-svg-reviewers.Wed, Oct 7, 10:03 PM
sergesanspaille updated this revision to Diff 1399547.Thu, Oct 8, 6:55 AM
sergesanspaille updated this revision to Diff 1399584.Thu, Oct 8, 7:10 AM
This revision was landed with ongoing or failed builds.Thu, Oct 8, 7:26 AM
Closed by commit rFIREFOXAUTOLAND3e573caff5c8: Bug 2077605 - Register SOURCE_HEADERS for dom/ r=saschanaz,media-playback… (authored by sergesanspaille). · Explain Why
This revision was automatically updated to reflect the committed changes.
sergesanspaille added a commit: rFIREFOXAUTOLAND3e573caff5c8: Bug 2077605 - Register SOURCE_HEADERS for dom/ r=saschanaz,media-playback….
Harbormaster failed remote builds in B1059871: Diff 1399547!Thu, Oct 8, 7:28 AM
Harbormaster completed remote builds in B1059911: Diff 1399584.Thu, Oct 8, 7:44 AM

Large Diff

This large diff affects 154 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
dom/
base/
35 lines
battery/
4 lines
bindings/
4 lines
test/
24 lines
broadcastchannel/
6 lines
cache/
7 lines
canvas/
2 lines
2 lines
2 lines
1 line
14 lines
17 lines
41 lines
clients/
api/
4 lines
manager/
16 lines
compression/
7 lines
console/
4 lines
cookiestore/
6 lines
events/
5 lines
fetch/
4 lines
file/
5 lines
filesystem/
compat/
6 lines
6 lines
fs/
child/
2 lines
13 lines
7 lines
parent/
datamodel/
9 lines
11 lines
test/
gtest/
5 lines
parent/
5 lines
geolocation/
4 lines
html/
2 lines
5 lines
indexedDB/
20 lines
ipc/
8 lines
11 lines
jsactor/
4 lines
5 lines
localstorage/
9 lines
media/
8 lines
8 lines
10 lines
2 lines
doctor/
13 lines
driftcontrol/
7 lines
encoder/
4 lines
fake-cdm/
2 lines
6 lines
gmp/
9 lines
gtest/
11 lines
imagecapture/
4 lines
ipc/
5 lines
mediacapabilities/
4 lines
mediacontrol/
4 lines
tests/
gtest/
4 lines
mediasink/
12 lines
16 lines
8 lines
mediasource/
7 lines
25 lines
platforms/
ffmpeg/
3 lines
26 lines
omx/
5 lines
5 lines
1 line
10 lines
wmf/
8 lines
systemservices/
7 lines
webaudio/
1 line
19 lines
29 lines
blink/
21 lines
11 lines
webcodecs/
4 lines
webm/
4 lines
webrtc/
common/
2 lines
10 lines
jsapi/
16 lines
jsep/
2 lines
2 lines
8 lines
11 lines
libwebrtcglue/
25 lines
7 lines
sdp/
2 lines
26 lines
transport/
ipc/
4 lines
31 lines
test/
9 lines
transportbridge/
6 lines
webspeech/
recognition/
5 lines
synth/
cocoa/
4 lines
speechd/
4 lines
windows/
4 lines
messagechannel/
4 lines
midi/
8 lines
network/
5 lines
payments/
6 lines
permission/
4 lines
quota/
10 lines
9 lines
8 lines
4 lines
5 lines
28 lines
test/
gtest/
4 lines
serializers/
gtest/
4 lines
serviceworkers/
3 lines
17 lines
simpledb/
8 lines
smil/
10 lines
storage/
2 lines
9 lines
streams/
8 lines
12 lines
19 lines
svg/
3 lines
3 lines
56 lines
system/
android/
4 lines
linux/
6 lines
mac/
4 lines
windows/
location/
8 lines
url/
5 lines
vr/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
9 lines
webauthn/
14 lines
tests/
gtest/
4 lines
webbrowserpersist/
9 lines
webserial/
20 lines
workers/
2 lines
8 lines
sharedworkers/
4 lines
3 lines
4 lines
xhr/
2 lines
2 lines
4 lines
xml/
5 lines
xslt/
base/
14 lines
2 lines
2 lines
xml/
5 lines
xpath/
15 lines
xslt/
27 lines
xul/
9 lines
tools/
clang-tidy/
3 lines

Diff 1399663

View Options

dom/base/moz.build

View Options

dom/battery/moz.build

View Options

dom/bindings/moz.build

View Options

dom/bindings/test/moz.build

View Options

dom/broadcastchannel/moz.build

View Options

dom/cache/moz.build

View Options

dom/canvas/DrawTargetWebglInternal.h

View Options

dom/canvas/SourceSurfaceWebgl.h

View Options

dom/canvas/SourceSurfaceWebgl.cpp

View Options

dom/canvas/WebGLQueueParamTraits.h

View Options

dom/canvas/WebGLVertexArray.h

View Options

dom/canvas/WebGLVertexArray.cpp

View Options

dom/canvas/moz.build

View Options

dom/clients/api/moz.build

View Options

dom/clients/manager/moz.build

View Options

dom/compression/moz.build

View Options

dom/console/moz.build

View Options

dom/cookiestore/moz.build

View Options

dom/events/moz.build

View Options

dom/fetch/moz.build

View Options

dom/file/moz.build

View Options

dom/filesystem/compat/moz.build

View Options

dom/filesystem/moz.build

View Options

dom/fs/child/FileSystemEntryMetadataArray.h

View Options

dom/fs/child/FileSystemEntryMetadataArray.cpp

View Options

dom/fs/child/moz.build

View Options

dom/fs/parent/datamodel/moz.build

View Options

dom/fs/parent/moz.build

View Options

dom/fs/test/gtest/moz.build

View Options

dom/fs/test/gtest/parent/moz.build

View Options

dom/geolocation/moz.build

View Options

dom/html/HTMLFormSubmissionConstants.h

View Options

dom/html/moz.build

View Options

dom/indexedDB/moz.build

View Options

dom/ipc/ColorPickerParent.h

View Options

dom/ipc/ColorPickerParent.cpp

View Options

dom/ipc/jsactor/moz.build

View Options

dom/ipc/moz.build

View Options

dom/localstorage/moz.build

View Options

dom/media/FileMediaResource.h

View Options

dom/media/FileMediaResource.cpp

View Options

dom/media/MediaBlockCacheBase.h

View Options

dom/media/MediaChannelStatistics.h

View Options

dom/media/doctor/moz.build

View Options

dom/media/driftcontrol/moz.build

View Options

dom/media/encoder/moz.build

View Options

dom/media/fake-cdm/cdm-test-output-protection.h

View Options

dom/media/fake-cdm/moz.build

View Options

dom/media/gmp/moz.build

View Options

dom/media/gtest/moz.build

View Options

dom/media/imagecapture/moz.build

View Options

dom/media/ipc/moz.build

View Options

dom/media/mediacapabilities/moz.build

View Options

dom/media/mediacontrol/moz.build

View Options

dom/media/mediacontrol/tests/gtest/moz.build

View Options

dom/media/mediasink/AudioSinkWrapper.h

View Options

dom/media/mediasink/AudioSinkWrapper.cpp

View Options

dom/media/mediasink/moz.build

View Options

dom/media/mediasource/moz.build

View Options

dom/media/moz.build

View Options

dom/media/platforms/ffmpeg/FFmpegVideoFramePool.h

View Options

dom/media/platforms/ffmpeg/moz.build

View Options

dom/media/platforms/omx/OmxPromiseLayer.h

View Options

dom/media/platforms/omx/OmxPromiseLayer.cpp

View Options

dom/media/platforms/omx/PureOmxPlatformLayer.h

View Options

dom/media/platforms/omx/moz.build

View Options

dom/media/platforms/wmf/moz.build

View Options

dom/media/systemservices/moz.build

View Options

dom/media/webaudio/PanningUtils.h

View Options

dom/media/webaudio/PlayingRefChangeHandler.h

View Options

dom/media/webaudio/PlayingRefChangeHandler.cpp

View Options

dom/media/webaudio/ReportDecodeResultTask.h

View Options

dom/media/webaudio/blink/moz.build

View Options

dom/media/webaudio/moz.build

View Options

dom/media/webcodecs/moz.build

View Options

dom/media/webm/moz.build

View Options

dom/media/webrtc/common/NullTransport.h

View Options

dom/media/webrtc/common/Wrapper.h

View Options

dom/media/webrtc/common/moz.build

View Options

dom/media/webrtc/jsapi/moz.build

View Options

dom/media/webrtc/jsep/JsepCodecDescription.h

View Options

dom/media/webrtc/jsep/JsepSession.h

View Options

dom/media/webrtc/jsep/JsepTransport.h

View Options

dom/media/webrtc/jsep/moz.build

View Options

dom/media/webrtc/libwebrtcglue/moz.build

View Options

dom/media/webrtc/moz.build

View Options

dom/media/webrtc/sdp/SdpAttributeList.h

View Options

dom/media/webrtc/sdp/moz.build

View Options

dom/media/webrtc/transport/ipc/moz.build

View Options

dom/media/webrtc/transport/moz.build

View Options

dom/media/webrtc/transport/test/moz.build

View Options

dom/media/webrtc/transportbridge/moz.build

View Options

dom/media/webspeech/recognition/moz.build

View Options

dom/media/webspeech/synth/cocoa/moz.build

View Options

dom/media/webspeech/synth/speechd/moz.build

View Options

dom/media/webspeech/synth/windows/moz.build

View Options

dom/messagechannel/moz.build

View Options

dom/midi/moz.build

View Options

dom/network/moz.build

View Options

dom/payments/moz.build

View Options

dom/permission/moz.build

View Options

dom/quota/DirtyTrackingAutoLock.h

View Options

dom/quota/DirtyTrackingAutoLock.cpp

View Options

dom/quota/OpenClientDirectoryUtils.h

View Options

dom/quota/QuotaRequestBase.h

View Options

dom/quota/QuotaRequestBase.cpp

View Options

dom/quota/moz.build

View Options

dom/quota/test/gtest/moz.build

View Options

dom/serializers/gtest/moz.build

View Options

dom/serviceworkers/ServiceWorkerRegistrationListener.h

View Options

dom/serviceworkers/moz.build

View Options

dom/simpledb/moz.build

View Options

dom/smil/moz.build

View Options

dom/storage/StorageCommon.h

View Options

dom/storage/moz.build

View Options

dom/streams/ReadableStreamTee.h

View Options

dom/streams/ReadableStreamTee.cpp

View Options

dom/streams/moz.build

View Options

dom/svg/SVGTransformListParser.h

View Options

dom/svg/SVGTransformListParser.cpp

View Options

dom/svg/moz.build

View Options

dom/system/android/moz.build

View Options

dom/system/linux/moz.build

View Options

dom/system/mac/moz.build

View Options

dom/system/windows/location/moz.build

View Options

dom/url/moz.build

View Options

dom/vr/XRNativeOriginLocal.h

View Options

dom/vr/XRNativeOriginLocal.cpp

View Options

dom/vr/XRNativeOriginLocalFloor.h

View Options

dom/vr/XRNativeOriginLocalFloor.cpp

View Options

dom/vr/XRNativeOriginViewer.h

View Options

dom/vr/XRNativeOriginViewer.cpp

View Options

dom/vr/moz.build

View Options

dom/webauthn/moz.build

View Options

dom/webauthn/tests/gtest/moz.build

View Options

dom/webbrowserpersist/moz.build

View Options

dom/webserial/moz.build

View Options

dom/workers/WorkerThread.h

View Options

dom/workers/moz.build

View Options

dom/workers/sharedworkers/SharedWorkerService.h

View Options

dom/workers/sharedworkers/SharedWorkerService.cpp

View Options

dom/workers/sharedworkers/moz.build

View Options

dom/xhr/XMLHttpRequestWorker.h

View Options

dom/xhr/XMLHttpRequestWorker.cpp

View Options

dom/xhr/moz.build

View Options

dom/xml/moz.build

View Options

dom/xslt/base/moz.build

View Options

dom/xslt/base/txErrorObserver.h

View Options

dom/xslt/base/txOwningArray.h

View Options

dom/xslt/xml/moz.build

View Options

dom/xslt/xpath/moz.build

View Options

dom/xslt/xslt/moz.build

View Options

dom/xul/moz.build

View Options

tools/clang-tidy/config.yaml

Privacy · Cookies · Legal