hsingh (Harveer Singh)
User

Projects

dom-storage-reviewers
Group

User Details

User Since: Apr 5 2022, 7:05 PM (236 w, 3 d)
Availability: Available
Review Queue: 6

Recent Activity
View All

Today

hsingh accepted D296312: Bug 2034086: Make fileIds unknown on failed removals. r=#dom-storage.

overall the changes look good to me but I think we should be adding a comment in the bug providing a workaround for profiles which are already effected by this as the patch doesn't introduce any recovery mechanism for the profiles that already got effected.

Fri, Oct 16, 2:39 PM · testing-approved

Yesterday

hsingh accepted D323286: Bug 2068220: Remove unused DirtyTrackingAutoLock::Touch/mTouched. r=#dom-storage.

Thu, Oct 15, 3:59 PM · testing-exception-unchanged (Doesn't change behavior for users)

hsingh added a comment to D323286: Bug 2068220: Remove unused DirtyTrackingAutoLock::Touch/mTouched. r=#dom-storage.

Thank you for the patch. changes lgtm.

Thu, Oct 15, 3:58 PM · testing-exception-unchanged (Doesn't change behavior for users)

Wed, Oct 14

hsingh accepted D331631: Bug 2078223 - Reject the MozPromise instead of leak on shutdown in FileSystemBackgroundRequestHandler.cpp r?#dom-storage!.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Wed, Oct 14, 3:35 PM · needs-testing-tag

Thu, Oct 8

hsingh accepted D309338: Bug 2055756: Add mochitests for quota usage and persist operations. r=#dom-storage.

Thu, Oct 8, 6:27 PM · needs-testing-tag

hsingh accepted D331935: Bug 2079600 - Account for SQLite encryption on cache cleanup test r?#dom-storage!.

Thu, Oct 8, 3:38 PM · testing-exception-unchanged (Doesn't change behavior for users)

hsingh added inline comments to D331935: Bug 2079600 - Account for SQLite encryption on cache cleanup test r?#dom-storage!.

Thu, Oct 8, 3:38 PM · testing-exception-unchanged (Doesn't change behavior for users)

hsingh added a reviewer for D331907: Bug 2051927: Return unreadable File from getFile() while sync access handle is open. r=#dom-storage: hsingh.

Thu, Oct 8, 3:35 PM · testing-approved

hsingh added a reviewer for D331631: Bug 2078223 - Reject the MozPromise instead of leak on shutdown in FileSystemBackgroundRequestHandler.cpp r?#dom-storage!: hsingh.

Thu, Oct 8, 3:34 PM · needs-testing-tag

hsingh edited reviewers for D331935: Bug 2079600 - Account for SQLite encryption on cache cleanup test r?#dom-storage!, added: hsingh; removed: dom-worker-reviewers.

Thu, Oct 8, 3:34 PM · testing-exception-unchanged (Doesn't change behavior for users)

hsingh committed rFIREFOXBETAdcb704630a1d: Bug 2073660 - Report ServiceWorker console errors from the main thread. (authored by hsingh-moz <105445818+hsingh-moz@users.noreply.github.com>).

Bug 2073660 - Report ServiceWorker console errors from the main thread.

Thu, Oct 8, 3:18 PM

hsingh committed rFIREFOXBETA61632478aac6: Bug 2072409 - Guard DecryptingInputStream state with a mutex. r=dom-storage… (authored by hsingh-moz <105445818+hsingh-moz@users.noreply.github.com>).

Bug 2072409 - Guard DecryptingInputStream state with a mutex. r=dom-storage…

Thu, Oct 8, 3:06 PM

hsingh committed rFIREFOXBETA2d33105047eb: Bug 2072411 - Guard DecryptingInputStream state with a mutex. r=dom-storage… (authored by hsingh).

Bug 2072411 - Guard DecryptingInputStream state with a mutex. r=dom-storage…

Thu, Oct 8, 2:44 PM

Wed, Oct 7

hsingh committed rFIREFOXRELEASEb18691d1070e: Bug 1374970: navigator.storage.estimate must return origin usage rather than… (authored by hsingh).

Bug 1374970: navigator.storage.estimate must return origin usage rather than…

Wed, Oct 7, 11:31 PM

hsingh committed rFIREFOXRELEASE7214bbf13592: Bug 2069638 - Keep SQLite temporary storage in memory for encrypted storage… (authored by hsingh).

Bug 2069638 - Keep SQLite temporary storage in memory for encrypted storage…

Wed, Oct 7, 11:26 PM

hsingh committed rFIREFOXAUTOLANDdcb704630a1d: Bug 2073660 - Report ServiceWorker console errors from the main thread. (authored by hsingh-moz <105445818+hsingh-moz@users.noreply.github.com>).

Bug 2073660 - Report ServiceWorker console errors from the main thread.

Wed, Oct 7, 6:14 PM

Mon, Oct 5

hsingh committed rFIREFOXAUTOLAND61632478aac6: Bug 2072409 - Guard DecryptingInputStream state with a mutex. r=dom-storage… (authored by hsingh-moz <105445818+hsingh-moz@users.noreply.github.com>).

Bug 2072409 - Guard DecryptingInputStream state with a mutex. r=dom-storage…

Mon, Oct 5, 6:02 PM

Fri, Sep 25

hsingh committed rFIREFOXAUTOLAND2d33105047eb: Bug 2072411 - Guard DecryptingInputStream state with a mutex. r=dom-storage… (authored by hsingh).

Bug 2072411 - Guard DecryptingInputStream state with a mutex. r=dom-storage…

Fri, Sep 25, 3:37 PM

Thu, Sep 24

hsingh committed rFIREFOXBETAb18691d1070e: Bug 1374970: navigator.storage.estimate must return origin usage rather than… (authored by hsingh).

Bug 1374970: navigator.storage.estimate must return origin usage rather than…

Thu, Sep 24, 4:03 PM

hsingh committed rFIREFOXBETA7214bbf13592: Bug 2069638 - Keep SQLite temporary storage in memory for encrypted storage… (authored by hsingh).

Bug 2069638 - Keep SQLite temporary storage in memory for encrypted storage…

Thu, Sep 24, 3:55 PM

hsingh committed rFIREFOXRELEASE8c7497194250: Bug 2055694 - Generate a random nonce per message in NSSCipherStrategy r=dom… (authored by hsingh).

Bug 2055694 - Generate a random nonce per message in NSSCipherStrategy r=dom…

Thu, Sep 24, 7:33 AM

hsingh committed rFIREFOXRELEASEe85b3d43e108: Bug 2015213 - Relax a debug-only worker principal assertion for a pref-gates… (authored by hsingh).

Bug 2015213 - Relax a debug-only worker principal assertion for a pref-gates…

Thu, Sep 24, 7:05 AM

Wed, Sep 23

hsingh added a comment to D296312: Bug 2034086: Make fileIds unknown on failed removals. r=#dom-storage.

@jari Could you please explanation on the bug and how the patch is fixing it ? I don't see much details in the bug or here on the patch.

Wed, Sep 23, 4:09 PM · testing-approved

Tue, Sep 22

hsingh closed D324981: Bug 1374970: navigator.storage.estimate must return origin usage rather than groups.r=jari.

Tue, Sep 22, 7:49 PM · testing-exception-unchanged (Doesn't change behavior for users)

hsingh committed rFIREFOXAUTOLANDb18691d1070e: Bug 1374970: navigator.storage.estimate must return origin usage rather than… (authored by hsingh).

Bug 1374970: navigator.storage.estimate must return origin usage rather than…

Tue, Sep 22, 7:49 PM

hsingh removed a reviewer for D317838: Bug 2056884: Stop using .metadata-v2 files except for recovery. r=#dom-storage: dom-worker-reviewers.

Tue, Sep 22, 2:21 PM · testing-approved

hsingh added a reviewer for D296312: Bug 2034086: Make fileIds unknown on failed removals. r=#dom-storage: hsingh.

Tue, Sep 22, 2:20 PM · testing-approved

Mon, Sep 21

hsingh committed rFIREFOXAUTOLAND7214bbf13592: Bug 2069638 - Keep SQLite temporary storage in memory for encrypted storage… (authored by hsingh).

Bug 2069638 - Keep SQLite temporary storage in memory for encrypted storage…

Mon, Sep 21, 6:25 PM

hsingh updated the diff for D324981: Bug 1374970: navigator.storage.estimate must return origin usage rather than groups.r=jari.

Mon, Sep 21, 3:47 PM · testing-exception-unchanged (Doesn't change behavior for users)

Sep 16 2026

hsingh planned changes to D326545: WIP: Bug 1833219: suspend event processing until the window resumes.

Sep 16 2026, 2:58 PM

Sep 15 2026

hsingh added a reviewer for D317838: Bug 2056884: Stop using .metadata-v2 files except for recovery. r=#dom-storage: hsingh.

Sep 15 2026, 2:40 PM · testing-approved

Sep 14 2026

hsingh updated the diff for D324981: Bug 1374970: navigator.storage.estimate must return origin usage rather than groups.r=jari.

Sep 14 2026, 11:27 PM · testing-exception-unchanged (Doesn't change behavior for users)

Sep 11 2026

hsingh updated the diff for D324981: Bug 1374970: navigator.storage.estimate must return origin usage rather than groups.r=jari.

Sep 11 2026, 2:16 PM · testing-exception-unchanged (Doesn't change behavior for users)

Sep 10 2026

hsingh created D324981: Bug 1374970: navigator.storage.estimate must return origin usage rather than groups.r=jari.

Sep 10 2026, 2:24 PM · testing-exception-unchanged (Doesn't change behavior for users)

hsingh accepted D324956: Bug 2070899 - Quota manager test: use EXPECT_THAT(testing::Each()) instead of std::all. r?#dom-storage.

changes/improvements lgtm.

Sep 10 2026, 1:13 PM · testing-approved

hsingh added a comment to D323652: Bug 2056841: Validate OriginInfo after lock reacquisition. r=#dom-storage.

Approved. Changes lgtm.

Sep 10 2026, 1:06 PM · testing-exception-other (Please leave a comment explaining why)

hsingh accepted D323652: Bug 2056841: Validate OriginInfo after lock reacquisition. r=#dom-storage.

Sep 10 2026, 1:05 PM · testing-exception-other (Please leave a comment explaining why)

hsingh committed rFIREFOXBETA8c7497194250: Bug 2055694 - Generate a random nonce per message in NSSCipherStrategy r=dom… (authored by hsingh).

Bug 2055694 - Generate a random nonce per message in NSSCipherStrategy r=dom…

Sep 10 2026, 11:51 AM

hsingh committed rFIREFOXBETAe85b3d43e108: Bug 2015213 - Relax a debug-only worker principal assertion for a pref-gates… (authored by hsingh).

Bug 2015213 - Relax a debug-only worker principal assertion for a pref-gates…

Sep 10 2026, 11:27 AM

Sep 9 2026

hsingh committed rFIREFOXRELEASE91ab66d3860f: Bug 2054702: Perform principal validation in PQuotaRequests.r=dom-storage… (authored by hsingh).

Bug 2054702: Perform principal validation in PQuotaRequests.r=dom-storage…

Sep 9 2026, 5:48 PM

hsingh added a reviewer for D323652: Bug 2056841: Validate OriginInfo after lock reacquisition. r=#dom-storage: hsingh.

Sep 9 2026, 1:22 PM · testing-exception-other (Please leave a comment explaining why)

Sep 4 2026

hsingh committed rFIREFOXAUTOLAND8c7497194250: Bug 2055694 - Generate a random nonce per message in NSSCipherStrategy r=dom… (authored by hsingh).

Bug 2055694 - Generate a random nonce per message in NSSCipherStrategy r=dom…

Sep 4 2026, 1:22 PM

hsingh added a reviewer for D323553: Bug 2068220: Hold a write lease for IndexedDB write transactions. r=#dom-storage: hsingh.

Sep 4 2026, 1:19 PM · testing-approved

Aug 31 2026

hsingh closed D321705: Bug 2015213 - Relax a debug-only worker principal assertion for a pref-gates configuration.r=#dom-worker-reviewers.

Aug 31 2026, 3:13 PM · testing-exception-unchanged (Doesn't change behavior for users)

hsingh committed rFIREFOXAUTOLANDe85b3d43e108: Bug 2015213 - Relax a debug-only worker principal assertion for a pref-gates… (authored by hsingh).

Bug 2015213 - Relax a debug-only worker principal assertion for a pref-gates…

Aug 31 2026, 3:13 PM

hsingh accepted D314958: Bug 2056841: Eliminate race on OriginInfo changes by holding mutex continuously. r=#dom-storage.

Aug 31 2026, 1:20 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

Aug 27 2026

hsingh added inline comments to D314958: Bug 2056841: Eliminate race on OriginInfo changes by holding mutex continuously. r=#dom-storage.

Aug 27 2026, 8:01 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

hsingh added inline comments to D314958: Bug 2056841: Eliminate race on OriginInfo changes by holding mutex continuously. r=#dom-storage.

Aug 27 2026, 6:41 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

hsingh committed rFIREFOXBETA91ab66d3860f: Bug 2054702: Perform principal validation in PQuotaRequests.r=dom-storage… (authored by hsingh).

Bug 2054702: Perform principal validation in PQuotaRequests.r=dom-storage…

Aug 27 2026, 1:52 PM

Aug 26 2026

hsingh added a reviewer for D317847: Bug 2061151: Preserve the persisted flag when the storage database is rebuilt. r=#dom-storage: hsingh.

Aug 26 2026, 10:43 PM · testing-approved

hsingh added a reviewer for D218535: Bug 1547047 - Test binary IDB object store index names. r=#dom-storage: hsingh.

Aug 26 2026, 10:42 PM

hsingh accepted D291432: Bug 2028375: Improve IDB Cursor Tests. r=#dom-storage.

Aug 26 2026, 10:41 PM · testing-approved

hsingh added a reviewer for D291432: Bug 2028375: Improve IDB Cursor Tests. r=#dom-storage: hsingh.

Aug 26 2026, 10:41 PM · testing-approved

hsingh created D321705: Bug 2015213 - Relax a debug-only worker principal assertion for a pref-gates configuration.r=#dom-worker-reviewers.

Aug 26 2026, 8:59 PM · testing-exception-unchanged (Doesn't change behavior for users)

hsingh committed rFIREFOXRELEASEbeffc966753e: Bug 2059183: Fixing storage usage for persisted origins.#dom-storage-reviewers… (authored by hsingh-moz <105445818+hsingh-moz@users.noreply.github.com>).

Bug 2059183: Fixing storage usage for persisted origins.#dom-storage-reviewers…

Aug 26 2026, 8:44 PM

hsingh committed rFIREFOXRELEASE751f779af377: Bug 2055681: Only allowed parent process to construct protocol for… (authored by hsingh).

Bug 2055681: Only allowed parent process to construct protocol for…

Aug 26 2026, 8:20 PM

hsingh committed rFIREFOXRELEASE2eb4d9c5af74: Bug 2025732: Increase Cache API opaque response padding.r=dom-storage-reviewers… (authored by hsingh).

Bug 2025732: Increase Cache API opaque response padding.r=dom-storage-reviewers…

Aug 26 2026, 8:03 PM

hsingh committed rFIREFOXRELEASE78c63883a325: Bug 2052481 - Replace EARLY_BETA_OR_EARLIER with NIGHTLY_BUILD for dom.workers. (authored by hsingh).

Bug 2052481 - Replace EARLY_BETA_OR_EARLIER with NIGHTLY_BUILD for dom.workers.

Aug 26 2026, 8:00 PM

hsingh accepted D321516: Bug 2066750 - Quota manager: add telemetry for initilization failures because of storage.sqlite file corruption. r?#dom-storage-reviewers.

Aug 26 2026, 2:53 PM · Restricted Project, testing-exception-other (Please leave a comment explaining why)

Aug 20 2026

hsingh committed rFIREFOXAUTOLAND91ab66d3860f: Bug 2054702: Perform principal validation in PQuotaRequests.r=dom-storage… (authored by hsingh).

Bug 2054702: Perform principal validation in PQuotaRequests.r=dom-storage…

Aug 20 2026, 9:22 PM

hsingh added inline comments to D317838: Bug 2056884: Stop using .metadata-v2 files except for recovery. r=#dom-storage.

Aug 20 2026, 8:35 PM · testing-approved

Aug 19 2026

hsingh updated the uplift request field for D319938: Bug 2058964 - Enqueue all origins for cache flush on fresh storage.sqlite..

Aug 19 2026, 9:24 PM

hsingh created D319938: Bug 2058964 - Enqueue all origins for cache flush on fresh storage.sqlite..

Aug 19 2026, 9:24 PM

hsingh added inline comments to D304674: Bug 2043965: Write mStorageOrigin in StorageOperationBase::CreateDirectoryMetadata2. r=#dom-storage.

Aug 19 2026, 3:39 PM

hsingh accepted D304676: Bug 2043965 - Remove private browsing origin directories after LoadQuota. r=#dom-storage.

Aug 19 2026, 3:37 PM · needs-testing-tag

hsingh added a comment to D304676: Bug 2043965 - Remove private browsing origin directories after LoadQuota. r=#dom-storage.

I think this bug is about removing private directories which are not under private repository and this can be the case if we are migrating from the profile that has left-overs from the past i.e. time before private repository was introduced for private origins. I think we should fix the commit message and maybe add description too.

Aug 19 2026, 3:37 PM · needs-testing-tag

Aug 18 2026

hsingh added a comment to D304676: Bug 2043965 - Remove private browsing origin directories after LoadQuota. r=#dom-storage.

Private origin directories cleanup actually is about deleting the whole private directory rather than deleting individual private origins and I think it should be in there.
And I was reading related bug there and I think the origin and the storage origin should never be same for private origins. do we know why they were same in this bug?

Aug 18 2026, 8:27 PM · needs-testing-tag

Aug 17 2026

hsingh requested changes to D309339: Bug 2055756: Add marionette tests for dirty origin tracking and metadata flushing. r=#dom-storage.

Please evaluate if the AI review makes sense ?

Aug 17 2026, 8:38 PM

hsingh requested changes to D309338: Bug 2055756: Add mochitests for quota usage and persist operations. r=#dom-storage.

Please evaluate if the AI review makes sense ?

Aug 17 2026, 8:38 PM · needs-testing-tag

hsingh requested changes to D309337: Bug 2055756: Add gtests for DirectoryMetadataFlags and OriginCacheMap. r=#dom-storage.

Since this is a test patch stack. I have request AI review for this patch stack and I see there are some comments there. Please review those comments and see if they apply or not.
Changing it to "requesting changes" such that you can see these patches.

Aug 17 2026, 8:38 PM

hsingh accepted D311361: Bug 2053846 - Integrate lockstore into QuotaManager and wire all encryption paths. r=#dom-storage.

Aug 17 2026, 8:35 PM · needs-testing-tag

hsingh removed a reviewer for D311358: Bug 2053846 - Add KeyProvider/KeyPersister to CipherKeyManager for persistent mode. r=#dom-storage: dom-worker-reviewers.

Aug 17 2026, 8:31 PM · needs-testing-tag

hsingh accepted D311360: Bug 2053846 - Add LockstoreStorageKeyProvider implementing CipherKeyStoreBackend. r=#dom-storage.

Just a minor comment but otherwise, the changes looks good to me. Please also check if we should be having some assertions that this classes are for main process only.

Aug 17 2026, 8:28 PM · needs-testing-tag

hsingh accepted D311358: Bug 2053846 - Add KeyProvider/KeyPersister to CipherKeyManager for persistent mode. r=#dom-storage.

Aug 17 2026, 3:35 PM · needs-testing-tag