You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(spec): specify dns steering and the host_ip lane for spec 24 - #2851
Spec 24 scoped its first slice to own_ip and left "dns steering … and host_ip cohort handling" as later slices. This amendment specifies both, so the default dns steering works for own_ip and host_ip boxes on a VM host.
Why:
Architecture D6, Interaction with Network Modes: "host_ip — works, at the tier its chooser accepted" (T28).
Networking §5.4: steering = "dns" is the default in every mode. This amendment keeps that default and does not change the architecture.
Today a host_ip box with a GitHub grant is refused at creation: register_box_for_activation mints no box id for anything but own_ip (crates/minimal-client/src/box_registration.rs). dns is refused on every host until T116 — Carry dns-steered TLS to the proxy on port 443 #2805 lands (crates/boxes/src/core/bep.rs, the interim refusal).
ID
What it binds
BEP-080
Direct TLS to the proxy on TCP 443, routed by SNI; an absent or off-module SNI is refused off_module; the relay opens 443 at the proxy's address for a box with a lane (#2805)
BEP-081
A VM host admits dns and both for own_ip and host_ip boxes
BEP-082
A host_ip grant box gets a host-minted, creation-unique box id (Gatehouse §6.10 v1.24), and is not refused as unserved
BEP-083
The cohort address reaches the proxy's listener and TCP 443 at its address while a resident host_ip member declares a lane, and is dropped otherwise (NET-134 on the cohort, networking §4.3 rule 2)
BEP-084
A cohort connection is delivered cohort-attributed with no box id; redemption takes the egress re-check and the audit subject from the box the sealed value names (Gatehouse §6.10 steps 2–3); a value naming no live host_ip box is refused cohort_misattributed
BEP-085
One in-effect rule: own_ip, and host_ip on a VM host
BEP-086
Per-box
8000
dns steering for a host_ip box; every other process in the shared namespace resolves steered names from real DNS, so a box without a grant never needs the CA
BEP-087
Live proof: git clone, git push, gh api from a host_ip box under default steering with no proxy variables; a sub-requirement covers the proxy_env case
Security considerations gains a paragraph on the cohort lane and per-box steering, and BEP-083 and BEP-084 join the redemption and egress invariants. The SharedLinux non-goal is unchanged: native Linux host_ip still has no proxy.
spec-lint --repo-root . on the spec: 15 findings, all P004 (named tests not in the tree yet), the same finding the spec's existing e2e cases carry.
just lint-prose on the spec: the new prose paragraphs are clean. The remaining new alerts are on verify: lines, test names and EARS statements, the same classes as the file's 653 alerts on main.
BREAKING CHANGE: footer present if this is a breaking change (not one)
Summary by CodeRabbit
Documentation
Updated the egress proxy specification with rules for direct TLS routing by SNI and VM-hosted DNS or combined steering.
Added requirements for VM host_ip routing, including box identification, cohort access, delivery attribution, redemption checks, and per-box DNS responses.
Clarified credentialed upstream requirements by steering mode and host, and documented GitHub operation with default steering and no proxy variables.
Expanded security considerations and references for the new routing behaviors.
Add BEP-080 to BEP-087 so the default `dns` steering works for own_ip
and host_ip boxes on a VM host, as architecture D6 and networking §5.4
require.
- BEP-080, BEP-081: direct TLS to the proxy on port 443, routed by
SNI, and admitting dns and both on a VM host (#2805).
- BEP-082 to BEP-087: the host_ip lane: a host-side box id, the cohort
proxy lane, cohort-attributed delivery with the named box's egress
and audit subject, the in-effect rule, per-box steering, and the
live proof.
- BEP-015 gains a host_ip proxy_env case.
- Security considerations states the cohort lane and per-box steering.
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.
Walkthrough
The egress proxy specification adds requirements for direct TLS routing by SNI, VM-hosted steering modes, and the VM-hosted host_ip proxy lane, including access, attribution, DNS, and GitHub behavior.
Changes: Egress proxy specification
Layer / File(s)
Summary
Direct TLS routing and steering docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md
The specification adds SNI-based routing for direct TLS connections to the proxy and permits dns and both steering on VM hosts. It also updates the document date and cross-references the new requirements.
VM-hosted host_ip proxy lane docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md
The specification defines credentialed-upstream eligibility, creation-unique host-minted box IDs, cohort access conditions, and redemption attribution to a named live box. It also updates the security discussion and invariant coverage.
Per-box DNS and GitHub requirements docs/specs/24-spec-box-egress-proxy/24-spec-spec-box-egress-proxy.md
For eligible VM-hosted host_ip boxes, the specification defines proxy-address DNS answers and GitHub operations under default steering without proxy variables.
This is a documentation-only specification change with no runtime effect. The requirements are internally consistent, and the implementation will follow in later work, so merging carries no meaningful risk.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly identifies the main change: specifying DNS steering and the host_ip lane for Spec 24. It is concise, lower-case, and uses a valid Conventional Commit format.
Description check
The description includes the required Summary, Testing, and Checklist sections. It explains the changes, references related issues, records validation commands and findings, and marks the documentatio…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description includes the required Summary, Testing, and Checklist sections. It explains the changes, references related issues, records validation commands and findings, and marks the documentation and breaking-change checklist items.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
Vale (3.24.0)
{
"Line": 13,
"Path": ".vale.ini",
"Text": "Style 'ste' isn't on the StylesPath (/styles). If it's a package, run vale sync.",
"Code": "E201",
"Span": 23
}
A rabbit checks the proxy lane, And follows SNI through the rain. A host-minted ID marks the way, While DNS steers the names that day. GitHub calls pass without env, Then hops the rabbit home again.
CodeRabbit Verify
Run CodeRabbit Verify to test the changes in this pull request.
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:117: P004 BEP-003 names test 'bep_second_box_needs_no_sign_in', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:174: P004 BEP-007 names test 'bep_box_env_holds_sealed_value_only', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:218: P004 BEP-011 names test 'bep_root_ca_present_in_box_trust_store', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:234: P004 BEP-012 names test 'bep_proxy_env_and_no_proxy_are_set', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:290: P004 BEP-015 names test 'bep_git_and_gh_against_private_repo', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:341: P004 BEP-080 names test 'direct_tls_on_443_routes_by_sni', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:354: P004 BEP-081 names test 'vm_host_admits_dns_and_both_for_own_ip_and_host_ip', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:361: P004 BEP-082 names test 'host_ip_box_registration_mints_a_creation_unique_id', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:370: P004 BEP-083 names test 'host_ip_cohort_reaches_proxy_while_a_member_declares_a_lane', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:378: P004 BEP-084 names test 'cohort_delivery_names_no_box', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:392: P004 BEP-085 names test 'detail_pane_shows_a_host_ip_lane_in_effect_on_a_vm_host', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:397: P004 BEP-086 names test 'host_ip_grant_box_steered_names_resolve_to_proxy', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:406: P004 BEP-087 names test 'bep_host_ip_git_and_gh_under_dns_steering', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:718: P004 BEP-043 names test 'bep_destroyed_box_values_refused_within_60s', which was not found in the repository
docs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.md:727: P004 BEP-044 names test 'bep_logout_refuses_every_reference_at_next_request', which was not found in the repository
Advisory. None of this blocks the merge; the review decides.
Advisory, and never a merge gate. Linter: gominimal/foundry@fb5932b8, spec format: How Minimal Writes Specs.
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this with the foundry spec-review method: spec-lint on c7a9b4a gives only P004 (tests not yet in the tree), and the new IDs BEP-080 to BEP-087 do not collide. The PR's claims hold: register_box_for_activation returns no id for anything but own_ip, so proxy_box_facts refuses a host_ip grant box as NotServed; bep.rs carries the DnsWithoutDirectTls interim refusal; #2805 is the T116 task for BEP-080; and D6, design §5.4 and §4.3 rule 2, Gatehouse §6.10 v1.24 and NET-134 say what the comments cite. Non-blocking: BEP-083 admits the cohort only to the proxy's listener, but BEP-080 separates port 443 from the listener's port, so say that the cohort lane also covers 443, or BEP-087 under dns steering has no stated path. BEP-086's comment cites NET-079 for a per-box resolver, but that sub-requirement is native-only and deny-all-scoped; on a VM host it is NET-003's VM-backed sub-requirement (with NET-066). Also, BEP-087's second verify line runs proxy_env, which sets proxy variables and so cannot prove a requirement that says no proxy variables, and BEP-083/084/086 are in no Security considerations covered-by line (the redemption invariant lists BEP-028 but not BEP-084).
- BEP-083: the cohort lane also admits TCP 443 at the proxy's address,
the direct TLS path dns steering uses.
- BEP-084: refuse and audit a cohort-attributed value that names no
live host_ip box of this host.
- BEP-086: cite NET-003's VM-backed resolver requirement, not NET-079.
- BEP-087: the proxy_env case is its own sub-requirement.
- Security considerations: BEP-083 and BEP-084 join the redemption
invariant, and BEP-084 the egress invariant.
Port 443 for the cohort: BEP-083 admits the cohort address to the proxy's listener and to TCP 443 at its address.
Resolver citation: BEP-086's comment now cites NET-003's VM-backed sub-requirement (the node's DNS layer, forwarding under NET-066), not NET-079.
proxy_env verify: moved to its own sub-requirement under BEP-087.
Covered-by lines: BEP-083 and BEP-084 join the redemption invariant, and BEP-084 also joins the egress invariant. I left BEP-086 out on purpose. It decides which boxes are steered, a compatibility rule, and it holds no credential control. A lane-less box that BEP-086 failed to keep unsteered still reaches nothing it couldn't reach already: it holds no CA and no sealed value.
BEP-084 also gains a refusal clause for a cohort-attributed value that names no live host_ip box, from the minimal-review finding. The plan on #1501 and its issues #2854 and #2855 are updated to match.
* fix(deps): bump pulldown-cmark to 0.13.6 for RUSTSEC-2026-0433 (#2846)
Claude-Session: https://claude.ai/code/session_01NSAwDroXL6KqsSxUzdbZGw
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(minimald): hand a reaped name over in one manager step (#2842)
A reap read the records and then sent the handover as a second message.
A removal that began between the two left the name with no row while
another retained box still had it. The manager now releases the reaped
box's row, picks the successor among boxes not being removed, and
registers it in one message. The reap and the prune return after both.
The daemon log names the release (name-released) before the handover
(name-handed-over), both with box ids.
Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
* T126 — A host-address box's port that collides on the host is shown at session start and in `min ls` (#2830)
* feat(minvmd): answer a node's collided mirror ports over control
The host control socket answers a read-only mirror_collisions verb
with the node's mirrored ports that collided with a holder on the
host. The node mirror keeps the time each port first collided.
* feat(minimal): show collided mirror ports in min ls and activate
min ls prints a MIRROR PORTS row per VM whose host_ip box ports are
held by another program on the host, and --json carries
mirror_collisions per VM. min session activate of a host_ip box on a
VM host prints the same sentence per port when it does not attach.
* fix(minimal): show an unread VM's mirror ports as null in min ls
Read each VM's collided mirror ports concurrently, and keep a failed
read apart from an empty one: --json writes null for a VM with no
answer and [] only for an answered empty read.
* fix(minimal): name a VM host whose mirror ports were not read
min ls printed nothing for a running VM host that gave no answer, so
it looked the same as one with no collisions. It now prints one
MIRROR PORTS row that says the VM did not report its ports.
* fix(minimal): skip the mirror-port read on a native host
A native host has no VM host daemon. The fallback listing's control
socket there is minimald's, which does not serve the collided-port
read, so min ls printed a false MIRROR PORTS row on every native host.
* fix(minimal): name an unread VM host at activate, enter the span
min session activate now prints the unread sentence that min ls prints
when the VM host daemon gives no answer. The ListSessions span wraps the
collided-port reads, and a native host's --json carries no
mirror_collisions field.
---------
Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
* T42 — Start every box's entrypoint from its spec through one launcher (#2841)
* feat(mfile): carry entrypoint and lifetime in the box spec
The spec gains an [execution] table with the box's lifetime and, for a
box that does not run its login shell, its entrypoint argv. A v0 spec
stored before the table existed reads with the entrypoint its type
implies.
* feat(minimald): start each box's entrypoint from its spec
One launcher decision, LaunchSpec::entrypoint, reads the first process
from the box's stored spec: the login shell, or the spec's argv. The
actor reads the stored spec once, keeps its hold, and hands it to every
launcher. A launch minted for an exec keeps the shell, because the exec
runs the box's command. Each launch logs its entrypoint in a
box.launch span.
* fix(minimald): keep the shell on every launch of an exec-run box
A task's run arrives over the exec channel. A hook launch or an attach
can come before or after that exec, and a hook launch's gated first
process starts at the next attach. Only the exec-minted launch held
the shell, so a task box could run its task twice, and an attach got
the task, not a shell. Every launch now says an exec carries the run,
and the launcher starts the shell for it.
* refactor(mfile): write box.lifetime and execution.exec in the spec
Rename Lifetime::Persistent to UntilStopped, move the lifetime to
[box] with a until_complete default for v0 specs, and serialize the
entrypoint as execution.exec. List the argv shape as a v0 exception.
* fix(minimald): refuse a launch whose stored spec cannot be read
held_spec returns an error for unreadable spec bytes or a failed store
read, and launch_host refuses with SpawnFailed instead of starting the
shell. Mark run_by_exec as an interim that T43 (#2405) removes.
* test(minimald): store a readable spec in the stopped-box record test
A launch now refuses a stored spec it cannot read, so the test's
placeholder bytes failed its ensure_host. Store a session spec instead.
* docs(mfile): say that no launch reads the spec's lifetime yet
A box ends when its entrypoint returns, whatever box.lifetime says.
* fix(minimald): keep entrypoint arguments out of the launch log
The box.launch span and its info event printed every argument of an
argv entrypoint. An argument can carry a secret, so they now name the
program (or the login shell) and the argument count only. A test pins
that a secret-looking argument does not reach the log.
---------
Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
Co-authored-by: Karl Godard <karl@minimal.dev>
* T30 — Run a command in a box with a terminal or detached, under an exec id (#2843)
* feat(minimald-rpc): carry exec mode, timeout and exec id on the wire
min://exec carries an argv with its mode (attached, tty or detached) and
an optional timeout. min://exec/attach, min://exec/output and
min://exec/wait name an exec by its UUIDv7 id. The box store places
each exec's transcript beside the record and appends events by path.
* feat(minimald): run box execs under an id, with a terminal or detached
Every command for a box gets a UUIDv7 exec id, and a box that is not
running refuses it with exit 2 naming its state. min://exec runs an
argv with no shell: attached, on a daemon terminal, or detached with
stdin closed. Tty and detached execs answer with their id at once,
capture their output beside the box record, and keep their exit for
min://exec/wait. An exec's own timeout stops it and records an
exec_exited event with reason timeout, and the box keeps running.
* style(minimald-rpc): format the exec id parse and its tests
* fix(minimald): bound the wait after an exec timeout; drop reaped execs
A command that survives the stop at its timeout no longer holds its
wait open: the wait after the stop is bounded, then SIGKILLed and
recorded as a timeout. Ended execs of a reaped box leave the exec map.
* fix(minimald): exit 124 on exec timeout; wait reads stored exit
An exec that its own timeout ends now exits 124, attached or detached.
A wait on an exec that this daemon holds no entry for reads the box's
stored exec_exited event, so a detached exec's exit code outlives a
daemon restart.
* fix(minimald): cap exec transcripts at 8 MiB and stream reads
A detached exec now writes through a pipe and a pump, as a tty exec
does, so the daemon can cap its transcript. Past the cap the transcript
keeps a mark and the newest half of the cap, and the command keeps
running. The output read and the attach replay copy the transcript in
64 KiB chunks, up to its length at the open, and the attach takes the
terminal lock only to open the file and subscribe.
* fix(minimald): bound tty exec input; no deadline past the clock
A tty exec's terminal input went through an unbounded channel, so a
program that never reads stdin let the daemon queue grow without
limit. The terminal now holds typed input in a HeldInput with the
attached path's bounds (EXEC_INPUT_HELD_MAX per exec,
EXEC_INPUT_HELD_DAEMON_MAX for the daemon). Past either bound the
chunk is dropped and the log says so once per exec. The exec's end
releases what it held.
An attached exec's timeout too large for the clock panicked after the
spawn. timeout_deadline now uses checked_add and gives no deadline.
Tests: unread tty input stays within the cap, a timeout of u64::MAX
seconds runs the exec to its end, and an exec id from one box finds no
exec, output or exit in another.
* fix(minimald): wait on exec terminals in the runtime, not a thread
The tty feed wrote to the terminal from a blocking thread. When the
program never read its input, that write never returned, and each such
exec left a blocking thread behind for good. The terminal and the
detached pipe are now non-blocking and watched through AsyncFd, so the
supervisor can stop the pump and the feed at the exec's end. Both stop
on a closed state too, because tokio never clears it and a wait for it
returns at once.
---------
Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
Co-authored-by: Karl Godard <karl@minimal.dev>
* fix(minimald): hand a destroyed box's name to the next holder (#2849)
A destroy removed the box that held a name's row and left the name
with no row, while another retained box still had that name. The
destroy now runs the same handover as a reap: the row goes to the
running box with the name, else to the most recent creation. The
destroy answers after the handover.
The daemon log names the destroyed box and the successor, and the
destroy span records the successor id or "none".
Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
* T114 — `min ls` and the box commands tell the truth, end to end (#2839)
* test(e2e): prove min ls and the box commands across two VMs
Adds the ls_and_box_commands_tell_the_truth case: a stopped VM's boxes
in min ls, the ADDRESS and EGRESS cells against min session policy,
policy and forward without --vm, the unknown-box and stopped-VM
refusals, both proxy ports after the preferred port frees, and the
--public and out-of-range expose refusals.
* test(e2e): record ls_and_box gates as NOT RUN, check declared rules
The four gates of ls_and_box_commands_tell_the_truth now call not_run,
so the lane summary names the case. A 'declared rules' EGRESS cell is
now checked against the subnets rule row that min session policy
prints, not only against an egress heading.
* test(e2e): read the expose address past a trailing carriage return
The ls_and_box case read the box's address from the in-box expose reply
with an end-of-line anchor. A reply over the exec channel can end in a
carriage return, which left the address empty.
* test(e2e): brace lt_port before a bracket class in the expose read
shellcheck reads $lt_port[[:space:]] as an array index (SC1087).
The braces keep the same match and make the script lint-clean again.
* fix(minimal): poll the owning VM in min net forward
A forward to a box on another VM polled the selected VM for its
session. That VM does not hold the box, so the forward closed on the
first tick. Reconnect the poll to the owning VM, version-gated.
---------
Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
Co-authored-by: Norrie Taylor <91171431+norrietaylor@users.noreply.github.com>
* docs(spec): specify dns steering and the host_ip lane for spec 24 (#2851)
* docs(spec): specify dns steering and the host_ip lane for spec 24
Add BEP-080 to BEP-087 so the default `dns` steering works for own_ip
and host_ip boxes on a VM host, as architecture D6 and networking §5.4
require.
- BEP-080, BEP-081: direct TLS to the proxy on port 443, routed by
SNI, and admitting dns and both on a VM host (#2805).
- BEP-082 to BEP-087: the host_ip lane: a host-side box id, the cohort
proxy lane, cohort-attributed delivery with the named box's egress
and audit subject, the in-effect rule, per-box steering, and the
live proof.
- BEP-015 gains a host_ip proxy_env case.
- Security considerations states the cohort lane and per-box steering.
* docs(spec): keep the first slice paragraph unchanged and move the host_ip e2e checks to BEP-087
* docs(spec): address review on the host_ip lane requirements
- BEP-083: the cohort lane also admits TCP 443 at the proxy's address,
the direct TLS path dns steering uses.
- BEP-084: refuse and audit a cohort-attributed value that names no
live host_ip box of this host.
- BEP-086: cite NET-003's VM-backed resolver requirement, not NET-079.
- BEP-087: the proxy_env case is its own sub-requirement.
- Security considerations: BEP-083 and BEP-084 join the redemption
invariant, and BEP-084 the egress invariant.
* T10 — Log a box's output from its start, out of the box's reach (#2852)
* feat(boxes): name a box's output log beside its record
Adds LOG_FILE and BoxDir, the box's directory as code outside the store
sees it: the log path, a lookup by id through the index, a log read by
offset, and an event append for a writer that holds no DiskBox.
* feat(minimald-rpc): add a streamed read of a box's output log
* feat(minimald): log a box's output from its start
The host appends every read from the box's terminal to its output log
before it hands the bytes to an attached client, so the client is a
second reader. A binding whose client closes its channel, drops its
connection or is shed records a detached event, and the box runs on.
* feat(minimald): serve a box's output log by its id
ReadLog streams the log from a byte offset, and with follow sends new
output until the box is reaped. A test shows that files written into
the box's own directories reach neither the log nor the record.
* fix(minimald): read a box's log on the blocking pool
The followed log read polled the store with blocking std::fs calls on an
async task. The find, the chunk reads and the retained check now run
through spawn_blocking, so a slow disk does not hold a runtime worker.
* fix(boxes): cap a box's output log and read it across a drop
The log keeps a drop mark and the newest half past 8 MiB. A reader
keeps its file open and moves to the replaced file with no byte sent
twice. The read refuses a link or a file that is not regular.
* fix(minimald): start no store box without its output log
BoxOutputLog::open returns the open's error for a box in the store, and
Host::build stops before the launch. The log writes through the capped
store writer, and ReadLog keeps one reader for the whole stream.
* fix(minimald): run detach hooks when a PTY client is lost
A lost client already records a detached event. Its on_detach hooks now
run too, so the event and the hooks agree. A test drives a box past the
log cap.
* style: format the log cap tests
* docs(boxes): mark the 8 MiB log cap as not yet in the design
The cap drops the start of a box's output past 8 MiB. That departs from
architecture.md line 473. gominimal/arch#159 decides the bound.
* docs(specs): record the interim 8 MiB box log cap in BOX
The decision that logs a box's output from its start now states the
8 MiB cap, what the log keeps past it, and the arch#159 decision that
removes the cap or changes BOX-155.
---------
Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
* T9 — End a box when its entrypoint returns, never for idleness or client loss (#2850)
* feat(minimald): end an until_complete box when its entrypoint returns
The host loop now says whether a kill ended it. The actor watches each
launch's loop and, when the entrypoint returned on its own and the spec
sets lifetime = "until_complete", sets the record to exited with the
exit code and records an exited event with reason "exit". The daemon
does this whether or not a client is attached. Such a box raises no
shell-exit prompt (BOX-038). A client that goes away never stops a box
(BOX-015).
* test(minimald): pin box ends on entrypoint return, not client loss
Adds the actor tests for BOX-038 and BOX-015. The shell round trip now
expects no prompt and an exited record. Tests about a box kept after its
shell exits now create an until_stopped box. The rpc shutdown test no
longer answers a prompt.
* fix(minimald): retry the exited-record write when an entrypoint ends
The host and the watch are gone by the time the write runs, so a
single failed write left the box running with nothing in it. Retry it
with a short backoff, and pin the retry with a test seam.
* test(e2e): expect an exited box, not a prompt, when a shell exits
The session-exit prompt is gone: exiting the shell ends the box, which
stays listed as exited. The pty driver no longer answers a prompt. Each
leg that exited a shell now checks the box is exited with code 0, and
destroys it where it used to answer Delete.
* docs(minimald): put the launch-record seam doc back on its module
* test(e2e): resume the exited kept box before the exec into it
An exec runs only in a running box. After the shell exits and the row is
withdrawn, the leg now resumes the box with a pty 'min session attach',
checks that it runs under the same id and that its row is back, and then
runs the exec as before.
* test(minimald): fail when the channel stays open after shell exit
The wait loop ended on a timeout as well as on close, so the test
passed even if the channel never closed. Panic on the timeout.
* fix(minimald): end an exited box before a queued attach or exec
A message queued beside a returned entrypoint ran first and launched
a new host, so the entrypoint ran again and its exit was lost. Now
only a stop or a destroy goes ahead of the exit, and ensure_host
refuses a stopped or exited box.
---------
Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
* build(deps): bump sysinfo to 0.40
sysinfo 0.40 makes System construction fallible (System::new returns
Result<System, sysinfo::Error>). The three callers keep their 0.39
behaviour on an unsupported platform: minvmd's metrics sample and
minimald's resource-pool probe return None, and minvmd's host capacity
probe reports zero memory.
Unblocks the dependabot cargo group (#2844), which bumped sysinfo
without migrating the callers.
---------
Co-authored-by: Karl Godard <karl@minimal.dev>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: minimal-foundry[bot] <327719912+minimal-foundry[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spec 24 scoped its first slice to
own_ipand left "dnssteering … andhost_ipcohort handling" as later slices. This amendment specifies both, so the defaultdnssteering works forown_ipandhost_ipboxes on a VM host.Why:
host_ip— works, at the tier its chooser accepted" (T28).steering = "dns"is the default in every mode. This amendment keeps that default and does not change the architecture.host_ipbox with a GitHub grant is refused at creation:register_box_for_activationmints no box id for anything butown_ip(crates/minimal-client/src/box_registration.rs).dnsis refused on every host until T116 — Carry dns-steered TLS to the proxy on port 443 #2805 lands (crates/boxes/src/core/bep.rs, the interim refusal).off_module; the relay opens 443 at the proxy's address for a box with a lane (#2805)dnsandbothforown_ipandhost_ipboxeshost_ipgrant box gets a host-minted, creation-unique box id (Gatehouse §6.10 v1.24), and is not refused as unservedhost_ipmember declares a lane, and is dropped otherwise (NET-134 on the cohort, networking §4.3 rule 2)host_ipbox is refusedcohort_misattributedown_ip, andhost_ipon a VM host8000 dnssteering for ahost_ipbox; every other process in the shared namespace resolves steered names from real DNS, so a box without a grant never needs the CAgit clone,git push,gh apifrom ahost_ipbox under default steering with no proxy variables; a sub-requirement covers theproxy_envcaseSecurity considerations gains a paragraph on the cohort lane and per-box steering, and BEP-083 and BEP-084 join the redemption and egress invariants. The SharedLinux non-goal is unchanged: native Linux
host_ipstill has no proxy.Refs: #1501, #2805, #2787
The plan on #1501 now carries this work as T116 (#2805) and slice S17 (#2853, tasks #2854–#2858).
Testing
spec-lint --repo-root .on the spec: 15 findings, all P004 (named tests not in the tree yet), the same finding the spec's existing e2e cases carry.just lint-proseon the spec: the new prose paragraphs are clean. The remaining new alerts are onverify:lines, test names and EARS statements, the same classes as the file's 653 alerts onmain.plan-linton the Local box egress proxy — sealed GitHub credentials and host-store secrets without Gatehouse #1501 plan against this head: the new slice and tasks raise no finding.Checklist
BREAKING CHANGE:footer present if this is a breaking change (not one)Summary by CodeRabbit
host_iprouting, including box identification, cohort access, delivery attribution, redemption checks, and per-box DNS responses.