8000 T120 — Treat the proxy lane as in effect for a host-address box on a VM host · Issue #2856 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

T120 — Treat the proxy lane as in effect for a host-address box on a VM host #2856

Closed

Description

@norrietaylor

Task

slice size difficulty model who estimated lines
Host-address boxes reach GitHub M routine standard an agent 340 (140 code, 200 tests)

On a Mac, a host-address grant box with steering = "proxy_env" gets the proxy variables, and min session policy shows its credentialed-upstream row with no not-in-effect mark.

Covers:

  • BEP-085

Layers:

  • rule:
    • crates/boxes/src/lib.rs: CredentialedUpstream::in_effect takes the host kind with the network mode, and is true for own_ip and for host_ip on a VM host
    • cargo nextest run -p boxes credentialed_upstream_in_effect_by_mode_and_host
  • runtime:
    • crates/minimald/src/box_runtime.rs: launch_proxy_env reads the new rule, so a host_ip box on a VM host with proxy_env or both steering gets HTTPS_PROXY, HTTP_PROXY, NO_PROXY and NODE_USE_ENV_PROXY
    • crates/minimald/src/box_runtime/tests.rs: the test that a host_ip box on a VM host gets the four variables, and one on a native host gets none
    • cargo nextest run -p minimald host_ip_box_on_vm_host_gets_the_proxy_variables
  • surfaces:
    • crates/minimal/src/cmd/boxes/policy.rs: the policy row reads the new rule
    • crates/minimal/tests/dash_snapshots.rs: a snapshot pins the detail pane of a host_ip lane in effect on a VM host
    • crates/minimal/src/cli.rs: the --credentialed-upstream help ends "Takes effect with --network own_ip, and with --network host_ip on a host that runs boxes in a VM." in place of "Takes effect only with --network own_ip."
    • cargo nextest run -p minimal detail_pane_shows_a_host_ip_lane_in_effect_on_a_vm_host

Waits on:

Plan block
### T120 — Treat the proxy lane as in effect for a host-address box on a VM host
  slice: S17
  kind: task
  covers: BEP-085
  size: M
  est: 140 code, 200 tests
  executor: agent
  difficulty: routine
  model: standard
  diagnostics: `min session policy <box>` and the `min dash` detail pane show the credentialed-upstream row of a `host_ip` box on a VM host without the "(not in effect: host_ip box)" mark, and a `host_ip` box on a native Linux host keeps it
  observability: the launch's existing debug line for the proxy variables names the box's network mode, the host kind and whether the lane is in effect, so a `host_ip` box that got no proxy variables shows why
  layers:
    - rule:
      - crates/boxes/src/lib.rs: `CredentialedUpstream::in_effect` takes the host kind with the network mode, and is true for `own_ip` and for `host_ip` on a VM host
      test: cargo nextest run -p boxes credentialed_upstream_in_effect_by_mode_and_host
    - runtime:
      - crates/minimald/src/box_runtime.rs: `launch_proxy_env` reads the new rule, so a `host_ip` box on a VM host with `proxy_env` or `both` steering gets `HTTPS_PROXY`, `HTTP_PROXY`, `NO_PROXY` and `NODE_USE_ENV_PROXY`
      - crates/minimald/src/box_runtime/tests.rs: the test that a `host_ip` box on a VM host gets the four variables, and one on a native host gets none
      test: cargo nextest run -p minimald host_ip_box_on_vm_host_gets_the_proxy_variables
    - surfaces:
      - crates/minimal/src/cmd/boxes/policy.rs: the policy row reads the new rule
      - crates/minimal/tests/dash_snapshots.rs: a snapshot pins the detail pane of a `host_ip` lane in effect on a VM host
      - crates/minimal/src/cli.rs: the `--credentialed-upstream` help ends "Takes effect with `--network own_ip`, and with `--network host_ip` on a host that runs boxes in a VM." in place of "Takes effect only with `--network own_ip`."
      test: cargo nextest run -p minimal detail_pane_shows_a_host_ip_lane_in_effect_on_a_vm_host
  produces:
    - the in-effect rule for a host-address lane
  consumes: none
  proof: On a Mac, a host-address grant box with `steering = "proxy_env"` gets the proxy variables, and `min session policy` shows its credentialed-upstream row with no not-in-effect mark.
  depends on:
    - blocked by #2854

Activity

  1. added
    kind:taskA task the plan skill rendered; the body carries ## Task
    size:M200 to 500 net lines; one PR
    model:standardA standard model: work that needs care, or routine work that is large
    on Nov 2, 2026
  2. minimal-foundry commented on Nov 4, 2026

    @minimal-foundry
    Contributor

    Done. #3025 merged.

    branch agent/2856-treat-the-proxy-lane-as-in-effect-for-a-host-add · epic #1501 · PR #3025

    round outcome job
    1 pushed 97282766

    Updated 2026-11-05T04:42:31.781Z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:taskA task the plan skill rendered; the body carries ## Taskmodel:standardA standard model: work that needs care, or routine work that is largesize:M200 to 500 net lines; one PR

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0