8000 ADded claude skill for code review by subkanthi · Pull Request #1563 · Altinity/clickhouse-sink-connector · GitHub
[go: up one dir, main page]

Skip to content

ADded claude skill for code review - #1563

Merged
minguyen9988 merged 3 commits into
2.11.0from
add_code_review_skill
Oct 10, 2026
Merged

minguyen9988 merged 3 commits into
2.11.0from
add_code_review_skill

Conversation

@subkanthi
@subkanthi subkanthi commented Oct 9, 2026 •
Copy link
Copy Markdown
Collaborator

Added claude skill for code review.

Claude Code discovers a project skill only at .claude/skills/<name>/SKILL.md; a SKILL.md directly under .claude/skills is never loaded. The directory name matches the skill's name field. No content change.

This push also re-runs CI: the earlier build-kafka-lightweight failure was a transient Docker Hub error (auth.docker.io returned 500 while pulling debezium/connect-base:1.9.5.Final), not a problem in this PR.
minguyen9988 added a commit that referenced this pull request Oct 10, 2026
… checks (Spec 11.06 section 2) (#1568)

The workflow ran scripts/review_gates.py and its tests from the PR head. A branch cut before the checks existed has neither, so every such PR failed with ImportError: Start directory is not importable: scripts/tests (seen on #1561 and #1563). The workflow now takes the script and its self-tests from origin/<base>, runs them from the runner temp directory against the PR head, and reports a notice when the base has no script. It also means a PR cannot weaken the checks that judge it; a PR's own copy of the tests still runs in spec-governance.

Emulated locally: the base copy's 34 self-tests pass from outside the repo, and the checks report 0 findings on the #1561 and #1563 heads.

Jinja-Render-Check: rendered=1; formats=yaml; result=pass

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The Review gates job failed on this branch because the workflow ran the check script from the PR head, which predates it; #1568 makes it use the base branch copy. No content change.
@minguyen9988 minguyen9988 left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minguyen9988
minguyen9988 merged commit b6cad03 into 2.11.0 Oct 10, 2026
5 checks passed
@minguyen9988
minguyen9988 deleted the add_code_review_skill branch October 10, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0