Repository navigation
Add THIRD_PARTY_NOTICES.md - #1561
Merged
Merged
Conversation
subkanthi
approved these changes
Oct 9, 2026
Collaborator
|
CI status on this PR, and what was done:
|
minguyen9988
added a commit
that referenced
this pull request
Oct 10, 2026
com.google.protobuf:protobuf-java:3.19.6 (BSD-3-Clause) is a compile-scope dependency of io.debezium:debezium-connector-postgres 3.1.3.Final. sink-connector-lightweight/pom.xml neither excludes it nor filters it out of the shaded JAR, so it ships in the lightweight connector JAR. The 2.10.3 notice in #1561 lists it; the notice regenerated for 2.11.0 in #1560 does not. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
#1564 added the protobuf-java row to the 2.11.0 notice, which re-created the add/add conflict with this branch. The file here is now identical to the 2.11.0 version, so the PR merges cleanly.
minguyen9988
added a commit
that referenced
this pull request
Oct 10, 2026
… checks (Spec 11.06 section 2) (#1568) The workflow ran scripts/review_gates.py and its tests from the PR head. A branch cut before the checks existed has neither, so every such PR failed with ImportError: Start directory is not importable: scripts/tests (seen on #1561 and #1563). The workflow now takes the script and its self-tests from origin/<base>, runs them from the runner temp directory against the PR head, and reports a notice when the base has no script. It also means a PR cannot weaken the checks that judge it; a PR's own copy of the tests still runs in spec-governance. Emulated locally: the base copy's 34 self-tests pass from outside the repo, and the checks report 0 findings on the #1561 and #1563 heads. Jinja-Render-Check: rendered=1; formats=yaml; result=pass Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The Review gates job failed on this branch because the workflow ran the check script from the PR head, which predates it; #1568 makes it use the base branch copy. No content change.
minguyen9988
added a commit
that referenced
this pull request
Oct 10, 2026
… the PR head (Spec 11.01 section 3.7) (#1569) The job checked out pull_request.head.sha. A branch cut before formal_specs/ existed has no lean-toolchain, so lake build failed with no default toolchain configured, and the job validated a tree that is not what merges (#1561 is such a branch). It now checks out github.sha, the synthetic merge commit of the PR head into the current base, i.e. the tree that would land. The [spec-exempt: ...] marker keeps working: validate_specs.py already searches every commit message in BASE..HEAD, and the merge commit's second parent is the contributor's head. Push events are unchanged (github.sha is the pushed commit). Jinja-Render-Check: rendered=1; formats=yaml; result=pass Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lean proofs and spec validator failed here because the job checked out this branch's head, which predates formal_specs/; #1569 makes it validate the merge commit with 2.11.0. No content change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.