Repository navigation
fix(ci): run the base branch copy of the review checks, so older branches pass (#1561, #1563) - #1568
Merged
Merged
Conversation
… checks (Spec 11.06 section 2) The workflow ran scripts/review_gates.py and its tests from the PR head. A branch cut before the checks existed has neither, so every such PR failed with ImportError: Start directory is not importable: scripts/tests (seen on #1561 and #1563). The workflow now takes the script and its self-tests from origin/<base>, runs them from the runner temp directory against the PR head, and reports a notice when the base has no script. It also means a PR cannot weaken the checks that judge it; a PR's own copy of the tests still runs in spec-governance. Emulated locally: the base copy's 34 self-tests pass from outside the repo, and the checks report 0 findings on the #1561 and #1563 heads. Jinja-Render-Check: rendered=1; formats=yaml; result=pass Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
minguyen9988
added a commit
that referenced
this pull request
Oct 10, 2026
The Review gates job failed on this branch because the workflow ran the check script from the PR head, which predates it; #1568 makes it use the base branch copy. No content change.
minguyen9988
added a commit
that referenced
this pull request
Oct 10, 2026
The Review gates job failed on this branch because the workflow ran the check script from the PR head, which predates it; #1568 makes it use the base branch copy. No content change.
minguyen9988
added a commit
that referenced
this pull request
Oct 10, 2026
* ADded claude skill for code review * Move the review skill to .claude/skills/clickhouse-sink-review/SKILL.md Claude Code discovers a project skill only at .claude/skills/<name>/SKILL.md; a SKILL.md directly under .claude/skills is never loaded. The directory name matches the skill's name field. No content change. This push also re-runs CI: the earlier build-kafka-lightweight failure was a transient Docker Hub error (auth.docker.io returned 500 while pulling debezium/connect-base:1.9.5.Final), not a problem in this PR. * ci: re-run checks after #1568 The Review gates job failed on this branch because the workflow ran the check script from the PR head, which predates it; #1568 makes it use the base branch copy. No content change. --------- Co-authored-by: minguyen9988 <136291932+minguyen9988@users.noreply.github.com>
minguyen9988
added a commit
that referenced
this pull request
Oct 10, 2026
* Add THIRD_PARTY_NOTICES.md * THIRD_PARTY_NOTICES.md: align with the notice regenerated for 2.11.0 (#1560) This branch and #1560 both add THIRD_PARTY_NOTICES.md, so the PR cannot merge into 2.11.0 (add/add conflict). Take the 2.11.0 version as the base of this PR; the next commit adds the one runtime component this branch listed that the 2.11.0 notice lacks. * THIRD_PARTY_NOTICES.md: align with 2.11.0 again after #1564 #1564 added the protobuf-java row to the 2.11.0 notice, which re-created the add/add conflict with this branch. The file here is now identical to the 2.11.0 version, so the PR merges cleanly. * ci: re-run checks after #1568 The Review gates job failed on this branch because the workflow ran the check script from the PR head, which predates it; #1568 makes it use the base branch copy. No content change. * ci: re-run checks after #1569 Lean proofs and spec validator failed here because the job checked out this branch's head, which predates formal_specs/; #1569 makes it validate the merge commit with 2.11.0. No content change. --------- Co-authored-by: minguyen9988 <136291932+minguyen9988@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Review check failing on #1561 and #1563.
The workflow ran the check script and its self-tests from the PR head. A branch cut before the script existed has neither file, so the job failed with ImportError: Start directory is not importable: scripts/tests. Both #1561 and #1563 were branched before #1565.
The workflow now:
It also means a PR cannot weaken the checks that judge it. A PR that changes the checks still runs its own copy of the tests in the spec-governance job. Spec 11.06 and the docs are updated to match.
Whole-Change-Verification: ran=the workflow steps emulated locally (the base copy of the 34 self-tests passes from outside the repo; the base copy reports 0 findings on the #1561 head ade6549 and the #1563 head 91899f9), YAML lint of the workflow, and python3 scripts/validate_specs.py --changed-base on be84678 (84 specs, PASSED); result=pass
Created on behalf of the team that co-maintains this connector; maintainers own the merge.
Generated with Claude Code (https://claude.com/claude-code)