Repository navigation
chore(review): code-review skills and deterministic PR checks (Spec 11.06) - #1565
Merged
Merged
Conversation
…c 11.06)
Adds the review methodology and a CI gate so contributors and agents review PRs the same way:
- .claude/skills/: pr-self-review (five review gates: contract, impacted surface, failure and divergence, evidence, lower-priority quality) with a project-specific checklist; code-quality-{jvm,python,go,bash,sql,architecture}; code-reuse-review, code-reuse-first, design-note-debt, mandatory-code-change-validation, destructive-operation-safety, repro-harness-negative-proof and sink-connector-mysql-source-of-truth. Index in .claude/skills/README.md, pointer in AGENTS.md.
- scripts/review_gates.py: stdlib-only checks over the lines a PR adds. destructive: every DROP/TRUNCATE/DELETE/DETACH/rm -rf site needs a DESTRUCTIVE: comment and a matching Destructive-Op-Check commit trailer. merge-stop: no code may stop or pause ClickHouse merges. license: no Category X dependency at a runtime scope, and every new runtime dependency is in THIRD_PARTY_NOTICES.md. hygiene: conflict markers, swallowed exceptions, debugger leftovers, credentials, YAML/JSON syntax. Exit 0/1/2.
- scripts/tests/test_review_gates.py (25 offline tests), .github/workflows/review-gates.yml, doc/review_gates.md, specs/11-verification-tooling/06-review-gates.md.
Jinja-Render-Check: rendered=1; formats=yaml; result=pass
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a shared code-review method for this repository, for humans and agents, plus a CI check that enforces the parts a machine can prove.
Review skills under .claude/skills (index in .claude/skills/README.md, pointer in AGENTS.md):
A new stdlib-only check script under scripts/ runs over the lines a PR adds (base...head):
A new workflow under .github/workflows runs the check on every pull request. Its self-tests also run in the existing spec-governance job through unittest discover. Usage is documented in a new page under doc/, and the check is specified by the new Spec 11.06 in specs/11-verification-tooling.
Calibration: run over the whole 2.11.0 line (3c0759b..7f3102d, 139 commits), the check reports 6 destructive sites without a warning comment (the PostgreSQL DROP COLUMN translation, one log line and one operator hint) and nothing else. Grammars (.g4), Lean proofs, tests and prose are exempt, because they quote destructive statements without executing them. Best-effort cleanup that ignores OSError is allowed.
This complements #1563, a reviewer skill for PRs, which lives at .claude/skills/SKILL.md and does not conflict with these files.
Whole-Change-Verification: ran=python3 -m unittest discover -s scripts/tests (82 tests: 25 new, the rest the existing validator self-tests; 4 skipped), python3 scripts/validate_specs.py --changed-base on 7f3102d (84 specs, 1239 citations, PASSED), the new check script on this branch (0 findings), YAML lint of the new workflow, and frontmatter parse of all 14 SKILL.md files; result=pass
Created on behalf of the team that co-maintains this connector; maintainers own the merge.
Generated with Claude Code (https://claude.com/claude-code)