Repository navigation
fix(tempo): update admin access keys for TIP-1137 [0.x] - #555
Merged
Merged
Conversation
The organization now allows only actions owned by wevm or GitHub, which fails every job that sets up foundry from foundry-rs/foundry-toolchain. Matches main (#549). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3nmWiYLFXfCPHgz9FSm6L
Port of #554 to 0.x. TIP-1137 removes TIP-1049 admin access keys at T14. The wire encoding is unchanged, so KeyAuthorization keeps encoding and decoding `isAdmin` and `account` for pre-T14 history; `isAdmin` is now deprecated in its TSDoc. The edge e2e test that registered an admin key now asserts the T14 node rejects it, and a new test covers an account-bound non-admin grant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3nmWfJBrmCTSK7UpdbX4K
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jxom
marked this pull request as ready for review
November 1, 2026 09:08
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #554 to
0.x.TIP-1137 (tempoxyz/tempo#8204) removes TIP-1049 admin access keys at T14. The
edgeimage runs T14, soTIP-1049 admin access key round-trips through registrationfails there withkeychain precompile error: Account keychain error: InvalidKeyId. On tempomain,authorize_admin_keyreturnsInvalidKeyIdfrom T14.The TIP keeps the
is_adminandaccountRLP fields unchanged, and the node still decodes them. ox therefore keeps encode, decode and hash support for pre-T14 history, andInvalidAdminMarkerErrorstays. Runtime behavior does not change.Changes
KeyAuthorization.ts: TSDoc changes only.isAdminis now@deprecatedin the domain and RPC types, with a link to TIP-1137. Theaccountdocs, in both the primitive and configurable union arms, say that when it is present it must equal the transaction sender. TheMissingAccountErrordeprecation note and the wire comments are updated to match.KeyAuthorization.test.ts: the codec tests are renamedhistorical admin keys (TIP-1049). Assertions are unchanged.e2e.test.ts:TIP-1137 rejects an admin key authorization, which sends the same transaction and expectsInvalidKeyId..github/actions/install-dependencies/action.yml: cherry-picked 8dab934 from exp: attested signers (TIP-1159) [0.x] #553. Foundry and pnpm now come from the vendoredwevm/actions, because the org's actions policy blocksfoundry-rs/foundry-toolchainand every 0.x job fails at setup without this change.0.xhas no Admin Access Keys guide page, so the site edits from fix(tempo): update admin access keys for TIP-1137 #554 are not included.Checks
pnpm check:typespasses.pnpm vitest -c ./test/vitest.config.ts --project tempo-unit --run: 680 tests passed.biome checkon the changed files passes.Generated by Claude Code