8000 exp: attested signers (TIP-1159) [0.x] by jxom · Pull Request #553 · wevm/ox · GitHub
[go: up one dir, main page]

Skip to content

exp: attested signers (TIP-1159) [0.x] - #553

Draft
jxom wants to merge 7 commits into
0.xfrom
exp/attested-signers-0.x
Draft

jxom wants to merge 7 commits into
0.xfrom
exp/attested-signers-0.x

Conversation

@jxom
@jxom jxom commented Nov 1, 2026
Copy link
Copy Markdown
Member

Ports #552 to the 0.x line, which viem depends on. It is the same experimental API: AttestedSigner, the SignatureEnvelope attested (0x06) variant (transactions, key authorizations, configurable account owner approvals, rejected inside keychain signatures), and TxEnvelopeTempo.expiringNonceKey (TIP-1009). Every new API is marked @experimental.

Differences from #552:

  • The types use 0.x's bigint r/s/x/y and <bigintType, numberType> generics.
  • There are no zod schemas, since 0.x has no ox/zod.
  • 0.x's Rlp.toHex accepts trailing bytes, so the re-encode check rejects them as "non-canonical RLP" instead of "malformed RLP".

The encodings are byte-identical to #552: the vector snapshots match unchanged.

How to test

pnpm vitest -c ./test/vitest.config.ts --project tempo-unit --run
pnpm check:types

Generated by Claude Code

Ports #552 to the 0.x line: the AttestedSigner module, the
SignatureEnvelope `attested` (0x06) variant for transactions, key
authorizations, and configurable account owner approvals (rejected inside
keychain signatures), and TxEnvelopeTempo.expiringNonceKey (TIP-1009).
Adapted to 0.x bigint signature and public key coordinates. Encodings are
byte-identical to #552.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D3nmWiYLFXfCPHgz9FSm6L
@vercel
vercel Bot commented Nov 1, 2026 •
Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ox Ready Ready Preview Nov 1, 2026 10:15pm UTC

Request Review

The organization now allows only actions owned by wevm or GitHub, which
fails every job that sets up foundry from foundry-rs/foundry-toolchain.
Matches main (#549).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D3nmWiYLFXfCPHgz9FSm6L
jxom commented Nov 1, 2026 •
Copy link
Copy Markdown
Member Author

Verify / Test Runtime (tempo, env: localnet, tag: edge) failed here for a reason outside this PR.


Generated by Claude Code

The organization now allows only actions owned by wevm or GitHub, which
fails every job that sets up foundry from foundry-rs/foundry-toolchain.
Matches main (#549).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D3nmWiYLFXfCPHgz9FSm6L
Port of #554 to 0.x. TIP-1137 removes TIP-1049 admin access keys at T14.
The wire encoding is unchanged, so KeyAuthorization keeps encoding and
decoding `isAdmin` and `account` for pre-T14 history; `isAdmin` is now
deprecated in its TSDoc.

The edge e2e test that registered an admin key now asserts the T14 node
rejects it, and a new test covers an account-bound non-admin grant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D3nmWfJBrmCTSK7UpdbX4K
@github-actions
github-actions Bot commented Nov 1, 2026 •
Copy link
Copy Markdown
Contributor

Published ox@0.0.0-pr-553-542aab0 under the pr-553 dist-tag, which follows this pull request until it closes.

pnpm add ox@pr-553
pnpm add ox@0.0.0-pr-553-542aab0

jxom pushed a commit to wevm/viem that referenced this pull request Nov 1, 2026
Pins ox@0.0.0-pr-553-2249b12, which adds AttestedSigner and the attested (0x06) signature envelope. Owner approvals accept attested signatures.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D3nmWhznBuzqxnKfa9brpB
`AttestedSigner.registryAddress` is now `0x1161000000000000000000000000000000000000`,
the address TIP-1161 names, replacing the proof of concept's
`0xA77E570000000000000000000000000000000000`. The default registration
binding changes with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D3nmWiYLFXfCPHgz9FSm6L

This branch was successfully deployed

1 active deployment
Preview — 542aab08 Deployed Nov 1, 2026 by vercel[bot]
6CC0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0