fix(tempo): update admin access keys for TIP-1137 by jxom · Pull Request #554 · wevm/ox

jxom · 2026-11-01T07:37:10Z

TIP-1137 (tempoxyz/tempo#8204) removes TIP-1049 admin access keys at T14. This PR fixes the failing Verify / Test Runtime (tempo, env: localnet, tag: edge) job on main. The edge image runs T14, so the TIP-1049 admin access key round-trips through registration e2e test now fails with keychain precompile error: Account keychain error: InvalidKeyId. On tempo main, AccountKeychain::authorize_admin_key returns InvalidKeyId from T14.

Decode support kept

The TIP says KeyAuthorization "keeps its optional is_admin and account RLP fields. Encodings are unchanged." crates/primitives/src/transaction/key_authorization.rs still decodes both, and T6–T13 history must still round-trip. So ox keeps encoding, decoding and hashing isAdmin and account, and InvalidAdminMarkerError stays. There is no runtime change.

Changes

KeyAuthorization.ts: marked isAdmin @deprecated (in both the domain and RPC types) with a link to TIP-1137. The account docs now say that, when present, it must equal the transaction sender. Updated the MissingAccountError deprecation note and the inline wire comments.
KeyAuthorization.test.ts: renamed the codec tests to historical admin keys (TIP-1049) and noted that they cover pre-T14 history. Assertions are unchanged.
e2e.test.ts:
- Replaced the admin round-trip test with TIP-1137 rejects an admin key authorization. It sends the same transaction and asserts the node rejects it with InvalidKeyId.
- Added account-bound key authorization round-trips through registration. It checks that a non-admin account binding equal to the sender is accepted, and that account survives the node round trip.
- Renamed the byte-equivalence test.
- No configurable-account e2e test used admin-signed grants.
Site guides: the Admin Access Keys guide now opens with a T14 removal warning that points to configurable account owners. Fixed an outdated statement about how decoding treats isAdmin/account, and updated the card descriptions.
Changeset (patch).

Checks

pnpm check:types passes.
SKIP_GLOBAL_SETUP=1 pnpm test --project tempo-unit: 689 passed.
vp check on the changed files passes.
I couldn't run the e2e suite locally because there is no Docker, so the edge job in this PR's CI is the check for that part.

Generated by Claude Code

TIP-1137 removes TIP-1049 admin access keys at T14. The wire encoding is unchanged, so KeyAuthorization keeps encoding and decoding `isAdmin` and `account` for pre-T14 history; `isAdmin` is now deprecated in its TSDoc. The edge e2e test that registered an admin key now asserts the T14 node rejects it, and a new test covers an account-bound non-admin grant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3nmWfJBrmCTSK7UpdbX4K

vercel · 2026-11-01T07:37:15Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
ox	Error		Nov 1, 2026 7:38am UTC

jxom · 2026-11-01T07:39:03Z

The Vercel status is failing, but this PR didn't cause it. Vercel's combined status on main at 1c23934 is also failure (last updated 2026-10-31T17:07Z). #552 also targets main, changes no site/ files, and fails the same way. #553 passes, but it targets 0.x. No fix for the main deploy exists yet, and I can't re-run Vercel or read its logs from here, so I've left it as is.

Generated by Claude Code

chatgpt-codex-connector · 2026-11-01T07:42:40Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-01T07:46:04.734265Z	`cf7eccb`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf7eccb884

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-11-01T07:46:02Z

    icon="lucide:key-round"
    title="Access Keys"
-    description="Authorize scoped keys with expiry, limits, witnesses, and admin access."
+    description="Authorize scoped keys with expiry, limits, and witnesses."


Update the generated Tempo landing-page source

Updating only this hand-authored card leaves the generated /tempo landing page stale: scripts/docgen/build.ts:813-817 still emits an Access Keys card advertising “admin access,” so every pnpm docs:gen continues publishing the removed T14 capability on the main Tempo overview. Update that generator template alongside this guide text.

AGENTS.md reference: AGENTS.md:L70-L72

Useful? React with 👍 / 👎.

* chore: use vendored github actions in install-dependencies The organization now allows only actions owned by wevm or GitHub, which fails every job that sets up foundry from foundry-rs/foundry-toolchain. Matches main (#549). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3nmWiYLFXfCPHgz9FSm6L * fix(tempo): update admin access keys for TIP-1137 Port of #554 to 0.x. TIP-1137 removes TIP-1049 admin access keys at T14. The wire encoding is unchanged, so KeyAuthorization keeps encoding and decoding `isAdmin` and `account` for pre-T14 history; `isAdmin` is now deprecated in its TSDoc. The edge e2e test that registered an admin key now asserts the T14 node rejects it, and a new test covers an account-bound non-admin grant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3nmWfJBrmCTSK7UpdbX4K --------- Co-authored-by: Claude <noreply@anthropic.com>

vercel Bot had a problem deploying to Preview November 1, 2026 07:38 Failure

jxom marked this pull request as ready for review November 1, 2026 07:42

jxom merged commit 14ae9ac into main Nov 1, 2026
16 of 18 checks passed

jxom deleted the fix/tip-1137-remove-admin-keys branch November 1, 2026 07:42

jxom mentioned this pull request Nov 1, 2026

fix(tempo): update admin access keys for TIP-1137 [0.x] #555

Merged

chatgpt-codex-connector Bot reviewed Nov 1, 2026

View reviewed changes

github-actions Bot mentioned this pull request Nov 1, 2026

chore: version packages #545

Merged

jxom mentioned this pull request Nov 1, 2026

exp: attested signers (TIP-1159) #552

Draft

Navigation Menu

Repository navigation

fix(tempo): update admin access keys for TIP-1137 - #554

fix(tempo): update admin access keys for TIP-1137#554
jxom merged 1 commit into
mainfrom
fix/tip-1137-remove-admin-keys

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch had an error being deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Decode support kept

Changes

Checks

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Codex Review Summary

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch had an error being deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants