Repository navigation
ci: preserve independent v3 benchmark history (#840) - #854
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
adityamukho
marked this pull request as ready for review
November 5, 2026 03:26
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matching v3 change for #853, per the separate-PR policy for shared workflows.
Native uploads currently pass
--start-point mainon every v3 run. A newer main start point replaces the shared v3 Bencher head, losing independent comparison history for native and binding testbeds. The November 4 schedule split its 30 reports across two heads; 244 native and 26 binding baselines remained null.Keep persistent main/v3 histories, retaining main inheritance only for ad hoc comparison branches. Model settings stay at t-test probability 0.999 and maximum sample size 30. Existing replaced history is not restored.
Validation: upload-shell argument tests fail for v3 before the fix and all three pass afterward; both existing reporting test files also pass.
git diff --checkpasses.Does not close #840: the default-branch fix needs review, then independent measurements and controlled live notification checks remain.