Repository navigation
ci: preserve independent v3 benchmark history (#840) - #853
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
adityamukho
marked this pull request as ready for review
November 5, 2026 03:19
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native nightly uploads pass
--start-point mainon every v3 run. When main advances, Bencher replaces the shared v3 head: the November 4 schedule placed the C binding report on the old head and the other 29 reports on the new one. All 244 native and 26 binding comparison baselines were still null after three audited v3 runs.Keep main and v3 on their own existing histories; retain main inheritance for ad hoc comparison branches. This preserves the 0.999 t-test boundary and 30-sample maximum. It does not restore replaced history or claim baseline accumulation is complete.
Validation: the new test executes the workflow upload shell with a capture-only Bencher function. The v3 case failed before the fix; all three argument tests and both existing reporting test files pass afterward.
git diff --checkpasses.Separate production review for #840. Do not close #840: fresh independent runs and controlled live notification checks remain required.