Repository navigation
perf: net_asserted_facts re-runs over committed facts that live_facts already resolved #532
Description
Since #379, OnDiskReader::live_facts returns only the committed facts that survive net-assert. filter_facts_for_query still runs net_asserted_facts over the whole result, hashing (uuid, attr, value-bytes) for every row: about 10% of the attribute scan and the 3-clause join at 1M facts. Run it only over the pending facts plus the committed facts they touch.
Found by the #394 performance envelope (examples/perf_envelope.rs, results in docs/BENCHMARKS.md on v3).
Activity
adityamukho commentedon Oct 15, 2026
Likely superseded by the streaming engine (#473). The engine scans committed facts through
live_keys(net-assert decided on index keys, #379), so the extranet_asserted_factspass remains only in the old executor'sfilter_facts_for_query, which #551 removes. Plan: close as superseded once #551 lands.Before closing, verify that
filter_facts_for_query/net_asserted_factsover committed facts is no longer reached by any v3.0.0 query path (in particular rule queries after #548), and re-run the #394 envelope (examples/perf_envelope.rs) to confirm the ~10% is gone from the attribute scan and 3-clause join profiles.Merge pull request #775 from project-minigraf/docs/532-net-assert-audit