Repository navigation
docs(perf): verify committed net-assert is superseded (#532) - #775
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#532 identified a second
net_asserted_factspass over committed facts that the index reader had already resolved. #551 removed that query path, including rule queries. This PR records a pinned source audit and fresh bench-machine envelope/profiles verifying that the remaining production fact-level net-assert handles pending/staged records. No engine change is needed.The report includes raw results, independent row checks, reproducible drivers, environment/load observations, and the distinction between empty pending calls and committed-row hashing. It documents the discarded recursive capture, its zero-loss retry, and incomplete outer call chains. Source analysis is the primary proof; these measurements do not claim a controlled 10% speedup.
Validation:
Refs #532. The evidence supports closing it as superseded by #551 after this PR lands.