Repository navigation
19847 - Split UsersSection into components for better maintainability - #19848
Merged
jonkoops merged 1 commit intoMay 15, 2023
Merged
Conversation
1 flaky tests on run #7168 ↗︎Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Authentication test > should add a condition |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
edewit
requested changes
Apr 27, 2023
Contributor
There was a problem hiding this comment.
great contribution fix up these small issues and then we can merge this
andreas-blaettlinger-bosch
force-pushed
the
seperate_user_search_into_components
branch
from
April 27, 2023 13:45
8f5611a to
349e822
Compare
Contributor
Author
|
@edewit I updated PR with suggested fixes. Any further feedback? |
andreas-blaettlinger-bosch
force-pushed
the
seperate_user_search_into_components
branch
from
May 4, 2023 11:14
349e822 to
bee989a
Compare
edewit
approved these changes
May 10, 2023
Contributor
Author
|
@edewit There are some test errors but they are not related to my changes. Can you merge it anyway? |
jonkoops
approved these changes
May 15, 2023
Contributor
|
Thanks for this @andreas-blaettlinger! And apologies for the late review, things have been a bit bogged down recently. |
andreas-blaettlinger-bosch
deleted the
seperate_user_search_into_components
branch
May 16, 2023 07:43
ssilvert
added a commit
to ssilvert/keycloak
that referenced
this pull request
May 22, 2023
…keycloak#19848)" This reverts commit ab8366f. Fixes keycloak#20498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19847
As the UsersSection component is getting quite large, a split into sub-components was necessary to improve maintainability.