8000 19847 - Split UsersSection into components for better maintainability by andreas-blaettlinger-bosch · Pull Request #19848 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

19847 - Split UsersSection into components for better maintainability - #19848

Merged
jonkoops merged 1 commit into
keycloak:mainfrom
bosch-io:seperate_user_search_into_components
May 15, 2023
Merged

jonkoops merged 1 commit into
keycloak:mainfrom
bosch-io:seperate_user_search_into_components

Conversation

@andreas-blaettlinger-bosch
Copy link
Copy Markdown
Contributor

Closes #19847

As the UsersSection component is getting quite large, a split into sub-components was necessary to improve maintainability.

@cypress
cypress Bot commented Apr 20, 2023 •
Copy link
Copy Markdown

1 flaky tests on run #7168 ↗︎

0 516 47 0 Flakiness 1

Details:

Merge bee989a into 5bc2109...
Project: Keycloak Admin UI Commit: 5c5cc9d066 ℹ️
Status: Passed Duration: 14:58 💡
Started: May 10, 2023 8:59 AM Ended: May 10, 2023 9:14 AM
Flakiness  cypress/e2e/authentication_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Authentication test > should add a condition Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@edewit edewit left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great contribution fix up these small issues and then we can merge this

@andreas-blaettlinger-bosch
andreas-blaettlinger-bosch force-pushed the seperate_user_search_into_components branch from 8f5611a to 349e822 Compare April 27, 2023 13:45
@andreas-blaettlinger-bosch
Copy link
Copy Markdown
Contributor Author

@edewit I updated PR with suggested fixes. Any further feedback?

@andreas-blaettlinger-bosch
andreas-blaettlinger-bosch force-pushed the seperate_user_search_into_components branch from 349e822 to bee989a Compare May 4, 2023 11:14
@andreas-blaettlinger-bosch
Copy link
Copy Markdown
Contributor Author

@edewit There are some test errors but they are not related to my changes. Can you merge it anyway?

@jonkoops
jonkoops merged commit ab8366f into keycloak:main May 15, 2023
@jonkoops
Copy link
Copy Markdown
Contributor

Thanks for this @andreas-blaettlinger! And apologies for the late review, things have been a bit bogged down recently.

@andreas-blaettlinger-bosch
andreas-blaettlinger-bosch deleted the seperate_user_search_into_components branch May 16, 2023 07:43
ssilvert added a commit to ssilvert/keycloak that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split UsersSection into components for better maintainability

3 participants

0