8000 Revert "Split UsersSection into components for better maintainability… by ssilvert · Pull Request #20507 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Revert "Split UsersSection into components for better maintainability… - #20507

Closed
ssilvert wants to merge 1 commit into
keycloak:mainfrom
ssilvert:issue-20498-missing-search-field
Closed

ssilvert wants to merge 1 commit into
keycloak:mainfrom
ssilvert:issue-20498-missing-search-field

Conversation

@ssilvert
Copy link
Copy Markdown
Contributor

… (#19848)"

This reverts commit ab8366f.

Fixes #20498

@ssilvert
ssilvert requested a review from a team as a code owner May 22, 2023 19:12
@ghost ghost added the team/ui label May 22, 2023
@ssilvert
Copy link
Copy Markdown
Contributor Author

@andreas-blaettlinger It looks like the refactoring in #19847 broke the search bar when you have federated users. See #20498.

I couldn't see an easy way to restore this functionality and still meet your goal of better maintainability. It looks like it would require a bit more refactoring. If you want to fix this properly within your original PR then that would be welcome. But we need to revert those changes in #19847 for the time being.

@cypress
cypress Bot commented May 22, 2023
Copy link
Copy Markdown

Passing run #7303 ↗︎

0 525 48 0 Flakiness 0

Details:

Merge 87094e0 into d7d6b83...
Project: Keycloak Admin UI Commit: 5e2a66e48f ℹ️
Status: Passed Duration: 16:20 💡
Started: May 22, 2023 7:28 PM Ended: May 22, 2023 7:44 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@andreas-blaettlinger-bosch
Copy link
Copy Markdown
Contributor

I will look into it and try to come up with a solution.

@andreas-blaettlinger-bosch
Copy link
Copy Markdown
Contributor

Found the root cause of the error, provided a fix in #20539.

@jonkoops
Copy link
Copy Markdown
Contributor

Superseded by #20539

@jonkoops jonkoops closed this May 24, 2023
@ssilvert
ssilvert deleted the issue-20498-missing-search-field branch January 10, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When user federation is enabled, admin console user search doesn't show search field

3 participants

0