Repository navigation
Conversation
…keycloak#19848)" This reverts commit ab8366f. Fixes keycloak#20498
Contributor
Author
|
@andreas-blaettlinger It looks like the refactoring in #19847 broke the search bar when you have federated users. See #20498. I couldn't see an easy way to restore this functionality and still meet your goal of better maintainability. It looks like it would require a bit more refactoring. If you want to fix this properly within your original PR then that would be welcome. But we need to revert those changes in #19847 for the time being. |
Passing run #7303 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
jonkoops
approved these changes
May 23, 2023
Contributor
|
I will look into it and try to come up with a solution. |
Contributor
|
Found the root cause of the error, provided a fix in #20539. |
Contributor
|
Superseded by #20539 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (#19848)"
This reverts commit ab8366f.
Fixes #20498