8000 17728 - Added User Attribute Search by andreas-blaettlinger-bosch · Pull Request #19574 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

17728 - Added User Attribute Search - #19574

Merged
jonkoops merged 1 commit into
keycloak:mainfrom
bosch-io:17728_UserAttributeSearch
Jun 12, 2023
Merged

jonkoops merged 1 commit into
keycloak:mainfrom
bosch-io:17728_UserAttributeSearch

Conversation

@andreas-blaettlinger-bosch
Copy link
Copy Markdown
Contributor

Added first draft for user attribute search.

Closes #17728

Comment thread 8000 .gitignore Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this as it is already in the .gitignore file for the js directory and themes directory. That should be enough.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jonkoops jonkoops left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a preliminary review here, I'll be adding some more comments.

Comment thread .gitignore Resolved
@jonkoops
jonkoops commented Apr 7, 2023
Copy link
Copy Markdown
Contributor

I think it might be worth it to open up a separate PR to split out the UsersSection into multiple components first. It's getting way too big and complex to remain maintainable.

@ssilvert
Copy link
Copy Markdown
Contributor

@andreas-blaettlinger Please fix conflicts.

@ssilvert
Copy link
Copy Markdown
Contributor

@andreas-blaettlinger Please fix conflicts.

Nevermind. I think the conflicts resolved themselves after a commit was reverted.

@andreas-blaettlinger-bosch
Copy link
Copy Markdown
Contributor Author

Rebase & first improvements done. Will look further into other suggestions in the next days.

@andreas-blaettlinger-bosch
andreas-blaettlinger-bosch force-pushed the 17728_UserAttributeSearch branch 2 times, most recently from 0b3ba0b to 01a8966 Compare April 12, 2023 13:20
@andreas-blaettlinger-bosch
Copy link
Copy Markdown
Contributor Author

@jonkoops I would like to start to seperate the old user search into components in a new PR; is there already an issue for this?

@jonkoops
Copy link
Copy Markdown
Contributor

@andreas-blaettlinger Yes I think that is a good idea. We can consider that a task so we don't have to create an issue for it. If we do need one we can always create one later.

@andreas-blaettlinger-bosch
Copy link
Copy Markdown
Contributor Author

@jonkoops As discussed, I created a seperate PR for the split into sub-components: #19848
Feedback very welcome!

@jonkoops
Copy link
Copy Markdown
Contributor

@andreas-blaettlinger I think this PR can be rebased right? Let's see if we can land this 😄

@andreas-blaettlinger-bosch
Copy link
Copy Markdown
Contributor Author

@jonkoops Rebased this PR and adapted changes. I have continued to follow the strategy of multiple components.

@cypress
cypress Bot commented May 26, 2023 •
Copy link
Copy Markdown

1 flaky tests on run #7366 ↗︎

0 525 48 0 Flakiness 1

Details:

Merge a647c5c into b438776...
Project: Keycloak Admin UI Commit: b0bbc1da5c ℹ️
Status: Passed Duration: 16:26 💡
Started: May 26, 2023 3:39 PM Ended: May 26, 2023 3:55 PM
Flakiness  cypress/e2e/authentication_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Authentication test > should add a condition Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@andreas-blaettlinger-bosch
Copy link
Copy Markdown
Contributor Author

There was a failing cypress test. Looking forward for the new test results. 👀

@jonkoops
Copy link
Copy Markdown
Contributor

Seeing as the tests are now passing should we mark this as ready to be reviewed @andreas-blaettlinger?

@jonkoops
jonkoops marked this pull request as ready for review May 30, 2023 12:01
@jonkoops
jonkoops requested a review from a team as a code owner May 30, 2023 12:01
@jonkoops jonkoops left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agagancarczyk agagancarczyk left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonkoops
jonkoops merged commit 35736b8 into keycloak:main Jun 12, 2023
@jonkoops
Copy link
Copy Markdown
Contributor

Thank for the contribution and your patience @andreas-blaettlinger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User attribute search

4 participants

0