Repository navigation
17728 - Added User Attribute Search - #19574
Conversation
There was a problem hiding this comment.
I don't think we need this as it is already in the .gitignore file for the js directory and themes directory. That should be enough.
There was a problem hiding this comment.
Fixed
There was a problem hiding this comment.
Got a preliminary review here, I'll be adding some more comments.
|
I think it might be worth it to open up a separate PR to split out the |
|
@andreas-blaettlinger Please fix conflicts. |
Nevermind. I think the conflicts resolved themselves after a commit was reverted. |
5b9f3b6 to
7dfb095
Compare
|
Rebase & first improvements done. Will look further into other suggestions in the next days. |
0b3ba0b to
01a8966
Compare
|
@jonkoops I would like to start to seperate the old user search into components in a new PR; is there already an issue for this? |
|
@andreas-blaettlinger Yes I think that is a good idea. We can consider that a task so we don't have to create an issue for it. If we do need one we can always create one later. |
|
@andreas-blaettlinger I think this PR can be rebased right? Let's see if we can land this 😄 |
01a8966 to
4edcc45
Compare
|
@jonkoops Rebased this PR and adapted changes. I have continued to follow the strategy of multiple components. |
1 flaky tests on run #7366 ↗︎Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Authentication test > should add a condition |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
4edcc45 to
a647c5c
Compare
|
There was a failing cypress test. Looking forward for the new test results. 👀 |
|
Seeing as the tests are now passing should we mark this as ready to be reviewed @andreas-blaettlinger? |
|
Thank for the contribution and your patience @andreas-blaettlinger! |
Added first draft for user attribute search.
Closes #17728