Repository navigation
Plan: record what the parser-correctness sweep proved - #678
Merged
Merged
Conversation
Two bugs the plan listed as deferred are fixed (genre pagination, Miyazaki's published manga), the witness count is 19 rather than 41, and all 19 are upstream absence or recording coverage rather than parser bugs. Adds the sweep section with the invariant debt (34 -> 10), the two batches in review, and the open deprecate-or-derive decision.
The witness count drops to 18 once the recordings in #681 land, the Source-selector check covered both seasonal pages (92/92 and 420/421, not 420/421 overall), and the deprecate-or-derive question was settled in #680. The stale 38-field line in the audit questions now points at the triage instead of asking again.
irfan-dahir
force-pushed
the
docs/plan-sweep-findings
branch
from
November 12, 2026 13:19
1745b77 to
363abfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only.
PLAN.mdstill described the backlog as it stood before the sweep, in ways that would send the next person down dead ends.What changed
hasNextPage=true,lastVisiblePage=20(manga too), and Miyazaki'spublishedMangareturns 14 entries.41 fields remain never filled→ 19, and all 19 are triaged.explicitGenres— MAL removed the sidebar row (40 recorded detail pages, including anR+title)filler/recap— not on the single-episode page at allstudios/licensors/season*/magazines/addedToList— null/false upstream on two users, one checked live todayhasNextPageflags — those recordings genuinely have no next pageisSpoiler— no spoiler-tagged review on that user's page; anime reviews tag and parse finegetSource()selects the second property by position, so a new property inserted before "Source" would return a wrong value silently.No code, no changelog (nothing consumer-visible).
composer qualitygreen at 1059 tests.