8000 Record two pages the sweep could not see: OLM producer, spoiler-tagged review by irfan-dahir · Pull Request #681 · jikan-me/jikan · GitHub
[go: up one dir, main page]

Skip to content

Record two pages the sweep could not see: OLM producer, spoiler-tagged review - #681

Merged
irfan-dahir merged 3 commits into
masterfrom
test/variant-producer-one-section
Nov 12, 2026
Merged

irfan-dahir merged 3 commits into
masterfrom
test/variant-producer-one-section

Conversation

@irfan-dahir
@irfan-dahir irfan-dahir commented Nov 11, 2026 •
Copy link
Copy Markdown
Collaborator

Adds two corpus variants — no production code, no changelog. Both were chosen from the field-witness triage, and both change what the sweep can prove.

variant why
producer-28-p1 (OLM) the real case behind #672: "Available At" links and no "Resources" section, which getExternalLinks() answered with []. Until now the fix was pinned only by a synthetic test that deletes a section from the Pierrot page.
user-reviews-noya-xoxo the one recorded user-reviews page had no spoiler-tagged review, so UserAnimeReview::isSpoiler was never true. This page has one; the snapshot carries isSpoiler: true.

Both recorded live on 2026-11-11 via php scripts/record_variants.php --live --> (GET, 3.5s apart). The OLM id carries the page suffix (-p1) to match producer-1-p1/-p2.

Effect on the witness report: 19 → 18 fields. isSpoiler is filled now; the producer variant pins #672 against live markup instead of a synthetic crawler.

Verification

Not recorded: a user list with rewatch flags set. Four public lists (~1,200 items) all carry is_rewatching 0 or ""; finding one needs a known user rather than a search, so it stays a coverage gap.

@irfan-dahir irfan-dahir changed the title Record a producer page with only one external-link section Record two pages the sweep could not see: OLM producer, spoiler-tagged review Nov 11, 2026
irfan-dahir added a commit that referenced this pull request Nov 11, 2026
The witness count drops to 18 once the recordings in #681 land, the
Source-selector check covered both seasonal pages (92/92 and 420/421, not
420/421 overall), and the deprecate-or-derive question was settled in
#680. The stale 38-field line in the audit questions now points at the
triage instead of asking again.
OLM (producer 28) has "Available At" links and no "Resources" section, which is
the shape getExternalLinks() returned [] for before jikan#672. The variant
pins the fix against a real page, not only a synthetic crawler.
No recorded user-reviews page carried a spoiler tag, so UserAnimeReview::isSpoiler
could never be true. Noya_xoxo has one; the variant pins it, and the field leaves
the witness report.
The other producer variants carry their page number; this one page is the
first, so the suffix is p1.
@irfan-dahir
irfan-dahir force-pushed the test/variant-producer-one-section branch from d58c757 to fc62d47 Compare November 12, 2026 13:18
@irfan-dahir
irfan-dahir merged commit 37f3ea0 into master Nov 12, 2026
6 checks passed
irfan-dahir added a commit that referenced this pull request Nov 12, 2026
The witness count drops to 18 once the recordings in #681 land, the
Source-selector check covered both seasonal pages (92/92 and 420/421, not
420/421 overall), and the deprecate-or-derive question was settled in
#680. The stale 38-field line in the audit questions now points at the
triage instead of asking again.
irfan-dahir added a commit that referenced this pull request Nov 12, 2026
fixtures#21/#22/#23 and jikan#676/#677/#680/#681 merged today, so the
section no longer describes work in flight and the witness count is 18
rather than 19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0