Repository navigation
Deprecate getExplicitGenres; record why the user-list fields can never fill - #680
Merged
Merged
Conversation
MAL removed the separate "Explicit Genres" row (no occurrence in 40 recorded detail pages, including an R+ title), so Anime/Manga getExplicitGenres() can only return []. They are deprecated in favour of getGenres(), where explicit genres now appear. The user-list fields no public recording fills (studios, licensors, season, magazines, addedToList) are NOT deprecated: there is no replacement, and DEPRECATIONS.md section 4 says a deprecation with no replacement is a removal with a waiting period. DECISIONS.md records the evidence (four public lists, ~1,000 items, all null/false) and why they stay as they are.
irfan-dahir
added a commit
that referenced
this pull request
Nov 11, 2026
The witness count drops to 18 once the recordings in #681 land, the Source-selector check covered both seasonal pages (92/92 and 420/421, not 420/421 overall), and the deprecate-or-derive question was settled in #680. The stale 38-field line in the audit questions now points at the triage instead of asking again.
Two rows (getExplicitGenres) are an upstream removal, not the title accessor migration, so "Most current rows" is the accurate opening.
…s in Genres The deprecation says MAL removed the row and moved explicit genres among the genres. That claim was only evidence in a PR body and a DECISIONS entry; on anime/11617 (rated R+, lists Ecchi) it is now asserted, and the manga getter is pinned empty as well.
Collaborator
Author
|
The deprecation's premise is now executable, not just prose (commit
So if MyAnimeList ever brings the row back, a test fails instead of the deprecation quietly becoming wrong. Full quality green: 1065 tests / 12479 assertions; ledger still reconciles 11 |
irfan-dahir
changed the base branch from
v5/parser-correctness-sweep-source
to
master
November 12, 2026 13:16
irfan-dahir
added a commit
that referenced
this pull request
Nov 12, 2026
The witness count drops to 18 once the recordings in #681 land, the Source-selector check covered both seasonal pages (92/92 and 420/421, not 420/421 overall), and the deprecate-or-derive question was settled in #680. The stale 38-field line in the audit questions now points at the triage instead of asking again.
irfan-dahir
added a commit
that referenced
this pull request
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #677 (which is stacked on #676) so the changelog does not collide; retarget to
masterafter those land.Closing out the field-witness triage with two different answers, because the two situations are different.
Deprecated:
getExplicitGenres()MyAnimeList removed the separate "Explicit Genres" sidebar row — zero occurrences across 40 recorded detail pages, including an
R+title — soAnime::getExplicitGenres()andManga::getExplicitGenres()can only return[]. Explicit genres now appear among the genres (Ecchi is inGenreson the page), so there is a real replacement:@deprecated Use {@link Anime::getGenres()} instead.DEPRECATIONS.mdrows withUse instead, removal not scheduled### Deprecatedchangelog entryThis is the one case where deprecation is the right instrument:
DEPRECATIONS.md§4 requires a real replacement before one is announced, and this has one.Not deprecated: the user-list fields
AnimeListItem::getStudios(),getLicensors(),getSeasonName(),getSeasonYear(),isAddedToList()andMangaListItem::getMagazines(),isAddedToList()are never filled by any recording. They stay exactly as they are.Why not deprecate: there is no replacement (so §4's rule applies — a deprecation without one is a removal with a waiting period), and §3 says deprecations are never reversed. Announcing one here would commit to a breaking removal with no migration path, for fields that are simply unreachable.
Evidence recorded in a new
DECISIONS.mdentry: MAL's publicload.jsonreturnsnull/falsefor all of them across four public lists, ~1,000 items (Xinil, Sandshark, DatRandomDude, zombie_pegasus — two checked live today). And jikan never authenticates, so if those values are only populated for the list's owner, they are unreachable for this library by design.Verification
grep -rn "@deprecated" src/Model→ 11, andDEPRECATIONS.md§1 has 11 rows — the ledger reconciles in both directions, as §5 requires.composer qualitygreen: 1063 tests / 12476 assertions, PHPStan, php-cs-fixer, endpoint manifest.