Repository navigation
Format combined memory-handle and graphics-registration flags - #57
Draft
RicheyWorks wants to merge 1 commit into
Draft
RicheyWorks wants to merge 1 commit into
RicheyWorks wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some flag
stringFormethods still use single-value switches, so combinations are reported asINVALID. For example,CUmemAllocationHandleType.stringFor(6)loses the Win32 and Win32-KMT flag names, andcudaGraphicsRegisterFlags.stringFor(9)loses ReadOnly and TextureGather.Related to #33. Decode combinations of the independent bits currently declared in these two classes, using space-separated names in declaration order. Keep the switches for existing exact-value strings (including zero and the existing handle sentinel), and retain the complete numeric INVALID diagnostic if any unknown bits occur. Document that formatting bits does not validate platform/resource/API compatibility.
This is a focused part of #33, not a claim that every flag formatter is now consistent. It does not add missing CUDA constants or change existing numeric values, JNI, resource registration or allocation behavior.
Verification:
5ecd90cconfirmed against the remote; no overlapping open or closed flag PR found.CUDA flag definitions: driver types, runtime types.