Repository navigation
Support CharBuffer in Pointer.toBuffer - #51
Draft
RicheyWorks wants to merge 1 commit into
Draft
RicheyWorks wants to merge 1 commit into
RicheyWorks wants to merge 1 commit into
Conversation
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointer.toBuffer(Buffer)rejects everyCharBufferas an unknown buffer type, even thoughPointer.to(char[])andPointer.to(Buffer)already accept character data. The missing dispatch also prevents callers from obtaining character pointers that account for the buffer's current position and array slice offset.Add a
CharBufferpath that computes byte offsets usingSizeof.CHAR. Array-backed buffers include the array offset; direct buffers retain the slice's native origin and apply the position as a byte offset. Work on a duplicate to preserve the caller's mark, position and limit, and perform offset arithmetic aslong.The shared JNI code already uses generic
GetPrimitiveArrayCriticalandGetDirectBufferAddresspaths (jcuda-common, commit9d41fb5), so no native code or signatures change. Read-only heap buffers remain unsupported under the existing input validation.Validation:
IllegalArgumentException: Unknown buffer typeon unchanged upstream; after the fix all six pass under Maven with declared JUnit 4.13.1.