Repository navigation
Preserve direct buffer marks in Pointer.toBuffer - #49
Draft
RicheyWorks wants to merge 1 commit into
Draft
RicheyWorks wants to merge 1 commit into
RicheyWorks wants to merge 1 commit into
Conversation
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Pointer.toBufferon a direct buffer temporarily lowers its position to zero, discarding any nonzero mark. Restoring the position does not restore the mark, so a later callerreset()throwsInvalidMarkException.Duplicate the supplied direct buffer before adjusting its position in each of the six supported typed overloads. The duplicate shares the same memory and retains the existing byte-offset calculation, while leaving the caller's position, limit and mark intact. Document this behavior and add 13 regression cases covering direct buffers, slices and a read-only byte buffer.
Validation:
PointerBufferStateTest: 13 tests, 0 failures, 0 errors, 0 skipped, using the declared JUnit 4.13.1.jcuda-parentPOM installed into an isolated local cache used Java 8 source/target. No POM adjustment is included in this contribution.javac --release 8.