Repository navigation
Conversation
Mail a filter filed into another folder was announced as new mail whatever the destination, so a message moved straight to Trash or Junk still raised a notification and its sound while the tray icon, which counts only what stays in the inbox, showed nothing new. Leave out mail filed into Trash or Junk; mail filed anywhere else is still announced.
hyprlab
added a commit
that referenced
this pull request
Nov 9, 2026
A filter that moved new mail to Trash or Junk still raised a notification and its sound. Mail filed anywhere else is still announced. Co-Authored-By: Fabio Rotondo <2844375+fsoft72@users.noreply.github.com>
Owner
|
Thank you! This PR will be merged in today's beta build! |
Owner
|
Agentic reply: The beta build is in the repo now. If you already have the beta installed, flatpak install --user --from https://hylki.hyprlab.co/flatpak/co.hyprlab.Hylki.Beta.flatpakrefRPM, Debian and AppImage betas: Beta channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a filter moves a newly arrived message straight into Trash or Junk, Hylki still raises a new mail notification (and plays its sound). The tray icon, which counts only what stays in the inbox, correctly shows nothing new, so the two disagree.
The cause is in
notify_new_mail(src/app/events_messages.rs): mail a filter filed elsewhere is counted as new mail (#47 feedback) whatever its destination folder.Fix
announces_filedhelper: mail filed into aTrashorJunkfolder is left out of the notification; mail filed into any other folder (or a folder not known yet) is still announced as before.Tests
announces_filed(failed before the fix).cargo test --bin hylki: 1459 passed.🤖 Generated with Claude Code