8000 Add reusable templates, quick inserts, and signature sender names by FLASH911 · Pull Request #610 · hyprlab/hylki · GitHub
[go: up one dir, main page]

Skip to content

Add reusable templates, quick inserts, and signature sender names - #610

Closed
FLASH911 wants to merge 7 commits into
hyprlab:mainfrom
FLASH911:composer-workflows
Closed

FLASH911 wants to merge 7 commits into
hyprlab:mainfrom
FLASH911:composer-workflows

Conversation

@FLASH911
@FLASH911 FLASH911 commented Nov 7, 2026
Copy link
Copy Markdown
Contributor

Summary

This PR adds composer-focused workflows for reusing saved text and sending from the right identity.

Changes

  • Insert a saved full-message template directly into a reply or the open composer at the caret.
  • Add a configurable quick-insert library managed under Settings → Composing.
  • Ship English and Russian starter phrases in the same library, independent of the UI language.
  • Offer inline quick-insert completion after three typed characters. Tab accepts the top match, Up/Down selects another, and Esc dismisses the card without closing the message.
  • Support completion in rich text, plain text, Markdown, and HTML source modes.
  • Allow multiple send-as identities to use the same address when they share the account SMTP transport.
  • Let each signature override the sender display name while keeping the selected email address unchanged.

Compatibility

  • Configs without quick_inserts receive the bilingual starter set through serde(default).
  • An explicitly empty quick-insert list remains empty.
  • Existing named signatures without a sender-name override keep their current behavior.
  • No database migration is required.

Validation

  • cargo test: 1424 passed, 0 failed, 49 ignored.
  • msgfmt --check and documentation checks pass.
  • JavaScript syntax and JSON escaping for inline completion are covered by checks/tests.

Review notes

This PR intentionally contains only composer/account workflow changes. Reader/menu fixes and themes are proposed separately.

Several display names can represent one mailbox, such as a manager and a director. Keep SMTP unambiguous by allowing shared addresses only through the account transport.

(cherry picked from commit edc95da)
Add a template picker to the formatting row and insert the chosen body above the quoted original. Keep the current recipients and signature, and name the existing signature picker by what it does.

(cherry picked from commit 739ce9b)
(cherry picked from commit 46b227d4c1c9f6688df3f26006687bc6a34564e8)
hyprlab added a commit that referenced this pull request Nov 9, 2026
One mailbox can send under several names, such as a manager and a director. A shared address sends through the account's own SMTP server, because the send path picks an alias's server by address, and a draft reopens on the name it was saved with.

Co-Authored-By: FLASH911 <6452736+FLASH911@users.noreply.github.com>
hyprlab added a commit that referenced this pull request Nov 9, 2026
Insert Template in the formatting row puts a template's text at the cursor, so a reply can use a standard answer and keep its recipients and quote. The button shows only when an account has a Templates folder.

Co-Authored-By: FLASH911 <6452736+FLASH911@users.noreply.github.com>
hyprlab added a commit that referenced this pull request Nov 9, 2026
One shared mailbox can sign as different people. The name goes on the account's own address only, so aliases that share the address keep their own names.

Co-Authored-By: FLASH911 <6452736+FLASH911@users.noreply.github.com>
hyprlab added a commit that referenced this pull request Nov 9, 2026
Co-Authored-By: FLASH911 <6452736+FLASH911@users.noreply.github.com>
hyprlab added a commit that referenced this pull request Nov 9, 2026
Insert Template, shared send-as addresses and a signature's sender name (#610), Microsoft accounts after a suspend (#618), the merge CSV freeze (#617), no alert for mail filed to Trash or Junk (#621), reader colors (#619, #616), the delete warning translated (#620) and French (#615).
@hyprlab
hyprlab commented Nov 9, 2026
Copy link
Copy Markdown
Owner

Agentic reply:

Insert Template, several names on one send-as address and the signature's sender name are in the 1.48.0-beta.4 release, landed by hand and credited to you. At landing, an alias with its own SMTP server was kept from taking a shared address, since the server is chosen by address, and the sender name was limited to the account's own address so aliases keep their names. Please test it there and report anything that doesn't look right. It reaches the stable channel with the next stable release.

The quick inserts and inline completion were left out. Every user would have had the English and Russian starter phrases whatever their language, the completion card had no off switch, and Tab waited on the editor each time it was pressed.

The beta build is in the repo now. If you already have the beta installed, flatpak update picks it up. If not, download and install it first:

flatpak install --user --from https://hylki.hyprlab.co/flatpak/co.hyprlab.Hylki.Beta.flatpakref

RPM, Debian and AppImage betas: Beta channel.

@hyprlab hyprlab closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0